From 18818c9ba5816cee2ee6f94fd88c0fbc1c3c4987 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 14 Jul 2014 07:34:31 -0700 Subject: [PATCH 1/3] Special case quoting of certain explorer args This is required for things like: `explorer.exe /root,C:\a\folder` to spawn correctly. Refs atom/tree-view#180 --- src/buffered-process.coffee | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/buffered-process.coffee b/src/buffered-process.coffee index d0bbd03e5..3c7a59171 100644 --- a/src/buffered-process.coffee +++ b/src/buffered-process.coffee @@ -46,7 +46,13 @@ class BufferedProcess if process.platform is "win32" # Quote all arguments and escapes inner quotes if args? - cmdArgs = args.map (arg) -> "\"#{arg.replace(/"/g, '\\"')}\"" + cmdArgs = args.map (arg) -> + if command in ['explorer.exe', 'explorer'] and /^\/[a-zA-Z]+,.*$/.test(arg) + # Don't wrap /root,C:\folder style arguments to explorer calls in + # quotes # since they will not be interpreted correctly if they are + arg + else + "\"#{arg.replace(/"/g, '\\"')}\"" else cmdArgs = [] cmdArgs.unshift("\"#{command}\"") From c355ade47747e883c3f96a16b28eab6fbd583aa2 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 14 Jul 2014 07:38:49 -0700 Subject: [PATCH 2/3] Upgrade to tree-view@0.110.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b6e085a4e..0b6d74599 100644 --- a/package.json +++ b/package.json @@ -102,7 +102,7 @@ "symbols-view": "0.60.0", "tabs": "0.45.0", "timecop": "0.21.0", - "tree-view": "0.109.0", + "tree-view": "0.110.0", "update-package-dependencies": "0.6.0", "welcome": "0.17.0", "whitespace": "0.24.0", From 0faff626d1534a493177065333d9ef12882ad251 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 14 Jul 2014 07:42:58 -0700 Subject: [PATCH 3/3] Remove stray # --- src/buffered-process.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/buffered-process.coffee b/src/buffered-process.coffee index 3c7a59171..fe4f3e840 100644 --- a/src/buffered-process.coffee +++ b/src/buffered-process.coffee @@ -49,7 +49,7 @@ class BufferedProcess cmdArgs = args.map (arg) -> if command in ['explorer.exe', 'explorer'] and /^\/[a-zA-Z]+,.*$/.test(arg) # Don't wrap /root,C:\folder style arguments to explorer calls in - # quotes # since they will not be interpreted correctly if they are + # quotes since they will not be interpreted correctly if they are arg else "\"#{arg.replace(/"/g, '\\"')}\""