From 9d60fd2322975775b31f774b13c94a2599aecc35 Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Fri, 28 Nov 2014 11:42:01 -0800 Subject: [PATCH] Deprecate `changeFocus` option to Workspace::open Its documentation was already removed, and it was already deprecated in ::openSync. --- src/workspace.coffee | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/workspace.coffee b/src/workspace.coffee index 556ddaf43..dfbb6039c 100644 --- a/src/workspace.coffee +++ b/src/workspace.coffee @@ -377,11 +377,15 @@ class Workspace extends Model # * `activatePane` A {Boolean} indicating whether to call {Pane::activate} on # the containing pane. Defaults to `true`. openSync: (uri='', options={}) -> - deprecate("Don't use the `changeFocus` option") if options.changeFocus? + # TODO: Remove deprecated changeFocus option + if options.changeFocus? + deprecate("The `changeFocus` option has been renamed to `activatePane`") + options.activatePane = options.changeFocus + delete options.changeFocus {initialLine, initialColumn} = options - # TODO: Remove deprecated changeFocus option - activatePane = options.activatePane ? options.changeFocus ? true + activatePane = options.activatePane ? true + uri = atom.project.resolve(uri) item = @activePane.itemForUri(uri) @@ -395,7 +399,13 @@ class Workspace extends Model item openUriInPane: (uri, pane, options={}) -> - changeFocus = options.changeFocus ? true + # TODO: Remove deprecated changeFocus option + if options.changeFocus? + deprecate("The `changeFocus` option has been renamed to `activatePane`") + options.activatePane = options.changeFocus + delete options.changeFocus + + activatePane = options.activatePane ? true if uri? item = pane.itemForUri(uri) @@ -409,7 +419,7 @@ class Workspace extends Model @paneContainer.root = pane @itemOpened(item) pane.activateItem(item) - pane.activate() if changeFocus + pane.activate() if activatePane index = pane.getActiveItemIndex() @emit "uri-opened" @emitter.emit 'did-open', {uri, pane, item, index}