github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-13 16:14:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add bounds checking for overlay decorations

Browse Source
This commit is contained in:
Ben Ogle
2014-11-11 15:46:27 -08:00
parent 661b09ab1c
commit 9dfaa8a4e5
2 changed files with 115 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/overlay-manager.coffee
View File

@@ -13,7 +13,7 @@ class OverlayManager
startPixelPosition
else
endPixelPosition
@renderOverlay(hostElement, decoration, pixelPosition, lineHeightInPixels)
@renderOverlay(editor, hostElement, decoration, pixelPosition, lineHeightInPixels)
existingDecorations ?= {}
existingDecorations[decoration.id] = true
@@ -25,11 +25,21 @@ class OverlayManager
return
renderOverlay: (hostElement, decoration, pixelPosition, lineHeightInPixels) ->
renderOverlay: (editor, hostElement, decoration, pixelPosition, lineHeightInPixels) ->
item = atom.views.getView(decoration.item)
unless overlay = @overlays[decoration.id]
overlay = @overlays[decoration.id] = document.createElement('atom-overlay')
overlay.appendChild(atom.views.getView(decoration.item))
overlay.appendChild(item)
hostElement.appendChild(overlay)
overlay.style.top = pixelPosition.top + lineHeightInPixels + 'px'
overlay.style.left = pixelPosition.left + 'px'
itemWidth = item.offsetWidth
itemHeight = item.offsetHeight
left = pixelPosition.left
left -= itemWidth if left + itemWidth - editor.getScrollLeft() > editor.getWidth()
top = pixelPosition.top + lineHeightInPixels
top -= itemHeight + lineHeightInPixels if top + itemHeight - editor.getScrollTop() > editor.getHeight()
overlay.style.top = top + 'px'
overlay.style.left = left + 'px'