From 8ae5c3664f76682fa77f33ef9b52a9ed66d88ce5 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Sun, 8 Apr 2018 17:29:11 -0400 Subject: [PATCH 01/10] Weekly focus document template --- docs/focus/2018-04-09.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 docs/focus/2018-04-09.md diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md new file mode 100644 index 000000000..d3fe41827 --- /dev/null +++ b/docs/focus/2018-04-09.md @@ -0,0 +1,14 @@ +## Highlights from the past week + +- Atom IDE +- GitHub Package +- Teletype +- Xray +- Reactor Duty + +## Focus for week ahead + +- GitHub Package +- Teletype +- Tree-sitter +- Xray From 90b20de94aee309eb7c7c8f6221c571d401f6ac6 Mon Sep 17 00:00:00 2001 From: Ash Wilson Date: Sun, 8 Apr 2018 17:36:21 -0400 Subject: [PATCH 02/10] @smashwilson's update for last week. More sparse than I like to see :disappointed: --- docs/focus/2018-04-09.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index d3fe41827..7bd1e134e 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -2,6 +2,8 @@ - Atom IDE - GitHub Package + - Began transcribing our vision meeting notes in [atom/github#1372](https://github.com/atom/github/pull/1372). @smashwilson + - More progress on [atom/github#1376 "Create pull request"](https://github.com/atom/github/pull/1376). The happy paths work well for publishing and pushing a branch, but it isn't ready to merge until I adjust our messaging in a few edge cases. @smashwilson - Teletype - Xray - Reactor Duty @@ -9,6 +11,8 @@ ## Focus for week ahead - GitHub Package + - Get "Create pull request" [atom/github#1376](https://github.com/atom/github/pull/1376) merged. @smashwilson + - Revive the React 16 and Enzyme port started in [atom/github#1174](https://github.com/atom/github/pull/1174). @smashwilson - Teletype - Tree-sitter - Xray From 11f747dc4c6c03d6e19fa59c64f4b9c6c815d767 Mon Sep 17 00:00:00 2001 From: Tilde Ann Thurium Date: Sun, 8 Apr 2018 17:13:10 -0700 Subject: [PATCH 03/10] add @annthurium's contributions from last wek --- docs/focus/2018-04-09.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index 7bd1e134e..4164baf22 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -4,6 +4,8 @@ - GitHub Package - Began transcribing our vision meeting notes in [atom/github#1372](https://github.com/atom/github/pull/1372). @smashwilson - More progress on [atom/github#1376 "Create pull request"](https://github.com/atom/github/pull/1376). The happy paths work well for publishing and pushing a branch, but it isn't ready to merge until I adjust our messaging in a few edge cases. @smashwilson + - Started implementing [atom/github/#1374 "Add dialog for new co-author"](https://github.com/atom/github/pull/1374). This includes UI polish and some bugfixes for existing co author flows. @kuychaco / @annthurium + - Merged [atom/github#1364 "Undo last commit and amend context menu option"](https://github.com/atom/github/pull/1364) @kuychaco / @annthurium - Teletype - Xray - Reactor Duty @@ -12,6 +14,8 @@ - GitHub Package - Get "Create pull request" [atom/github#1376](https://github.com/atom/github/pull/1376) merged. @smashwilson + - Get "Add dialog for new co-author" [atom/github#1374](https://github.com/atom/github/pull/1374) merged. @annthurium / @kuychaco + - Start implementing code coverage to get better visibility into our unit test coverage gaps. @annthurium - Revive the React 16 and Enzyme port started in [atom/github#1174](https://github.com/atom/github/pull/1174). @smashwilson - Teletype - Tree-sitter From 7592ffb319c057297adec11b4022962313c47fdd Mon Sep 17 00:00:00 2001 From: Jason Rudolph Date: Mon, 9 Apr 2018 08:58:34 -0400 Subject: [PATCH 04/10] Fix markdown formatting --- docs/focus/2018-04-02.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/focus/2018-04-02.md b/docs/focus/2018-04-02.md index 286a4f67e..9c42c3f6b 100644 --- a/docs/focus/2018-04-02.md +++ b/docs/focus/2018-04-02.md @@ -1,8 +1,8 @@ ## Highlights from the past week - Atom IDE - - Reviewing and merging PR's, investigating issues and general housekeeping - - Attempting to modify the language-csharp grammar for use on github.com (oniguruma vs pcre engines) + - Reviewing and merging PR's, investigating issues and general housekeeping + - Attempting to modify the language-csharp grammar for use on github.com (oniguruma vs pcre engines) - GitHub Package - Implement actions for most recent commit - undo and amend [atom/github#1364](https://github.com/atom/github/pull/1364) - Improved push/pull UX [atom/github#1308](https://github.com/atom/github/pull/1308) @@ -10,8 +10,8 @@ - Published [Teletype 0.11.0](https://github.com/atom/teletype/releases/tag/v.0.11.0) with support for [sharing and joining a portal via URL](https://blog.atom.io/2018/03/29/new-in-teletype-faster-setup-and-improved-multi-file-support.html#joining-a-portal-is-as-easy-as-clicking-a-link) - Updated RFC for streamlining collaboration set-up to incorporate feedback, and opened it up for another round of comments ([atom/teletype#344](https://github.com/atom/teletype/pull/344)) - Xray - - [A PR with an initial implementation of a file finder UI](https://github.com/atom/xray/pull/55) is nearly complete. - - See the [in-depth Xray update for this week](https://github.com/atom/xray/blob/master/docs/updates/2018_04_02.md) for details. + - [A PR with an initial implementation of a file finder UI](https://github.com/atom/xray/pull/55) is nearly complete. + - See the [in-depth Xray update for this week](https://github.com/atom/xray/blob/master/docs/updates/2018_04_02.md) for details. - Reactor Duty - `TextEditor.scan` methods with zero-length matches at line endings skip the next line: [#16983](https://github.com/atom/atom/issues/16983), fixed by [atom/superstring#53](https://github.com/atom/superstring/pull/53) - Prevent modifications to readonly editors: [#16736](https://github.com/atom/atom/issues/16736), fixed by [#16999](https://github.com/atom/atom/pull/16999) and (thanks @maxbrunsfeld) [#17050](https://github.com/atom/atom/pull/17050) @@ -37,6 +37,6 @@ - Fix error recovery performance bug discovered in Atom last week - Working on the C# grammar (@damieng) - Xray - - Merge the [file finder PR](https://github.com/atom/xray/pull/55). - - Start on headless shared workspaces. - - See the [in-depth Xray update for this week](https://github.com/atom/xray/blob/master/docs/updates/2018_04_02.md) for details. + - Merge the [file finder PR](https://github.com/atom/xray/pull/55). + - Start on headless shared workspaces. + - See the [in-depth Xray update for this week](https://github.com/atom/xray/blob/master/docs/updates/2018_04_02.md) for details. From df0689f8c5736bf7172745ccd80a7b12740704a9 Mon Sep 17 00:00:00 2001 From: Jason Rudolph Date: Mon, 9 Apr 2018 10:30:16 -0400 Subject: [PATCH 05/10] Fix link --- docs/focus/2018-04-02.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/focus/2018-04-02.md b/docs/focus/2018-04-02.md index 9c42c3f6b..30dac225d 100644 --- a/docs/focus/2018-04-02.md +++ b/docs/focus/2018-04-02.md @@ -7,7 +7,7 @@ - Implement actions for most recent commit - undo and amend [atom/github#1364](https://github.com/atom/github/pull/1364) - Improved push/pull UX [atom/github#1308](https://github.com/atom/github/pull/1308) - Teletype - - Published [Teletype 0.11.0](https://github.com/atom/teletype/releases/tag/v.0.11.0) with support for [sharing and joining a portal via URL](https://blog.atom.io/2018/03/29/new-in-teletype-faster-setup-and-improved-multi-file-support.html#joining-a-portal-is-as-easy-as-clicking-a-link) + - Published [Teletype 0.11.0](https://github.com/atom/teletype/releases/tag/v0.11.0) with support for [sharing and joining a portal via URL](https://blog.atom.io/2018/03/29/new-in-teletype-faster-setup-and-improved-multi-file-support.html#joining-a-portal-is-as-easy-as-clicking-a-link) - Updated RFC for streamlining collaboration set-up to incorporate feedback, and opened it up for another round of comments ([atom/teletype#344](https://github.com/atom/teletype/pull/344)) - Xray - [A PR with an initial implementation of a file finder UI](https://github.com/atom/xray/pull/55) is nearly complete. From 1cb3a0ed60fe282e55dca12b7bb2646d6f502ca4 Mon Sep 17 00:00:00 2001 From: Jason Rudolph Date: Mon, 9 Apr 2018 11:51:35 -0400 Subject: [PATCH 06/10] Add Teletype highlights from the past week --- docs/focus/2018-04-09.md | 4 +++- docs/focus/README.md | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index 4164baf22..a157b108e 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -7,6 +7,9 @@ - Started implementing [atom/github/#1374 "Add dialog for new co-author"](https://github.com/atom/github/pull/1374). This includes UI polish and some bugfixes for existing co author flows. @kuychaco / @annthurium - Merged [atom/github#1364 "Undo last commit and amend context menu option"](https://github.com/atom/github/pull/1364) @kuychaco / @annthurium - Teletype + - Enhanced file metadata syncing to update guest workspaces when host renames a shared file ([atom/teletype#147](https://github.com/atom/teletype/issues/147#issuecomment-378401644)). Thanks, [@CaptainJohnyAppleSeed](https://github.com/CaptainJohnyAppleSeed) and [@odoyle71](https://github.com/odoyle71)! + - Improved handling (hopefully 🤞) of potential race condition when joining a portal with poor network connectivity ([atom/teletype-client#58](https://github.com/atom/teletype-client/pull/58)) + - Published [Teletype 0.12.0](https://github.com/atom/teletype/releases/tag/v0.12.0) with the above improvements - Xray - Reactor Duty @@ -17,6 +20,5 @@ - Get "Add dialog for new co-author" [atom/github#1374](https://github.com/atom/github/pull/1374) merged. @annthurium / @kuychaco - Start implementing code coverage to get better visibility into our unit test coverage gaps. @annthurium - Revive the React 16 and Enzyme port started in [atom/github#1174](https://github.com/atom/github/pull/1174). @smashwilson -- Teletype - Tree-sitter - Xray diff --git a/docs/focus/README.md b/docs/focus/README.md index 3062a0b91..7cc4bdb26 100644 --- a/docs/focus/README.md +++ b/docs/focus/README.md @@ -122,7 +122,7 @@ Longer-term goal: Provide the world's fastest transition from "I want to collabo ##### 4. Prioritized bugs -- [ ] Uncaught TypeError: Cannot match against 'undefined' or 'null' (https://github.com/atom/teletype/issues/233) +- [x] Uncaught TypeError: Cannot match against 'undefined' or 'null' (https://github.com/atom/teletype/issues/233) ## Looking farther ahead From 4c42635fd0d6f56a65380a7108cc8af900f3f831 Mon Sep 17 00:00:00 2001 From: Jason Rudolph Date: Mon, 9 Apr 2018 11:53:33 -0400 Subject: [PATCH 07/10] Add reactor duty highlights from the past week --- docs/focus/2018-04-09.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index a157b108e..f25286c6b 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -12,6 +12,8 @@ - Published [Teletype 0.12.0](https://github.com/atom/teletype/releases/tag/v0.12.0) with the above improvements - Xray - Reactor Duty + - Fixed an issue that sometimes prevented the fuzzy-finder from showing local files when Teletype is installed ([atom/fuzzy-finder#343](https://github.com/atom/fuzzy-finder/issues/343)) + - Shipped [Atom 1.25.1](https://github.com/atom/atom/releases/tag/v1.25.1) and [1.26.0-beta1](https://github.com/atom/atom/releases/tag/v1.26.0-beta1) ## Focus for week ahead From 7a232a23e3e09b70bccb9d80b40cddf1722dee1f Mon Sep 17 00:00:00 2001 From: David Wilson Date: Mon, 9 Apr 2018 09:07:24 -0700 Subject: [PATCH 08/10] Add @daviwil focus for the week --- docs/focus/2018-04-09.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index f25286c6b..acafcd00f 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -17,6 +17,9 @@ ## Focus for week ahead +- Atom + - Add UI for managing .atomproject.json files + - Continue work on project root configuration files - GitHub Package - Get "Create pull request" [atom/github#1376](https://github.com/atom/github/pull/1376) merged. @smashwilson - Get "Add dialog for new co-author" [atom/github#1374](https://github.com/atom/github/pull/1374) merged. @annthurium / @kuychaco From 2b5855759fa7d46f7e3d441609ad133db22d380c Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Mon, 9 Apr 2018 09:51:54 -0700 Subject: [PATCH 09/10] Add Max's focus --- docs/focus/2018-04-02.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/focus/2018-04-02.md b/docs/focus/2018-04-02.md index 30dac225d..3a65a5b79 100644 --- a/docs/focus/2018-04-02.md +++ b/docs/focus/2018-04-02.md @@ -9,6 +9,8 @@ - Teletype - Published [Teletype 0.11.0](https://github.com/atom/teletype/releases/tag/v0.11.0) with support for [sharing and joining a portal via URL](https://blog.atom.io/2018/03/29/new-in-teletype-faster-setup-and-improved-multi-file-support.html#joining-a-portal-is-as-easy-as-clicking-a-link) - Updated RFC for streamlining collaboration set-up to incorporate feedback, and opened it up for another round of comments ([atom/teletype#344](https://github.com/atom/teletype/pull/344)) +- Tree-sitter + - Started work on fixing an error recovery hang I discovered in Atom last week: https://github.com/tree-sitter/tree-sitter/pull/155. - Xray - [A PR with an initial implementation of a file finder UI](https://github.com/atom/xray/pull/55) is nearly complete. - See the [in-depth Xray update for this week](https://github.com/atom/xray/blob/master/docs/updates/2018_04_02.md) for details. @@ -34,7 +36,7 @@ - Publish patch release with [potential fix](https://github.com/atom/teletype-client/pull/58) for [atom/teletype#233](https://github.com/atom/teletype/issues/233) - Incorporate any new feedback and finalize RFC for streamlining collaboration set-up ([atom/teletype#344](https://github.com/atom/teletype/pull/344)) - Tree-sitter - - Fix error recovery performance bug discovered in Atom last week + - Finish https://github.com/tree-sitter/tree-sitter/pull/155 - Working on the C# grammar (@damieng) - Xray - Merge the [file finder PR](https://github.com/atom/xray/pull/55). From 640dc6e3226645414d44ad7ec377884aa21765e2 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Mon, 9 Apr 2018 14:01:32 -0600 Subject: [PATCH 10/10] Add Xray things --- docs/focus/2018-04-09.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/focus/2018-04-09.md b/docs/focus/2018-04-09.md index acafcd00f..2309bc6d1 100644 --- a/docs/focus/2018-04-09.md +++ b/docs/focus/2018-04-09.md @@ -11,6 +11,8 @@ - Improved handling (hopefully 🤞) of potential race condition when joining a portal with poor network connectivity ([atom/teletype-client#58](https://github.com/atom/teletype-client/pull/58)) - Published [Teletype 0.12.0](https://github.com/atom/teletype/releases/tag/v0.12.0) with the above improvements - Xray + - Started on support for shared remote workspaces by developing an RPC system for use between Xray peers. + - See [this week's in-depth update](https://github.com/atom/xray/blob/master/docs/updates/2018_04_09.md) for details. - Reactor Duty - Fixed an issue that sometimes prevented the fuzzy-finder from showing local files when Teletype is installed ([atom/fuzzy-finder#343](https://github.com/atom/fuzzy-finder/issues/343)) - Shipped [Atom 1.25.1](https://github.com/atom/atom/releases/tag/v1.25.1) and [1.26.0-beta1](https://github.com/atom/atom/releases/tag/v1.26.0-beta1) @@ -27,3 +29,4 @@ - Revive the React 16 and Enzyme port started in [atom/github#1174](https://github.com/atom/github/pull/1174). @smashwilson - Tree-sitter - Xray + - Merge [initial implementation of shared workspaces](https://github.com/atom/xray/pull/61).