From 9f0f4c05305e61e7d8a74309eec470d60fd649b5 Mon Sep 17 00:00:00 2001 From: Luke Pommersheim Date: Fri, 12 Jun 2015 08:38:25 +0200 Subject: [PATCH] refactor getCursorAtScreenPosition to avoid temporary array --- src/text-editor.coffee | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/text-editor.coffee b/src/text-editor.coffee index 7a31ffad6..64cbe513c 100644 --- a/src/text-editor.coffee +++ b/src/text-editor.coffee @@ -1567,10 +1567,9 @@ class TextEditor extends Model # # Returns the first matched {Cursor} or undefined getCursorAtScreenPosition: (position) -> - cursorsAtPoint = @cursors.filter (cursor) -> - cursorPosition = cursor.getScreenPosition() - cursorPosition.row is position.row and cursorPosition.column is position.column - if cursorsAtPoint.length > 0 then cursorsAtPoint[0] else undefined + for cursor in @cursors + return cursor if cursor.getScreenPosition().isEqual(position) + undefined # Essential: Get the position of the most recently added cursor in screen # coordinates.