From a6efa104dbef90a0b199ff77200de24d1c919fbd Mon Sep 17 00:00:00 2001 From: Jess Lin Date: Mon, 30 Mar 2015 14:49:35 -0700 Subject: [PATCH] [Gutter] Don't allow the 'line-number' gutter to be destroyed --- spec/gutter-spec.coffee | 4 ++++ src/gutter.coffee | 9 ++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/spec/gutter-spec.coffee b/spec/gutter-spec.coffee index 80b919423..ba6933a05 100644 --- a/spec/gutter-spec.coffee +++ b/spec/gutter-spec.coffee @@ -62,3 +62,7 @@ describe 'Gutter', -> didDestroy = true gutter.destroy() expect(didDestroy).toBe true + + it 'does not allow destroying the line-number gutter', -> + gutter = new Gutter mockGutterContainer, {name: 'line-number'} + expect(gutter.destroy).toThrow() diff --git a/src/gutter.coffee b/src/gutter.coffee index bd50b4157..9e002674b 100644 --- a/src/gutter.coffee +++ b/src/gutter.coffee @@ -23,9 +23,12 @@ class Gutter @emitter = new Emitter destroy: -> - @gutterContainer.removeGutter(this) - @emitter.emit 'did-destroy' - @emitter.dispose() + if @name is 'line-number' + throw new Error('The line-number gutter cannot be destroyed.') + else + @gutterContainer.removeGutter(this) + @emitter.emit 'did-destroy' + @emitter.dispose() hide: -> if @visible