From a8076199067fa6af31489a39ae5a45a9241fad38 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Fri, 3 Oct 2014 15:01:23 -0700 Subject: [PATCH] Only call show on active item when attached Closes atom/settings-view#258 --- src/pane-element.coffee | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pane-element.coffee b/src/pane-element.coffee index 1050982c7..cdb7b32ca 100644 --- a/src/pane-element.coffee +++ b/src/pane-element.coffee @@ -4,14 +4,19 @@ PaneView = require './pane-view' class PaneElement extends HTMLElement createdCallback: -> + @attached = false @subscriptions = new CompositeDisposable @initializeContent() @subscribeToDOMEvents() @createSpacePenShim() attachedCallback: -> + @attached = true @focus() if @model.isFocused() + detachedCallback: -> + @attached = false + initializeContent: -> @setAttribute 'class', 'pane' @setAttribute 'tabindex', -1 @@ -52,7 +57,7 @@ class PaneElement extends HTMLElement view = @model.getView(item).__spacePenView otherView.hide() for otherView in $itemViews.children().not(view).views() $itemViews.append(view) unless view.parent().is($itemViews) - view.show() + view.show() if @attached view.focus() if @hasFocus() itemRemoved: ({item, index, destroyed}) ->