From a8533c10105fdb960b9f58ccf46eec4ae709a112 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 11 Jun 2014 13:22:34 -0700 Subject: [PATCH] Fail build if any specs fail on Windows --- build/tasks/spec-task.coffee | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/build/tasks/spec-task.coffee b/build/tasks/spec-task.coffee index 13ef31852..be9480656 100644 --- a/build/tasks/spec-task.coffee +++ b/build/tasks/spec-task.coffee @@ -104,9 +104,4 @@ module.exports = (grunt) -> failures.push "atom core" if coreSpecFailed grunt.log.error("[Error]".red + " #{failures.join(', ')} spec(s) failed") if failures.length > 0 - - # TODO: Mark the build as green on Windows until specs pass. - if process.platform is 'darwin' - done(!coreSpecFailed and failedPackages.length == 0) - else if process.platform is 'win32' - done(true) + done(!coreSpecFailed and failedPackages.length == 0)