From adc086d4859ed63ef031bb25caa2ec19bdfe69a8 Mon Sep 17 00:00:00 2001
From: Katrina Uychaco <kuychaco@github.com>
Date: Thu, 18 Feb 2016 23:41:23 -0800
Subject: [PATCH] Add specs for Update methods (::check left TODO)

---
 spec/update-spec.js | 102 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 93 insertions(+), 9 deletions(-)

diff --git a/spec/update-spec.js b/spec/update-spec.js
index 4d66da666..0f2f66289 100644
--- a/spec/update-spec.js
+++ b/spec/update-spec.js
@@ -2,36 +2,120 @@
 
 import Update from '../src/update'
 import remote from 'remote'
+import ipc from 'ipc'
 
 fdescribe('Update', () => {
+  let update
+
+  afterEach(() => {
+    update.dispose()
+  })
+
   describe('::initialize', () => {
     it('subscribes to appropriate applicationDelegate events', () => {
-      const update = new Update()
-      update.initialize()
+      update = new Update()
 
       const downloadingSpy = jasmine.createSpy('downloadingSpy')
       const checkingSpy = jasmine.createSpy('checkingSpy')
       const noUpdateSpy = jasmine.createSpy('noUpdateSpy')
+      const completedDownloadSpy = jasmine.createSpy('completedDownloadSpy')
 
-      update.onDidBeginCheckingForUpdate(checkingSpy)
-      update.onDidBeginDownload(downloadingSpy)
-      update.onUpdateNotAvailable(noUpdateSpy)
+      update.emitter.on('did-begin-checking-for-update', checkingSpy)
+      update.emitter.on('did-begin-downloading-update', downloadingSpy)
+      update.emitter.on('did-complete-downloading-update', completedDownloadSpy)
+      update.emitter.on('update-not-available', noUpdateSpy)
+
+      update.initialize()
 
-      // This doesn't work
       const webContents = remote.getCurrentWebContents()
-      webContents.send('message', 'update-available', {releaseVersion: '1.2.3'})
-      webContents.send('message', 'did-begin-downloading-update')
       webContents.send('message', 'checking-for-update')
+      webContents.send('message', 'did-begin-downloading-update')
+      webContents.send('message', 'update-available', {releaseVersion: '1.2.3'})
       webContents.send('message', 'update-not-available')
 
       waitsFor(() => {
-        noUpdateSpy.callCount > 0
+        return noUpdateSpy.callCount > 0
       })
+
       runs(() => {
         expect(downloadingSpy.callCount).toBe(1)
         expect(checkingSpy.callCount).toBe(1)
         expect(noUpdateSpy.callCount).toBe(1)
+        expect(completedDownloadSpy.callCount).toBe(1)
       })
     })
   })
+
+  beforeEach(() => {
+    update = new Update()
+    update.initialize()
+  })
+
+  describe('::onDidBeginCheckingForUpdate', () => {
+    it('subscribes to "did-begin-checking-for-update" event', () => {
+      const spy = jasmine.createSpy('spy')
+      update.onDidBeginCheckingForUpdate(spy)
+      update.emitter.emit('did-begin-checking-for-update')
+      expect(spy.callCount).toBe(1)
+    })
+  })
+
+  describe('::onDidBeginDownload', () => {
+    it('subscribes to "did-begin-downloading-update" event', () => {
+      const spy = jasmine.createSpy('spy')
+      update.onDidBeginDownload(spy)
+      update.emitter.emit('did-begin-downloading-update')
+      expect(spy.callCount).toBe(1)
+    })
+  })
+
+  describe('::onDidCompleteDownload', () => {
+    it('subscribes to "did-complete-downloading-update" event', () => {
+      const spy = jasmine.createSpy('spy')
+      update.onDidCompleteDownload(spy)
+      update.emitter.emit('did-complete-downloading-update')
+      expect(spy.callCount).toBe(1)
+    })
+  })
+
+  describe('::onUpdateNotAvailable', () => {
+    it('subscribes to "update-not-available" event', () => {
+      const spy = jasmine.createSpy('spy')
+      update.onUpdateNotAvailable(spy)
+      update.emitter.emit('update-not-available')
+      expect(spy.callCount).toBe(1)
+    })
+  })
+
+  describe('::onUpdateAvailable', () => {
+    it('subscribes to "update-available" event', () => {
+      const spy = jasmine.createSpy('spy')
+      update.onUpdateAvailable(spy)
+      update.emitter.emit('update-available')
+      expect(spy.callCount).toBe(1)
+    })
+  })
+
+  // TODO: spec is timing out. spy is not called
+  // describe('::check', () => {
+  //   it('sends "check-for-update" event', () => {
+  //     const spy = jasmine.createSpy('spy')
+  //     ipc.on('check-for-update', () => {
+  //       spy()
+  //     })
+  //     update.check()
+  //     waitsFor(() => {
+  //       return spy.callCount > 0
+  //     })
+  //   })
+  // })
+
+  describe('::dispose', () => {
+    it('disposes of subscriptions', () => {
+      expect(update.subscriptions.disposables).not.toBeNull()
+      update.dispose()
+      expect(update.subscriptions.disposables).toBeNull()
+    })
+  })
+
 })