From b667ba4262ed51eaa862e02c3fa8927416420aa3 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Mon, 4 Jun 2012 11:50:48 -0600 Subject: [PATCH] If selection is empty when toggling a line comment, keep it empty --- spec/app/selection-spec.coffee | 7 +++++++ src/app/renderer.coffee | 1 - src/app/selection.coffee | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/spec/app/selection-spec.coffee b/spec/app/selection-spec.coffee index b8932f464..402844db4 100644 --- a/spec/app/selection-spec.coffee +++ b/spec/app/selection-spec.coffee @@ -292,6 +292,13 @@ describe "Selection", -> expect(buffer.lineForRow(6)).toBe " current < pivot ? left.push(current) : right.push(current);" expect(buffer.lineForRow(7)).toBe " }" + it "preserves selection emptiness", -> + editor.attachToDom() + selection.setBufferRange([[4, 0], [4, 0]]) + selection.toggleLineComments() + expect(selection.isEmpty()).toBeTruthy() + expect(selection.find('.selection')).not.toExist() + describe "when the selection ends on the begining of a fold line", -> beforeEach -> editor.createFold(2,4) diff --git a/src/app/renderer.coffee b/src/app/renderer.coffee index f23f17a88..0e75c7bdc 100644 --- a/src/app/renderer.coffee +++ b/src/app/renderer.coffee @@ -248,7 +248,6 @@ class Renderer @lineMap.logLines(start, end) toggleLineCommentsInRange: (range) -> - console.log range.inspect() @lineCommenter.toggleLineCommentsInRange(range) _.extend Renderer.prototype, EventEmitter diff --git a/src/app/selection.coffee b/src/app/selection.coffee index f460fe24b..a06fa2896 100644 --- a/src/app/selection.coffee +++ b/src/app/selection.coffee @@ -20,6 +20,7 @@ class Selection extends View handleBufferChange: (e) -> return unless @anchor @anchor.handleBufferChange(e) + @updateAppearance() placeAnchor: -> return if @anchor