github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-05 04:05:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make each section of presenter state self-contained

Browse Source 
This means we have some duplicated values in different parts of the
tree, but it’s cleaner in the view since each component only consumes
a single object. Seems like the presenter should convey the correct
data to the correct locations and minimize the logic in the view. A
few duplicated integers is a reasonable trade-off.
This commit is contained in:
Nathan Sobo
2015-01-29 14:27:53 -07:00
parent da4b3a47ef
commit bbc1a264b5
7 changed files with 238 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/scrollbar-component.coffee
View File

@@ -11,29 +11,29 @@ ScrollbarComponent = React.createClass
switch orientation
when 'vertical'
state = presenter.state.verticalScrollbar
@newState = presenter.state.verticalScrollbar
when 'horizontal'
state = presenter.state.horizontalScrollbar
@newState = presenter.state.horizontalScrollbar
style = {}
style.display = 'none' unless state.visible
style.display = 'none' unless @newState.visible
style.transform = 'translateZ(0)' if useHardwareAcceleration # See atom/atom#3559
switch orientation
when 'vertical'
style.width = state.width
style.bottom = state.bottom
style.width = @newState.width
style.bottom = @newState.bottom
when 'horizontal'
style.left = 0
style.right = state.right
style.height = state.height
style.right = @newState.right
style.height = @newState.height
div {className, style},
switch orientation
when 'vertical'
div className: 'scrollbar-content', style: {height: presenter.state.scrollHeight}
div className: 'scrollbar-content', style: {height: @newState.scrollHeight}
when 'horizontal'
div className: 'scrollbar-content', style: {width: presenter.state.content.scrollWidth}
div className: 'scrollbar-content', style: {width: @newState.scrollWidth}
componentDidMount: ->
{orientation} = @props
@@ -47,14 +47,14 @@ ScrollbarComponent = React.createClass
@getDOMNode().removeEventListener 'scroll', @onScroll
componentDidUpdate: ->
{orientation, presenter} = @props
{orientation} = @props
node = @getDOMNode()
switch orientation
when 'vertical'
node.scrollTop = presenter.state.scrollTop
node.scrollTop = @newState.scrollTop
when 'horizontal'
node.scrollLeft = presenter.state.content.scrollLeft
node.scrollLeft = @newState.scrollLeft
onScroll: ->
{orientation, onScroll} = @props