From 66ce0019614e22bcbfb0dccd725bb3a4cab3d700 Mon Sep 17 00:00:00 2001 From: Desmond Brand Date: Sun, 10 Aug 2014 21:41:55 -0700 Subject: [PATCH 1/3] Move coffeelint settings to external file The motivation is for this is to allow `coffeelint` config to be shared by `script/grunt coffeelint`, global `coffeelint` and inline linting via `AtomLinter`. Test Plan: Made some deliberate lint errors then ran `script/grunt coffeelint` and verified the output looked the same with and without this change. --- build/Gruntfile.coffee | 7 +------ coffeelint.json | 11 +++++++++++ 2 files changed, 12 insertions(+), 6 deletions(-) create mode 100644 coffeelint.json diff --git a/build/Gruntfile.coffee b/build/Gruntfile.coffee index fed064c76..6b1dae4a8 100644 --- a/build/Gruntfile.coffee +++ b/build/Gruntfile.coffee @@ -144,12 +144,7 @@ module.exports = (grunt) -> coffeelint: options: - no_empty_param_list: - level: 'error' - max_line_length: - level: 'ignore' - indentation: - level: 'ignore' + configFile: 'coffeelint.json' src: [ 'dot-atom/**/*.coffee' 'exports/**/*.coffee' diff --git a/coffeelint.json b/coffeelint.json new file mode 100644 index 000000000..b3bed36b7 --- /dev/null +++ b/coffeelint.json @@ -0,0 +1,11 @@ +{ + "indentation": { + "level": "ignore" + }, + "max_line_length": { + "level": "ignore" + }, + "no_empty_param_list": { + "level": "error" + } +} From 1201fb6a5d84a447531953fd5e1c5c80506df7b2 Mon Sep 17 00:00:00 2001 From: Desmond Brand Date: Mon, 11 Aug 2014 16:32:13 -0700 Subject: [PATCH 2/3] ignore no_unnecessary_fat_arrows too --- coffeelint.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/coffeelint.json b/coffeelint.json index b3bed36b7..360168898 100644 --- a/coffeelint.json +++ b/coffeelint.json @@ -7,5 +7,8 @@ }, "no_empty_param_list": { "level": "error" + }, + "no_unnecessary_fat_arrows": { + "level": "ignore" } } From 61daf1cc367b8caf0cdea162a3f89ba905edd2d3 Mon Sep 17 00:00:00 2001 From: Desmond Brand Date: Mon, 11 Aug 2014 16:38:24 -0700 Subject: [PATCH 3/3] Use grunt-coffeelint@0.0.13 instead of forked version Test Plan: ``` $ ./script/grunt coffeelint Running "coffeelint:src" (coffeelint) task >> 80 files lint free. Running "coffeelint:build" (coffeelint) task >> 23 files lint free. Running "coffeelint:test" (coffeelint) task >> 40 files lint free. Done, without errors. ``` --- build/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/package.json b/build/package.json index 60ba05514..e143f9bbd 100644 --- a/build/package.json +++ b/build/package.json @@ -13,7 +13,7 @@ "github-releases": "~0.2.0", "grunt": "~0.4.1", "grunt-cli": "~0.1.9", - "grunt-coffeelint": "git+https://github.com/atom/grunt-coffeelint.git", + "grunt-coffeelint": "0.0.13", "grunt-contrib-coffee": "~0.9.0", "grunt-contrib-csslint": "~0.1.2", "grunt-contrib-less": "~0.8.0",