diff --git a/spec/text-editor-component-spec.js b/spec/text-editor-component-spec.js index 2028ae8bd..7a4608872 100644 --- a/spec/text-editor-component-spec.js +++ b/spec/text-editor-component-spec.js @@ -1762,13 +1762,13 @@ describe('TextEditorComponent', () => { expect(decorationNode3.firstChild).toBe(decorationElement2) decoration1.setProperties({type: 'gutter', gutterName: 'a', class: 'c', item: decorationElement1}) - decoration2.setProperties({type: 'gutter', gutterName: 'a', item: decorationElement2}) + decoration2.setProperties({type: 'gutter', gutterName: 'a'}) decoration3.destroy() await component.getNextUpdatePromise() expect(decorationNode1.className).toBe('decoration c') expect(decorationNode1.firstChild).toBe(decorationElement1) expect(decorationNode2.className).toBe('decoration') - expect(decorationNode2.firstChild).toBe(decorationElement2) + expect(decorationNode2.firstChild).toBeNull() expect(gutterB.getElement().firstChild.children.length).toBe(0) }) }) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index a93cbabba..a3a51a3aa 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -3275,7 +3275,7 @@ class CustomGutterDecorationComponent { if (newProps.className !== oldProps.className) this.element.className = newProps.className || '' if (newProps.element !== oldProps.element) { if (this.element.firstChild) this.element.firstChild.remove() - this.element.appendChild(newProps.element) + if (newProps.element != null) this.element.appendChild(newProps.element) } } }