From c76fc5af2d47d1ccfe682f7d3bb8cf8c18a52e80 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Mon, 17 Apr 2017 13:58:38 -0600 Subject: [PATCH] Round column measurements to nearest whole pixel This preserves the expected behavior for positioning overlays, etc so that package tests keep passing. --- src/text-editor-component.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index d1327a09e..0385b3253 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -1945,7 +1945,7 @@ class TextEditorComponent { clientPixelPosition = clientRectForRange(textNode, 0, nextColumnToMeasure - textNodeStartColumn).right } if (lineNodeClientLeft === -1) lineNodeClientLeft = lineNode.getBoundingClientRect().left - positions.set(nextColumnToMeasure, clientPixelPosition - lineNodeClientLeft) + positions.set(nextColumnToMeasure, Math.round(clientPixelPosition - lineNodeClientLeft)) continue columnLoop // eslint-disable-line no-labels } else { textNodesIndex++