github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't update top positions of lines/lineNodes unless they have changed

Browse Source
This commit is contained in:
Nathan Sobo
2014-05-14 19:58:50 -06:00
parent 89bd241a78
commit c87bc57f9e
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/lines-component.coffee
View File

@@ -27,6 +27,7 @@ LinesComponent = React.createClass
componentWillMount: ->
@measuredLines = new WeakSet
@lineNodesByLineId = {}
@lineNodeTopPositions = {}
componentDidMount: ->
@measureLineHeightAndCharWidth()
@@ -63,6 +64,7 @@ LinesComponent = React.createClass
node = @getDOMNode()
for lineId, lineNode of @lineNodesByLineId when not visibleLineIds.has(lineId)
delete @lineNodesByLineId[lineId]
delete @lineNodeTopPositions[lineId]
node.removeChild(lineNode)
appendOrUpdateVisibleLineNodes: (visibleLines, startRow) ->
@@ -81,6 +83,7 @@ LinesComponent = React.createClass
newLinesHTML ?= ""
newLines.push(line)
newLinesHTML += @buildLineHTML(line, top)
@lineNodeTopPositions[line.id] = top
return unless newLines?
@@ -152,9 +155,11 @@ LinesComponent = React.createClass
scopeStack.push(scope)
"<span class=\"#{scope.replace(/\.+/g, ' ')}\">"
updateLineNode: (tokenizedLine, top) ->
lineNode = @lineNodesByLineId[tokenizedLine.id]
lineNode.style.top = top + 'px'
updateLineNode: (line, top) ->
unless @lineNodeTopPositions[line.id] is top
lineNode = @lineNodesByLineId[line.id]
lineNode.style.top = top + 'px'
@lineNodeTopPositions[line.id] = top
measureLineHeightAndCharWidth: ->
node = @getDOMNode()