From c9b558a08a41a8858861828c2ba518a783da3055 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 15 Aug 2017 15:38:04 -0600 Subject: [PATCH] Move placeholder text inside .lines div If themes apply padding to the .lines div, the placeholder text looks mis-aligned unless it is placed within the .lines div --- src/text-editor-component.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index 93c69959c..cfdb3d489 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -551,8 +551,7 @@ class TextEditorComponent { children = [ this.renderLineTiles(), this.renderBlockDecorationMeasurementArea(), - this.renderCharacterMeasurementLine(), - this.renderPlaceholderText() + this.renderCharacterMeasurementLine() ] } else { children = [ @@ -633,6 +632,7 @@ class TextEditorComponent { style.height = this.getScrollHeight() + 'px' } + children.push(this.renderPlaceholderText()) children.push(this.renderCursorsAndInput()) return $.div(