mirror of
https://github.com/atom/atom.git
synced 2026-04-06 03:02:13 -04:00
Open docks when activating their panes, but not when adding items
This commit is contained in:
@@ -48,9 +48,7 @@ module.exports = class Dock {
|
||||
}
|
||||
|
||||
this.subscriptions = new CompositeDisposable(
|
||||
this.paneContainer.observePanes(pane => {
|
||||
pane.onDidAddItem(this.handleDidAddPaneItem.bind(this))
|
||||
}),
|
||||
this.paneContainer.onDidActivatePane(() => this.activate()),
|
||||
this.paneContainer.observePanes(pane => {
|
||||
pane.onDidRemoveItem(this.handleDidRemovePaneItem.bind(this))
|
||||
})
|
||||
@@ -201,11 +199,6 @@ module.exports = class Dock {
|
||||
})
|
||||
}
|
||||
|
||||
handleDidAddPaneItem () {
|
||||
// Show the dock if you drop an item into it.
|
||||
this.setState({open: true})
|
||||
}
|
||||
|
||||
handleDidRemovePaneItem () {
|
||||
// Hide the dock if you remove the last item.
|
||||
if (this.paneContainer.getPaneItems().length === 0) {
|
||||
|
||||
@@ -68,6 +68,9 @@ class PaneContainer extends Model
|
||||
onDidChangeActivePane: (fn) ->
|
||||
@emitter.on 'did-change-active-pane', fn
|
||||
|
||||
onDidActivatePane: (fn) ->
|
||||
@emitter.on 'did-activate-pane', fn
|
||||
|
||||
observeActivePane: (fn) ->
|
||||
fn(@getActivePane())
|
||||
@onDidChangeActivePane(fn)
|
||||
@@ -127,6 +130,7 @@ class PaneContainer extends Model
|
||||
|
||||
@activePane = activePane
|
||||
@emitter.emit 'did-change-active-pane', @activePane
|
||||
@emitter.emit 'did-activate-pane', @activePane
|
||||
@activePane
|
||||
|
||||
getActivePaneItem: ->
|
||||
|
||||
@@ -729,10 +729,6 @@ module.exports = class Workspace extends Model {
|
||||
|
||||
if (options.activatePane !== false) {
|
||||
pane.activate()
|
||||
if (!container) {
|
||||
container = this.getPaneContainers().find(container => container.getPanes().includes(pane))
|
||||
}
|
||||
container.activate()
|
||||
}
|
||||
|
||||
let initialColumn = 0
|
||||
|
||||
Reference in New Issue
Block a user