github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-09 22:24:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Avoid recursive call to moveToSuccessor, which is blowing the stack

Browse Source
This commit is contained in:
Nathan Sobo
2016-01-26 17:42:28 -07:00
parent 47338253db
commit d0e29bfc2c
2 changed files with 53 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
spec/tokenized-buffer-spec.coffee
View File

@@ -1113,3 +1113,30 @@ describe "TokenizedBuffer", ->
expect(iterator.seek(Point(2, 0))).toEqual(["source.js"])
iterator.moveToSuccessor() # ensure we don't infinitely loop (regression test)
it "does not report columns beyond the length of the line", ->
waitsForPromise ->
atom.packages.activatePackage('language-coffee-script')
runs ->
buffer = new TextBuffer(text: "# hello\n# world")
tokenizedBuffer = new TokenizedBuffer({
buffer, config: atom.config, grammarRegistry: atom.grammars, packageManager: atom.packages, assert: atom.assert
})
tokenizedBuffer.setGrammar(atom.grammars.selectGrammar(".coffee"))
fullyTokenize(tokenizedBuffer)
iterator = tokenizedBuffer.buildIterator()
iterator.seek(Point(0, 0))
iterator.moveToSuccessor()
iterator.moveToSuccessor()
expect(iterator.getPosition().column).toBe(7)
iterator.moveToSuccessor()
expect(iterator.getPosition().column).toBe(0)
iterator.seek(Point(0, 7))
expect(iterator.getPosition().column).toBe(7)
iterator.seek(Point(0, 8))
expect(iterator.getPosition().column).toBe(7)