From 52331786a2508057339a72b83b70cf2280271166 Mon Sep 17 00:00:00 2001 From: Lexis Alexander Date: Thu, 30 Aug 2018 14:11:33 -0700 Subject: [PATCH] Fix: Added capturing to keydown events when hiding tooltips --- spec/tooltip-manager-spec.js | 4 +++- src/tooltip-manager.js | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/spec/tooltip-manager-spec.js b/spec/tooltip-manager-spec.js index 0cf3c3e64..184f47bd3 100644 --- a/spec/tooltip-manager-spec.js +++ b/spec/tooltip-manager-spec.js @@ -218,7 +218,9 @@ describe('TooltipManager', () => { const disposable = manager.add(element, { title: 'Title' }) hover(element, function () { expect(document.body.querySelector('.tooltip')).not.toBeNull() - window.dispatchEvent(new CustomEvent('keydown')) + window.dispatchEvent(new CustomEvent('keydown', { + bubbles: true + })) expect(document.body.querySelector('.tooltip')).toBeNull() disposable.dispose() }) diff --git a/src/tooltip-manager.js b/src/tooltip-manager.js index 07b4f196a..9779e78fc 100644 --- a/src/tooltip-manager.js +++ b/src/tooltip-manager.js @@ -153,11 +153,11 @@ class TooltipManager { } window.addEventListener('resize', hideTooltip) - window.addEventListener('keydown', hideTooltip) + window.addEventListener('keydown', hideTooltip, { capture: true }) const disposable = new Disposable(() => { window.removeEventListener('resize', hideTooltip) - window.removeEventListener('keydown', hideTooltip) + window.removeEventListener('keydown', hideTooltip, { capture: true }) hideTooltip() tooltip.destroy()