From d93a1422634640b88332c71a2f400cbd41ac818a Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 3 Oct 2012 21:07:50 -0700 Subject: [PATCH] Rename alterSelection to editSelectedText --- spec/extensions/editor-command-spec.coffee | 26 +++++++++++----------- src/extensions/editor-command.coffee | 2 +- src/extensions/lowercase-command.coffee | 2 +- src/extensions/uppercase-command.coffee | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/spec/extensions/editor-command-spec.coffee b/spec/extensions/editor-command-spec.coffee index 9b1b9cf03..e6d8e4234 100644 --- a/spec/extensions/editor-command-spec.coffee +++ b/spec/extensions/editor-command-spec.coffee @@ -17,16 +17,16 @@ describe "EditorCommand", -> afterEach -> rootView.remove() - describe "@alterSelection()", -> + describe "@editSelectedText()", -> it "returns true when transformed text is non-empty", -> transformed = false - altered = false + edited = false class CustomCommand extends EditorCommand @getKeymaps: (editor) -> 'meta-V': 'custom' @execute: (editor, event) -> - altered = @alterSelection editor, (text) -> + edited = @editSelectedText editor, (text) -> transformed = true 'new' @@ -35,17 +35,17 @@ describe "EditorCommand", -> editor.selectToEndOfLine() editor.trigger 'custom' expect(transformed).toBe true - expect(altered).toBe true + expect(edited).toBe true it "returns false when transformed text is null", -> transformed = false - altered = false + edited = false class CustomCommand extends EditorCommand @getKeymaps: (editor) -> 'meta-V': 'custom' @execute: (editor, event) -> - altered = @alterSelection editor, (text) -> + edited = @editSelectedText editor, (text) -> transformed = true null @@ -54,17 +54,17 @@ describe "EditorCommand", -> editor.selectToEndOfLine() editor.trigger 'custom' expect(transformed).toBe true - expect(altered).toBe false + expect(edited).toBe false it "returns false when transformed text is undefined", -> transformed = false - altered = false + edited = false class CustomCommand extends EditorCommand @getKeymaps: (editor) -> 'meta-V': 'custom' @execute: (editor, event) -> - altered = @alterSelection editor, (text) -> + edited = @editSelectedText editor, (text) -> transformed = true undefined @@ -73,7 +73,7 @@ describe "EditorCommand", -> editor.selectToEndOfLine() editor.trigger 'custom' expect(transformed).toBe true - expect(altered).toBe false + expect(edited).toBe false describe "custom sub-class", -> it "removes vowels from selected text", -> @@ -82,7 +82,7 @@ describe "EditorCommand", -> 'meta-V': 'devowel' @execute: (editor, event) -> - @alterSelection editor, (text) -> + @editSelectedText editor, (text) -> text.replace(/[aeiouy]/gi, '') VowelRemover.activate(rootView) @@ -99,7 +99,7 @@ describe "EditorCommand", -> 'meta-V': 'custom' @execute: (editor, event) -> - @alterSelection editor, (text) -> + @editSelectedText editor, (text) -> callbackCount++ text @@ -120,7 +120,7 @@ describe "EditorCommand", -> 'meta-B': 'custom2' @execute: (editor, event) -> - @alterSelection editor, (text) -> + @editSelectedText editor, (text) -> callbackCount++ text diff --git a/src/extensions/editor-command.coffee b/src/extensions/editor-command.coffee index 100c9ded7..f3310b2ff 100644 --- a/src/extensions/editor-command.coffee +++ b/src/extensions/editor-command.coffee @@ -20,7 +20,7 @@ class EditorCommand for key, event of keymaps editor.on event, => @execute(editor, event) - @alterSelection: (editor, transform) -> + @editSelectedText: (editor, transform) -> selection = editor.getSelection() return false if selection.isEmpty() diff --git a/src/extensions/lowercase-command.coffee b/src/extensions/lowercase-command.coffee index 57ac1242d..51bc9654a 100644 --- a/src/extensions/lowercase-command.coffee +++ b/src/extensions/lowercase-command.coffee @@ -7,5 +7,5 @@ class LowerCaseCommand extends EditorCommand 'meta-Y': 'lowercase' @execute: (editor, event) -> - @alterSelection editor, (text) -> + @editSelectedText editor, (text) -> text.toLowerCase() diff --git a/src/extensions/uppercase-command.coffee b/src/extensions/uppercase-command.coffee index 5a63f87e8..2bc7e8e18 100644 --- a/src/extensions/uppercase-command.coffee +++ b/src/extensions/uppercase-command.coffee @@ -7,5 +7,5 @@ class UpperCaseCommand extends EditorCommand 'meta-X': 'uppercase' @execute: (editor, event) -> - @alterSelection editor, (text) -> + @editSelectedText editor, (text) -> text.toUpperCase()