github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Autoscroll the last cursor when it inserts text

Browse Source 
Normally, we don't autoscroll to a cursor when the buffer changes. But
this is a change caused by the cursor itself, so it makes sense to
keep it in view.
This commit is contained in:
Corey Johnson & Nathan Sobo
2013-02-14 13:21:31 -07:00
parent 1fed183a8c
commit da59459197
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/app/editor-spec.coffee
View File

@@ -1155,6 +1155,15 @@ describe "Editor", ->
editor.setCursorBufferPosition([4, 10])
expect(editor.scrollToPixelPosition).toHaveBeenCalled()
it "does not autoscroll the cursor based on a buffer change, unless the buffer change was initiated by the cursor", ->
lastVisibleRow = editor.getLastVisibleScreenRow()
editor.addCursorAtBufferPosition([lastVisibleRow, 0])
spyOn(editor, 'scrollToPixelPosition')
buffer.insert([lastVisibleRow, 0], "\n\n")
expect(editor.scrollToPixelPosition).not.toHaveBeenCalled()
editor.insertText('\n\n')
expect(editor.scrollToPixelPosition.callCount).toBe 1
describe "when the last cursor exceeds the upper or lower scroll margins", ->
describe "when the editor is taller than twice the vertical scroll margin", ->
it "sets the scrollTop so the cursor remains within the scroll margin", ->