mirror of
https://github.com/atom/atom.git
synced 2026-04-06 03:02:13 -04:00
Don't assign scrollLeft on model on 'scroll-left-changed' events
Fixes #2513 I'm not entirely sure why, but for some reason we're getting into an feedback cycle when the scrollLeft position changes in certain cases. In theory, this shouldn't happen because reassigning the same value shouldn't emit a change event. But since we're about to end-of-life the jQuery editor, I'd like to try fixing it this way for now.
This commit is contained in:
committed by
Ben Ogle & Nathan Sobo
parent
f623a4f2b5
commit
e26ab5513f
@@ -567,7 +567,7 @@ class EditorView extends View
|
||||
@scrollTop(scrollTop)
|
||||
|
||||
@subscribe @editor, 'scroll-left-changed', (scrollLeft) =>
|
||||
@scrollLeft(scrollLeft)
|
||||
@scrollView.scrollLeft(scrollLeft)
|
||||
|
||||
@subscribe @editor, 'soft-wrap-changed', (softWrap) =>
|
||||
@setSoftWrap(softWrap)
|
||||
|
||||
Reference in New Issue
Block a user