Remove blob store and native module cache

spec/file-system-blob-store-spec.coffee

@@ -1,108 +0,0 @@
-temp = require('temp').track()
-path = require 'path'
-fs = require 'fs-plus'
-FileSystemBlobStore = require '../src/file-system-blob-store'
-
-describe "FileSystemBlobStore", ->
-  [storageDirectory, blobStore] = []
-
-  beforeEach ->
-    storageDirectory = temp.path('atom-spec-filesystemblobstore')
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-  afterEach ->
-    fs.removeSync(storageDirectory)
-
-  it "is empty when the file doesn't exist", ->
-    expect(blobStore.get("foo", "invalidation-key-1")).toBeUndefined()
-    expect(blobStore.get("bar", "invalidation-key-2")).toBeUndefined()
-
-  it "allows to read and write buffers from/to memory without persisting them", ->
-    blobStore.set("foo", "invalidation-key-1", new Buffer("foo"))
-    blobStore.set("bar", "invalidation-key-2", new Buffer("bar"))
-
-    expect(blobStore.get("foo", "invalidation-key-1")).toEqual(new Buffer("foo"))
-    expect(blobStore.get("bar", "invalidation-key-2")).toEqual(new Buffer("bar"))
-
-    expect(blobStore.get("foo", "unexisting-key")).toBeUndefined()
-    expect(blobStore.get("bar", "unexisting-key")).toBeUndefined()
-
-  it "persists buffers when saved and retrieves them on load, giving priority to in-memory ones", ->
-    blobStore.set("foo", "invalidation-key-1", new Buffer("foo"))
-    blobStore.set("bar", "invalidation-key-2", new Buffer("bar"))
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    expect(blobStore.get("foo", "invalidation-key-1")).toEqual(new Buffer("foo"))
-    expect(blobStore.get("bar", "invalidation-key-2")).toEqual(new Buffer("bar"))
-    expect(blobStore.get("foo", "unexisting-key")).toBeUndefined()
-    expect(blobStore.get("bar", "unexisting-key")).toBeUndefined()
-
-    blobStore.set("foo", "new-key", new Buffer("changed"))
-
-    expect(blobStore.get("foo", "new-key")).toEqual(new Buffer("changed"))
-    expect(blobStore.get("foo", "invalidation-key-1")).toBeUndefined()
-
-  it "persists both in-memory and previously stored buffers when saved", ->
-    blobStore.set("foo", "invalidation-key-1", new Buffer("foo"))
-    blobStore.set("bar", "invalidation-key-2", new Buffer("bar"))
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-    blobStore.set("bar", "invalidation-key-3", new Buffer("changed"))
-    blobStore.set("qux", "invalidation-key-4", new Buffer("qux"))
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    expect(blobStore.get("foo", "invalidation-key-1")).toEqual(new Buffer("foo"))
-    expect(blobStore.get("bar", "invalidation-key-3")).toEqual(new Buffer("changed"))
-    expect(blobStore.get("qux", "invalidation-key-4")).toEqual(new Buffer("qux"))
-    expect(blobStore.get("foo", "unexisting-key")).toBeUndefined()
-    expect(blobStore.get("bar", "invalidation-key-2")).toBeUndefined()
-    expect(blobStore.get("qux", "unexisting-key")).toBeUndefined()
-
-  it "allows to delete keys from both memory and stored buffers", ->
-    blobStore.set("a", "invalidation-key-1", new Buffer("a"))
-    blobStore.set("b", "invalidation-key-2", new Buffer("b"))
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    blobStore.set("b", "invalidation-key-3", new Buffer("b"))
-    blobStore.set("c", "invalidation-key-4", new Buffer("c"))
-    blobStore.delete("b")
-    blobStore.delete("c")
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    expect(blobStore.get("a", "invalidation-key-1")).toEqual(new Buffer("a"))
-    expect(blobStore.get("b", "invalidation-key-2")).toBeUndefined()
-    expect(blobStore.get("b", "invalidation-key-3")).toBeUndefined()
-    expect(blobStore.get("c", "invalidation-key-4")).toBeUndefined()
-
-  it "ignores errors when loading an invalid blob store", ->
-    blobStore.set("a", "invalidation-key-1", new Buffer("a"))
-    blobStore.set("b", "invalidation-key-2", new Buffer("b"))
-    blobStore.save()
-
-    # Simulate corruption
-    fs.writeFileSync(path.join(storageDirectory, "MAP"), new Buffer([0]))
-    fs.writeFileSync(path.join(storageDirectory, "INVKEYS"), new Buffer([0]))
-    fs.writeFileSync(path.join(storageDirectory, "BLOB"), new Buffer([0]))
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    expect(blobStore.get("a", "invalidation-key-1")).toBeUndefined()
-    expect(blobStore.get("b", "invalidation-key-2")).toBeUndefined()
-
-    blobStore.set("a", "invalidation-key-1", new Buffer("x"))
-    blobStore.set("b", "invalidation-key-2", new Buffer("y"))
-    blobStore.save()
-
-    blobStore = FileSystemBlobStore.load(storageDirectory)
-
-    expect(blobStore.get("a", "invalidation-key-1")).toEqual(new Buffer("x"))
-    expect(blobStore.get("b", "invalidation-key-2")).toEqual(new Buffer("y"))

spec/fixtures/native-cache/file-1.js

@@ -1 +0,0 @@
-module.exports = function () { return 1; }

spec/fixtures/native-cache/file-2.js

@@ -1 +0,0 @@
-module.exports = function () { return 2; }

spec/fixtures/native-cache/file-3.js

@@ -1 +0,0 @@
-module.exports = function () { return 3; }

spec/fixtures/native-cache/file-4.js

@@ -1 +0,0 @@
-module.exports = function () { return "file-4" }

spec/native-compile-cache-spec.coffee

@@ -1,104 +0,0 @@
-fs = require 'fs'
-path = require 'path'
-Module = require 'module'
-
-describe "NativeCompileCache", ->
-  nativeCompileCache = require '../src/native-compile-cache'
-  [fakeCacheStore, cachedFiles] = []
-
-  beforeEach ->
-    cachedFiles = []
-    fakeCacheStore = jasmine.createSpyObj("cache store", ["set", "get", "has", "delete"])
-    fakeCacheStore.has.andCallFake (cacheKey, invalidationKey) ->
-      fakeCacheStore.get(cacheKey, invalidationKey)?
-    fakeCacheStore.get.andCallFake (cacheKey, invalidationKey) ->
-      for entry in cachedFiles by -1
-        continue if entry.cacheKey isnt cacheKey
-        continue if entry.invalidationKey isnt invalidationKey
-        return entry.cacheBuffer
-      return
-    fakeCacheStore.set.andCallFake (cacheKey, invalidationKey, cacheBuffer) ->
-      cachedFiles.push({cacheKey, invalidationKey, cacheBuffer})
-
-    nativeCompileCache.setCacheStore(fakeCacheStore)
-    nativeCompileCache.setV8Version("a-v8-version")
-    nativeCompileCache.install()
-
-  it "writes and reads from the cache storage when requiring files", ->
-    fn1 = require('./fixtures/native-cache/file-1')
-    fn2 = require('./fixtures/native-cache/file-2')
-
-    expect(cachedFiles.length).toBe(2)
-
-    expect(cachedFiles[0].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-1'))
-    expect(cachedFiles[0].cacheBuffer).toBeInstanceOf(Uint8Array)
-    expect(cachedFiles[0].cacheBuffer.length).toBeGreaterThan(0)
-    expect(fn1()).toBe(1)
-
-    expect(cachedFiles[1].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-2'))
-    expect(cachedFiles[1].cacheBuffer).toBeInstanceOf(Uint8Array)
-    expect(cachedFiles[1].cacheBuffer.length).toBeGreaterThan(0)
-    expect(fn2()).toBe(2)
-
-    delete Module._cache[require.resolve('./fixtures/native-cache/file-1')]
-    fn1 = require('./fixtures/native-cache/file-1')
-    expect(cachedFiles.length).toBe(2)
-    expect(fn1()).toBe(1)
-
-  describe "when v8 version changes", ->
-    it "updates the cache of previously required files", ->
-      nativeCompileCache.setV8Version("version-1")
-      fn4 = require('./fixtures/native-cache/file-4')
-
-      expect(cachedFiles.length).toBe(1)
-      expect(cachedFiles[0].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-4'))
-      expect(cachedFiles[0].cacheBuffer).toBeInstanceOf(Uint8Array)
-      expect(cachedFiles[0].cacheBuffer.length).toBeGreaterThan(0)
-      expect(fn4()).toBe("file-4")
-
-      nativeCompileCache.setV8Version("version-2")
-      delete Module._cache[require.resolve('./fixtures/native-cache/file-4')]
-      fn4 = require('./fixtures/native-cache/file-4')
-
-      expect(cachedFiles.length).toBe(2)
-      expect(cachedFiles[1].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-4'))
-      expect(cachedFiles[1].invalidationKey).not.toBe(cachedFiles[0].invalidationKey)
-      expect(cachedFiles[1].cacheBuffer).toBeInstanceOf(Uint8Array)
-      expect(cachedFiles[1].cacheBuffer.length).toBeGreaterThan(0)
-
-  describe "when a previously required and cached file changes", ->
-    beforeEach ->
-      fs.writeFileSync path.resolve(__dirname + '/fixtures/native-cache/file-5'), """
-      module.exports = function () { return "file-5" }
-      """
-
-    afterEach ->
-      fs.unlinkSync path.resolve(__dirname + '/fixtures/native-cache/file-5')
-
-    it "removes it from the store and re-inserts it with the new cache", ->
-      fn5 = require('./fixtures/native-cache/file-5')
-
-      expect(cachedFiles.length).toBe(1)
-      expect(cachedFiles[0].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-5'))
-      expect(cachedFiles[0].cacheBuffer).toBeInstanceOf(Uint8Array)
-      expect(cachedFiles[0].cacheBuffer.length).toBeGreaterThan(0)
-      expect(fn5()).toBe("file-5")
-
-      delete Module._cache[require.resolve('./fixtures/native-cache/file-5')]
-      fs.appendFileSync(require.resolve('./fixtures/native-cache/file-5'), "\n\n")
-      fn5 = require('./fixtures/native-cache/file-5')
-
-      expect(cachedFiles.length).toBe(2)
-      expect(cachedFiles[1].cacheKey).toBe(require.resolve('./fixtures/native-cache/file-5'))
-      expect(cachedFiles[1].invalidationKey).not.toBe(cachedFiles[0].invalidationKey)
-      expect(cachedFiles[1].cacheBuffer).toBeInstanceOf(Uint8Array)
-      expect(cachedFiles[1].cacheBuffer.length).toBeGreaterThan(0)
-
-  it "deletes previously cached code when the cache is an invalid file", ->
-    fakeCacheStore.has.andReturn(true)
-    fakeCacheStore.get.andCallFake -> new Buffer("an invalid cache")
-
-    fn3 = require('./fixtures/native-cache/file-3')
-
-    expect(fakeCacheStore.delete).toHaveBeenCalledWith(require.resolve('./fixtures/native-cache/file-3'))
-    expect(fn3()).toBe(3)