From b5f68a6434652a9a6e24a76eaa18ef6e13787048 Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 22 Aug 2017 21:03:01 -0600 Subject: [PATCH 1/2] Include more metadata when missing a line node in horizontal measurement --- src/text-editor-component.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index 7e23e5745..623b0f615 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -2230,7 +2230,12 @@ class TextEditorComponent { if (!lineNode) { const error = new Error('Requested measurement of a line that is not currently rendered') - error.metadata = {row, columnsToMeasure} + error.metadata = { + row, columnsToMeasure, + renderedScreenLineIds: this.renderedScreenLines.map((line) => line.id), + extraRenderedScreenLineIds: Array.from(this.extraRenderedScreenLines.keys()), + lineNodeScreenLineIds: Array.from(this.lineNodesByScreenLineId.keys()) + } throw error } From b8d22fb4ba405c57c6ff06548d889d5b89e77bcb Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 22 Aug 2017 22:00:54 -0600 Subject: [PATCH 2/2] Fix lint error --- src/text-editor-component.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/text-editor-component.js b/src/text-editor-component.js index 623b0f615..0c36a0985 100644 --- a/src/text-editor-component.js +++ b/src/text-editor-component.js @@ -2231,7 +2231,8 @@ class TextEditorComponent { if (!lineNode) { const error = new Error('Requested measurement of a line that is not currently rendered') error.metadata = { - row, columnsToMeasure, + row, + columnsToMeasure, renderedScreenLineIds: this.renderedScreenLines.map((line) => line.id), extraRenderedScreenLineIds: Array.from(this.extraRenderedScreenLines.keys()), lineNodeScreenLineIds: Array.from(this.lineNodesByScreenLineId.keys())