github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-11 23:25:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Gracefully handle focus events that occur before the attachedCallback

Browse Source
This commit is contained in:
Nathan Sobo
2017-02-28 16:47:15 -07:00
committed by Antonio Scandurra
parent ff2f9b192a
commit ec045d9333
2 changed files with 56 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/text-editor-component.js
View File

@@ -460,16 +460,19 @@ class TextEditorComponent {
}
didAttach () {
this.intersectionObserver = new IntersectionObserver((entries) => {
const {intersectionRect} = entries[entries.length - 1]
if (intersectionRect.width > 0 || intersectionRect.height > 0) {
this.didShow()
} else {
this.didHide()
}
})
this.intersectionObserver.observe(this.element)
if (this.isVisible()) this.didShow()
if (!this.attached) {
this.attached = true
this.intersectionObserver = new IntersectionObserver((entries) => {
const {intersectionRect} = entries[entries.length - 1]
if (intersectionRect.width > 0 || intersectionRect.height > 0) {
this.didShow()
} else {
this.didHide()
}
})
this.intersectionObserver.observe(this.element)
if (this.isVisible()) this.didShow()
}
}
didShow () {
@@ -489,6 +492,11 @@ class TextEditorComponent {
}
didFocus () {
// This element can be focused from a parent custom element's
// attachedCallback before *its* attachedCallback is fired. This protects
// against that case.
if (!this.attached) this.didAttach()
const {hiddenInput} = this.refs
// Ensure the input is in the visible part of the scrolled content to avoid