github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-14 00:25:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add ability to cancel marker head position observations

Browse Source
This commit is contained in:
Nathan Sobo
2013-01-31 14:11:28 -07:00
parent bc44540b10
commit ec521b3fd3
4 changed files with 38 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/buffer-marker.coffee
View File

@@ -53,6 +53,8 @@ class BufferMarker
observeHeadPosition: (callback) ->
@headPositionObservers.push(callback)
cancel: =>
_.remove(@headPositionObservers, callback)
tryToInvalidate: (oldRange) ->
containsStart = oldRange.containsPoint(@getStartPosition(), exclusive: true)

10
src/app/display-buffer.coffee
View File

@@ -355,10 +355,18 @@ class DisplayBuffer
@markerScreenPositionObservers[id] ?= { head: [], tail: [] }
@cacheMarkerScreenPositions(id) unless @markerScreenPositions[id]
@markerScreenPositionObservers[id].head.push(callback)
@buffer.observeMarkerHeadPosition id, (bufferPosition) =>
subscription = @buffer.observeMarkerHeadPosition id, (bufferPosition) =>
@cacheMarkerScreenPositions(id)
callback(@screenPositionForBufferPosition(bufferPosition))
cancel: =>
subscription.cancel()
{ head, tail } = @markerScreenPositionObservers[id]
_.remove(head, callback)
unless head.length + tail.length
delete @markerScreenPositionObservers[id]
delete @markerScreenPositions[id]
cacheMarkerScreenPositions: (id) ->
@markerScreenPositions[id] = { head: @getMarkerHeadScreenPosition(id), tail: @getMarkerTailScreenPosition }