✅ Add specs for new commands, update old specs

spec/pane-container-element-spec.coffee

@@ -231,10 +231,14 @@ describe "PaneContainerElement", ->
         expect(leftPane.getFlexScale()).toBe 1/1.1
         expect(rightPane.getFlexScale()).toBe 1/1.1
 
-  describe "changing focus directionally between panes", ->
-    [containerElement, pane1, pane2, pane3, pane4, pane5, pane6, pane7, pane8, pane9] = []
+  describe "changing focus, copying and moving items directionally between panes", ->
+    [item1, item2, item3, item4, item5, item6, item7, item8, item9,
+     pane1, pane2, pane3, pane4, pane5, pane6, pane7, pane8, pane9,
+     container, containerElement] = []
 
     beforeEach ->
+      atom.config.set("core.destroyEmptyPanes", false)
+
       # Set up a grid of 9 panes, in the following arrangement, where the
       # numbers correspond to the variable names below.
       #
@@ -250,22 +254,30 @@ describe "PaneContainerElement", ->
         element = document.createElement('div')
         element.textContent = id
         element.tabIndex = -1
+        element.copy = ->
+          element.cloneNode(true)
         element
 
       container = new PaneContainer(config: atom.config, confirm: atom.confirm.bind(atom))
+
+      [item1, item2, item3, item4, item5, item6, item7, item8, item9] =
+        [buildElement('1'), buildElement('2'), buildElement('3'),
+         buildElement('4'), buildElement('5'), buildElement('6'),
+         buildElement('7'), buildElement('8'), buildElement('9')]
+
       pane1 = container.getActivePane()
-      pane1.activateItem(buildElement('1'))
-      pane4 = pane1.splitDown(items: [buildElement('4')])
-      pane7 = pane4.splitDown(items: [buildElement('7')])
+      pane1.activateItem(item1)
+      pane4 = pane1.splitDown(items: [item4])
+      pane7 = pane4.splitDown(items: [item7])
 
-      pane2 = pane1.splitRight(items: [buildElement('2')])
-      pane3 = pane2.splitRight(items: [buildElement('3')])
+      pane2 = pane1.splitRight(items: [item2])
+      pane3 = pane2.splitRight(items: [item3])
 
-      pane5 = pane4.splitRight(items: [buildElement('5')])
-      pane6 = pane5.splitRight(items: [buildElement('6')])
+      pane5 = pane4.splitRight(items: [item5])
+      pane6 = pane5.splitRight(items: [item6])
 
-      pane8 = pane7.splitRight(items: [buildElement('8')])
-      pane9 = pane8.splitRight(items: [buildElement('9')])
+      pane8 = pane7.splitRight(items: [item8])
+      pane9 = pane8.splitRight(items: [item9])
 
       containerElement = atom.views.getView(container)
       containerElement.style.height = '400px'
@@ -323,3 +335,87 @@ describe "PaneContainerElement", ->
           pane6.activate()
           containerElement.focusPaneViewOnRight()
           expect(document.activeElement).toBe pane6.getActiveItem()
+
+    describe "::moveActiveItemToPaneAbove(keepOriginal)", ->
+      describe "when there are multiple rows above the focused pane", ->
+        it "moves the active item up to the adjacent row", ->
+          pane8.activate()
+          containerElement.moveActiveItemToPaneAbove()
+          expect(container.paneForItem(item8)).toBe pane5
+          expect(pane5.getActiveItem()).toBe item8
+
+      describe "when there are no rows above the focused pane", ->
+        it "keeps the active item in the focused pane", ->
+          pane2.activate()
+          containerElement.moveActiveItemToPaneAbove()
+          expect(container.paneForItem(item2)).toBe pane2
+
+      describe "when `keepOriginal: true` is passed in the params", ->
+        it "keeps the item and adds a copy of it to the adjacent pane", ->
+          pane8.activate()
+          containerElement.moveActiveItemToPaneAbove(keepOriginal: true)
+          expect(container.paneForItem(item8)).toBe pane8
+          expect(pane5.getActiveItem().textContent).toBe '8'
+
+    describe "::moveActiveItemToPaneBelow(keepOriginal)", ->
+      describe "when there are multiple rows below the focused pane", ->
+        it "moves the active item down to the adjacent row", ->
+          pane2.activate()
+          containerElement.moveActiveItemToPaneBelow()
+          expect(container.paneForItem(item2)).toBe pane5
+          expect(pane5.getActiveItem()).toBe item2
+
+      describe "when there are no rows below the focused pane", ->
+        it "keeps the active item in the focused pane", ->
+          pane8.activate()
+          containerElement.moveActiveItemToPaneBelow()
+          expect(container.paneForItem(item8)).toBe pane8
+
+      describe "when `keepOriginal: true` is passed in the params", ->
+        it "keeps the item and adds a copy of it to the adjacent pane", ->
+          pane2.activate()
+          containerElement.moveActiveItemToPaneBelow(keepOriginal: true)
+          expect(container.paneForItem(item2)).toBe pane2
+          expect(pane5.getActiveItem().textContent).toBe '2'
+
+    describe "::moveActiveItemToPaneOnLeft(keepOriginal)", ->
+      describe "when there are multiple columns to the left of the focused pane", ->
+        it "moves the active item left to the adjacent column", ->
+          pane6.activate()
+          containerElement.moveActiveItemToPaneOnLeft()
+          expect(container.paneForItem(item6)).toBe pane5
+          expect(pane5.getActiveItem()).toBe item6
+
+      describe "when there are no columns to the left of the focused pane", ->
+        it "keeps the active item in the focused pane", ->
+          pane4.activate()
+          containerElement.moveActiveItemToPaneOnLeft()
+          expect(container.paneForItem(item4)).toBe pane4
+
+      describe "when `keepOriginal: true` is passed in the params", ->
+        it "keeps the item and adds a copy of it to the adjacent pane", ->
+          pane6.activate()
+          containerElement.moveActiveItemToPaneOnLeft(keepOriginal: true)
+          expect(container.paneForItem(item6)).toBe pane6
+          expect(pane5.getActiveItem().textContent).toBe '6'
+
+    describe "::moveActiveItemToPaneOnRight(keepOriginal)", ->
+      describe "when there are multiple columns to the right of the focused pane", ->
+        it "moves the active item right to the adjacent column", ->
+          pane4.activate()
+          containerElement.moveActiveItemToPaneOnRight()
+          expect(container.paneForItem(item4)).toBe pane5
+          expect(pane5.getActiveItem()).toBe item4
+
+      describe "when there are no columns to the right of the focused pane", ->
+        it "keeps the active item in the focused pane", ->
+          pane6.activate()
+          containerElement.moveActiveItemToPaneOnRight()
+          expect(container.paneForItem(item6)).toBe pane6
+
+      describe "when `keepOriginal: true` is passed in the params", ->
+        it "keeps the item and adds a copy of it to the adjacent pane", ->
+          pane4.activate()
+          containerElement.moveActiveItemToPaneOnRight(keepOriginal: true)
+          expect(container.paneForItem(item4)).toBe pane4
+          expect(pane5.getActiveItem().textContent).toBe '4'

spec/pane-container-spec.coffee

@@ -325,3 +325,27 @@ describe "PaneContainer", ->
       expect(item1.saved).toBe true
       expect(item2.saved).toBe false
       expect(item3.saved).toBe true
+
+  describe "::moveActiveItemToPane(destPane) and ::copyActiveItemToPane(destPane)", ->
+    [container, pane1, pane2, item1] = []
+
+    beforeEach ->
+      class TestItem
+        constructor: (id) -> @id = id
+        copy: -> new TestItem(@id)
+
+      container = new PaneContainer(params)
+      pane1 = container.getRoot()
+      item1 = new TestItem('1')
+      pane2 = pane1.splitRight(items: [item1])
+
+    describe "::::moveActiveItemToPane(destPane)", ->
+      it "moves active item to given pane and focuses it", ->
+        container.moveActiveItemToPane(pane1)
+        expect(pane1.getActiveItem()).toBe item1
+
+    describe "::::copyActiveItemToPane(destPane)", ->
+      it "copies active item to given pane and focuses it", ->
+        container.copyActiveItemToPane(pane1)
+        expect(container.paneForItem(item1)).toBe pane2
+        expect(pane1.getActiveItem().id).toBe item1.id

spec/pane-spec.coffee

@@ -606,12 +606,13 @@ describe "Pane", ->
           expect(item4.isDestroyed()).toBe false
 
   describe "split methods", ->
-    [pane1, container] = []
+    [pane1, item1, container] = []
 
     beforeEach ->
       container = new PaneContainer(config: atom.config, confirm: confirm, deserializerManager: atom.deserializers)
       pane1 = container.getActivePane()
-      pane1.addItem(new Item("A"))
+      item1 = new Item("A")
+      pane1.addItem(item1)
 
     describe "::splitLeft(params)", ->
       describe "when the parent is the container root", ->
@@ -621,6 +622,11 @@ describe "Pane", ->
           expect(container.root.orientation).toBe 'horizontal'
           expect(container.root.children).toEqual [pane2, pane3, pane1]
 
+      describe "when `moveActiveItem: true` is passed in the params", ->
+        it "moves the active item", ->
+          pane2 = pane1.splitLeft(moveActiveItem: true)
+          expect(pane2.getActiveItem()).toBe item1
+
       describe "when `copyActiveItem: true` is passed in the params", ->
         it "duplicates the active item", ->
           pane2 = pane1.splitLeft(copyActiveItem: true)
@@ -643,6 +649,11 @@ describe "Pane", ->
           expect(container.root.orientation).toBe 'horizontal'
           expect(container.root.children).toEqual [pane1, pane3, pane2]
 
+      describe "when `moveActiveItem: true` is passed in the params", ->
+        it "moves the active item", ->
+          pane2 = pane1.splitLeft(moveActiveItem: true)
+          expect(pane2.getActiveItem()).toBe item1
+
       describe "when `copyActiveItem: true` is passed in the params", ->
         it "duplicates the active item", ->
           pane2 = pane1.splitRight(copyActiveItem: true)
@@ -665,6 +676,11 @@ describe "Pane", ->
           expect(container.root.orientation).toBe 'vertical'
           expect(container.root.children).toEqual [pane2, pane3, pane1]
 
+      describe "when `moveActiveItem: true` is passed in the params", ->
+        it "moves the active item", ->
+          pane2 = pane1.splitLeft(moveActiveItem: true)
+          expect(pane2.getActiveItem()).toBe item1
+
       describe "when `copyActiveItem: true` is passed in the params", ->
         it "duplicates the active item", ->
           pane2 = pane1.splitUp(copyActiveItem: true)
@@ -687,6 +703,11 @@ describe "Pane", ->
           expect(container.root.orientation).toBe 'vertical'
           expect(container.root.children).toEqual [pane1, pane3, pane2]
 
+      describe "when `moveActiveItem: true` is passed in the params", ->
+        it "moves the active item", ->
+          pane2 = pane1.splitLeft(moveActiveItem: true)
+          expect(pane2.getActiveItem()).toBe item1
+
       describe "when `copyActiveItem: true` is passed in the params", ->
         it "duplicates the active item", ->
           pane2 = pane1.splitDown(copyActiveItem: true)