From ca72b802acbd2d7206d6e2278a55d5735f71a79e Mon Sep 17 00:00:00 2001 From: Wliu <50Wliu@users.noreply.github.com> Date: Sun, 7 Jun 2015 11:23:42 -0400 Subject: [PATCH 1/2] Enable "Downloading Update" context menu entry Previously 'update-downloaded' would get emitted right after 'update-available' which would suppress the "Downloading Update" menu entry --- src/browser/auto-updater-win32.coffee | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/browser/auto-updater-win32.coffee b/src/browser/auto-updater-win32.coffee index 89018a396..d1ed277e2 100644 --- a/src/browser/auto-updater-win32.coffee +++ b/src/browser/auto-updater-win32.coffee @@ -14,6 +14,8 @@ class AutoUpdater require('auto-updater').quitAndInstall() downloadUpdate: (callback) -> + @emit 'update-available' + SquirrelUpdate.spawn ['--download', @updateUrl], (error, stdout) -> return callback(error) if error? @@ -56,7 +58,6 @@ class AutoUpdater @emit 'update-not-available' return - @emit 'update-available' @emit 'update-downloaded', {}, update.releaseNotes, update.version, new Date(), 'https://atom.io', => @quitAndInstall() module.exports = new AutoUpdater() From 9e6e05a5a6c28eeb5d4e321d58a035beb6326e84 Mon Sep 17 00:00:00 2001 From: Wliu <50Wliu@users.noreply.github.com> Date: Sun, 7 Jun 2015 11:33:26 -0400 Subject: [PATCH 2/2] Put 'update-available' in @downloadUpdate instead So that it only shows up when there's an actual update --- src/browser/auto-updater-win32.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browser/auto-updater-win32.coffee b/src/browser/auto-updater-win32.coffee index d1ed277e2..4d043ac4e 100644 --- a/src/browser/auto-updater-win32.coffee +++ b/src/browser/auto-updater-win32.coffee @@ -14,8 +14,6 @@ class AutoUpdater require('auto-updater').quitAndInstall() downloadUpdate: (callback) -> - @emit 'update-available' - SquirrelUpdate.spawn ['--download', @updateUrl], (error, stdout) -> return callback(error) if error? @@ -53,6 +51,8 @@ class AutoUpdater @emit 'update-not-available' return + @emit 'update-available' + @installUpdate (error) => if error? @emit 'update-not-available'