From c12f94907dc009395bcdafc746ec8fb689813830 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 25 Mar 2015 10:01:09 -0700 Subject: [PATCH 1/3] Remove grim.deprecate override --- src/atom.coffee | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/atom.coffee b/src/atom.coffee index 188d0b3a6..707500479 100644 --- a/src/atom.coffee +++ b/src/atom.coffee @@ -207,12 +207,6 @@ class Atom extends Model # # Call after this instance has been assigned to the `atom` global. initialize: -> - # Disable deprecations unless in dev mode or spec mode so that regular - # editor performance isn't impacted by generating stack traces for - # deprecated calls. - unless @inDevMode() or @inSpecMode() - require('grim').deprecate = -> - sourceMapCache = {} window.onerror = => From c2fecacdbed55e4886b6986c8794aa194b48de93 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 25 Mar 2015 10:47:06 -0700 Subject: [PATCH 2/3] Fail CI build when deprecations exist --- spec/jasmine-helper.coffee | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/spec/jasmine-helper.coffee b/spec/jasmine-helper.coffee index 7642de7d7..1efb6ce19 100644 --- a/spec/jasmine-helper.coffee +++ b/spec/jasmine-helper.coffee @@ -27,8 +27,15 @@ module.exports.runSpecSuite = (specSuite, logFile, logErrors=true) -> fs.closeSync(logStream) if logStream? if process.env.JANKY_SHA1 grim = require 'grim' - grim.logDeprecations() if grim.getDeprecationsLength() > 0 - atom.exit(runner.results().failedCount > 0 ? 1 : 0) + + if grim.getDeprecationsLength() > 0 + grim.logDeprecations() + return atom.exit(1) if runner.results().failedCount is 0 + + if runner.results().failedCount > 0 + atom.exit(1) + else + atom.exit(0) else AtomReporter = require './atom-reporter' reporter = new AtomReporter() From ffdf7ac55840c40bd25b79e2bea9998d48c46878 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 25 Mar 2015 12:31:08 -0700 Subject: [PATCH 3/3] Remove unneeded failed count check --- spec/jasmine-helper.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/jasmine-helper.coffee b/spec/jasmine-helper.coffee index 1efb6ce19..1e099d897 100644 --- a/spec/jasmine-helper.coffee +++ b/spec/jasmine-helper.coffee @@ -30,7 +30,7 @@ module.exports.runSpecSuite = (specSuite, logFile, logErrors=true) -> if grim.getDeprecationsLength() > 0 grim.logDeprecations() - return atom.exit(1) if runner.results().failedCount is 0 + return atom.exit(1) if runner.results().failedCount > 0 atom.exit(1)