From f4832148cd133b7cfbc382cf1270954756812c1a Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Thu, 28 Jun 2012 13:17:49 -0600 Subject: [PATCH] Buffer finder does not open if there are no open buffers with paths --- spec/extensions/fuzzy-finder-spec.coffee | 7 +++++++ src/extensions/fuzzy-finder.coffee | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/spec/extensions/fuzzy-finder-spec.coffee b/spec/extensions/fuzzy-finder-spec.coffee index 72792f1a8..254f4ac59 100644 --- a/spec/extensions/fuzzy-finder-spec.coffee +++ b/spec/extensions/fuzzy-finder-spec.coffee @@ -92,6 +92,13 @@ describe 'FuzzyFinder', -> rootView.trigger 'fuzzy-finder:toggle-buffer-finder' expect(rootView.find('.fuzzy-finder')).not.toExist() + describe "when there is no active editor", -> + it "does not open", -> + rootView.activeEditor().removeActiveEditSession() + expect(rootView.activeEditor()).toBeUndefined() + rootView.trigger 'fuzzy-finder:toggle-buffer-finder' + expect(rootView.find('.fuzzy-finder')).not.toExist() + describe "fuzzy-finder:cancel event", -> it "hides the finder", -> rootView.trigger 'fuzzy-finder:toggle-file-finder' diff --git a/src/extensions/fuzzy-finder.coffee b/src/extensions/fuzzy-finder.coffee index b89fbc884..fefef4fe6 100644 --- a/src/extensions/fuzzy-finder.coffee +++ b/src/extensions/fuzzy-finder.coffee @@ -52,7 +52,7 @@ class FuzzyFinder extends View populateOpenBufferPaths: -> @paths = @rootView.activeEditor()?.getOpenBufferPaths().map (path) => @rootView.project.relativize(path) - @populatePathList() + @populatePathList() if @paths?.length attach: -> @rootView.append(this)