From acb19c1fe1d1baacbb7f797d5a54f97276b58cf9 Mon Sep 17 00:00:00 2001 From: Lee Dohm Date: Fri, 9 Jan 2015 16:33:48 -0800 Subject: [PATCH 1/2] Log scopes to notification instead of console Fixes #4969 --- spec/text-editor-spec.coffee | 9 +++++++++ src/text-editor.coffee | 6 +++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/spec/text-editor-spec.coffee b/spec/text-editor-spec.coffee index cd683ed2a..432502238 100644 --- a/spec/text-editor-spec.coffee +++ b/spec/text-editor-spec.coffee @@ -944,6 +944,15 @@ describe "TextEditor", -> editor.undo() expect(editor.getScrollTop()).toBe 0 + describe '.logCursorScope()', -> + beforeEach -> + spyOn(atom.notifications, 'addInfo') + + it 'opens a notification', -> + editor.logCursorScope() + + expect(atom.notifications.addInfo).toHaveBeenCalled() + describe "selection", -> selection = null diff --git a/src/text-editor.coffee b/src/text-editor.coffee index 8e1037a69..eeeb774fa 100644 --- a/src/text-editor.coffee +++ b/src/text-editor.coffee @@ -2522,7 +2522,11 @@ class TextEditor extends Model logCursorScope: -> scopeDescriptor = @getLastCursor().getScopeDescriptor() - console.log scopeDescriptor.scopes, scopeDescriptor + list = scopeDescriptor.scopes.toString().split(',') + list = _.map list, (item) -> "* #{item}" + content = "Scopes at Cursor\n#{list.join('\n')}" + + atom.notifications.addInfo(content, dismissable: true) # {Delegates to: DisplayBuffer.tokenForBufferPosition} tokenForBufferPosition: (bufferPosition) -> @displayBuffer.tokenForBufferPosition(bufferPosition) From ef97197681b69909748077db5b0f76c100c9a5d4 Mon Sep 17 00:00:00 2001 From: Lee Dohm Date: Fri, 9 Jan 2015 16:42:16 -0800 Subject: [PATCH 2/2] Use list.map instead of _.map list --- src/text-editor.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/text-editor.coffee b/src/text-editor.coffee index eeeb774fa..aeaeb49ea 100644 --- a/src/text-editor.coffee +++ b/src/text-editor.coffee @@ -2523,7 +2523,7 @@ class TextEditor extends Model logCursorScope: -> scopeDescriptor = @getLastCursor().getScopeDescriptor() list = scopeDescriptor.scopes.toString().split(',') - list = _.map list, (item) -> "* #{item}" + list = list.map (item) -> "* #{item}" content = "Scopes at Cursor\n#{list.join('\n')}" atom.notifications.addInfo(content, dismissable: true)