From f611e235e9002b02eb6df797beae51c61a934e05 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 3 Mar 2015 17:00:55 -0800 Subject: [PATCH] Extract notification helper --- src/package-manager.coffee | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/package-manager.coffee b/src/package-manager.coffee index 22c62e9b4..58cade753 100644 --- a/src/package-manager.coffee +++ b/src/package-manager.coffee @@ -344,11 +344,7 @@ class PackageManager try metadata = Package.loadMetadata(packagePath) ? {} catch error - metadataPath = path.join(packagePath, 'package.json') - detail = error.message + " in #{metadataPath}" - stack = error.stack + "\n at #{metadataPath}:1:1" - message = "Failed to load the #{path.basename(packagePath)} package" - atom.notifications.addFatalError(message, {stack, detail, dismissable: true}) + @handleMetadataError(error, packagePath) return null if metadata.theme @@ -427,3 +423,10 @@ class PackageManager pack.deactivate() delete @activePackages[pack.name] @emitter.emit 'did-deactivate-package', pack + + handleMetadataError: (error, packagePath)-> + metadataPath = path.join(packagePath, 'package.json') + detail = error.message + " in #{metadataPath}" + stack = error.stack + "\n at #{metadataPath}:1:1" + message = "Failed to load the #{path.basename(packagePath)} package" + atom.notifications.addFatalError(message, {stack, detail, dismissable: true})