Commit Graph

35 Commits

Author SHA1 Message Date
steven nguyen
ee56b4ba7b separate getLocalNpmBinPath for install-apm.js 2022-02-28 14:44:12 +00:00
icecream17
ece90b3e3f Remove unused imports 2022-02-26 16:35:23 -06:00
icecream17
790511ac51 Fix npm ENOENT error in install-script-runner-dependencies
Despite what https://github.com/atom/atom/pull/23322 is named,
the pull request actually makes install-script-dependencies
use the non-local npm binary.

So this pr fixes install-script-runner-dependencies by making the npmBinPath
consistent with install-script-dependencies

ENOENT detected by https://github.com/atom-community/atom/pull/351,
specifically https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=1132&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5&t=0a53f124-4db9-5fc3-be81-e293757effc7&l=16
2022-02-26 16:26:23 -06:00
sadick254
22c3e44d10 We don't need to verify npm version
We have defaulted to using npm that installed as part of the script
dependancies. This is to increase predictability on what version of npm
was used to install atom dependencies
2021-12-03 16:22:25 +03:00
sadick254
36562eaea1 Install using npm installed during installation of script dependencies 2021-12-03 14:19:52 +03:00
Benjamin Gray
4e1f76530c Define npm_config_jobs env variable in build scripts (#21315)
Adds the npm_config_jobs env variable across build scripts that may benefit from it (ones that run apm install). This variable is used by node-gyp to compile native code with a number of threads equal to the reported CPU core count
2021-01-22 23:03:30 +03:00
Rafael Oleza
698b581106 Run prettier 2019-06-26 16:32:07 +02:00
Linus Eriksson
2d6cc4f172 Use a different name depending on channel
This makes Atom beta install in %LOCALAPPDATA%\atom-beta and stable in 
%LOCALAPPDATA%\atom so that installs are side by side
2019-06-25 17:58:50 +02:00
Rafael Oleza
e213a69a1f Re-apply prettier JS formatter 2019-06-01 00:29:10 +02:00
Rafael Oleza
79f6836349 Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into dw-windows-separate-channels 2019-06-01 00:28:37 +02:00
Rafael Oleza
975f203dc7 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into dw-windows-separate-channels 2019-06-01 00:27:52 +02:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Jason Rudolph
cb3f24fc5c Use env var to specify path to npm binary 2019-04-18 09:53:40 -04:00
David Wilson
eb7f0aa452 Produce channel-specific Atom .exe and .cmd files on Windows 2018-09-20 12:05:01 -07:00
Ash Wilson
347da770dc Don't use the npm binary you're about to delete 2018-08-08 08:41:30 -04:00
David Wilson
de93396af7 👕 Make the linter happy 2018-07-12 11:06:26 -07:00
David Wilson
bf9fac27cf Use a consistent app naming strategy across non-stable channels 2018-07-12 10:14:15 -07:00
David Wilson
0c364d0438 Don't change Atom app name on dev channel 2018-06-29 16:31:12 -07:00
David Wilson
9669a9bbfb Update app title and file paths to use channel name 2018-06-28 12:52:39 -07:00
David Wilson
ed48f2d1f7 Generate nightly build version from package.json 2018-06-26 10:46:49 -07:00
David Wilson
9388a7813e Simplify channel name detection 2018-06-26 10:45:10 -07:00
David Wilson
34e37f3159 Enable automated nightly Atom releases
This change adds automation for producing nightly Atom releases using
VSTS CI.  Most of the changes are just slight modifications to Atom's
existing build scripts to produce another build channel and publish
those artifacts in a way that can be installed and updated when new
releases are available.
2018-06-18 21:01:19 -07:00
Wliu
7c2510eb9c Merge branch 'master' into wl-build-on-node-7 2017-05-11 12:06:26 -04:00
Kieran Simpson
31cbdb44d8 Fixes #14102 to use ATOM_HOME if present. 2017-03-31 11:25:04 +11:00
Wliu
d202c1abd3 Merge branch 'master' into wl-build-on-node-7 2017-03-24 00:27:57 -04:00
Antonio Scandurra
4c6805bf76 Store style sheet sources as auxiliary data in the snapshot 2017-03-09 14:23:58 +01:00
Wliu
20635a4f4f :lint: 2017-01-25 11:13:42 -05:00
Antonio Scandurra
8249dbbb79 Fix release channel detection on Travis
In the previous build scripts, we were considering all the builds
triggered by a pull-request to be part of the dev channel. We adopted
the same heuristic for the new build scripts, but didn't notice that
Travis always sets the `TRAVIS_PULL_REQUEST` variable to "false" (which
causes the `process.env.TRAVIS_PULL_REQUEST` expression to be evaluated
as truthy).

In the past, this wasn't a problem because we were building artifacts
via Janky, but after switching to Travis this makes it generate the
wrong assets on stable and beta.

To fix this, it seems reasonable to remove the conditional that checks
if we are building a pull-request: in the past this could have been
problematic because assets could be uploaded inadvertently to S3 or
GitHub, but this should be safe now that we rely on the release
publisher to perform that task.
2016-09-01 09:49:37 +02:00
Antonio Scandurra
14611926ac Ensure script/bootstrap works after cleaning dependencies up 2016-08-29 13:40:17 +02:00
Antonio Scandurra
5fc2405801 Compile CSON, Babel and Coffeescript files using CompileCache 2016-08-13 12:49:46 +02:00
Antonio Scandurra
65b0f7d70f Rename cachePath to electronDownloadPath 2016-08-11 12:18:33 +02:00
Nathan Sobo
e949984fe8 Add API docs generation to new build script
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-03 09:45:43 -06:00
Antonio Scandurra
748e61c88f Fix apm bin path on AppVeyor 2016-08-02 14:55:34 +02:00
Antonio Scandurra
cf85bd032d Reimplement script/bootstrap 2016-08-02 14:04:45 +02:00
Antonio Scandurra
aa63162aed Move build to script 2016-08-02 09:24:02 +02:00