Commit Graph

26 Commits

Author SHA1 Message Date
sadick254
22c3e44d10 We don't need to verify npm version
We have defaulted to using npm that installed as part of the script
dependancies. This is to increase predictability on what version of npm
was used to install atom dependencies
2021-12-03 16:22:25 +03:00
sadick254
36562eaea1 Install using npm installed during installation of script dependencies 2021-12-03 14:19:52 +03:00
Musa Ibrahim
dd4fae1eb9 Merge pull request #22979 from DeeDeeG/update-system-requirements-checker-node
bootstrap: Use legacy-compatible `catch` syntax (support older Node)
2021-09-20 16:47:01 +01:00
DeeDeeG
f35e51273d bootstrap: Update required Node to 10.12+
"Node 10.12 or newer" has been a hard requirement since this PR:
https://github.com/atom/atom/pull/20879,
due to newer versions of electron-chromedriver and electron-mksnapshot
relying on extract-zip@2 as an indirect dependency.

(extract-zip@2 requires Node 10.12 or newer for its recursive mkdir.
Using extract-zip@2 with Node older than 10.12 results in errors.

That leads to a lack of electron-vendored
chromedriver or mksnapshot binaries where they're supposed to be.
Which in turn causes startup blob creation (via mksnapshot) to fail
toward the end of the Atom build scripts.)
2021-09-18 16:28:13 -04:00
DeeDeeG
5339e5d528 bootstrap: Fix syntax error for Node older than 10
We don't actually support Node older than 10 for successfully
bootstrapping an Atom build, but we should support older Node in the
system requirements checker script so that we can print useful errors,
like ones to tell the user their system's copy of Node is too old!

(It was me that introduced this Node 10.0.0 or above-only syntax
about a year ago... My mistake. It's as good a time as any to fix it!)
2021-09-13 21:07:59 -04:00
DeeDeeG
fef2de59a4 node-gyp 5.x still accepts Python 2.6 2020-07-10 11:58:17 -04:00
DeeDeeG
f8fecadcbb script: Refactor variable use in verifyPython() 2020-06-17 16:43:38 -04:00
DeeDeeG
dc44ad2d16 script: Update comment in verifyPython() 2020-06-17 16:33:58 -04:00
DeeDeeG
bb2cfa9555 script: Update comments for node-gyp 7.0 release 2020-06-03 20:54:50 -04:00
DeeDeeG
8965d32bcb script: Use "let" not "var" in verifyPython() 2020-06-03 17:03:40 -04:00
DeeDeeG
b1288ca7bb script: correct failure logging in verifyPython()
Make sure a previously found version isn't erroneously logged,
by clearing the "fullVersion" variable before each new check.
2020-06-03 16:28:41 -04:00
DeeDeeG
893f84cb5a script: Refactor log strings for readability
in script/lib/verify-machine-requirements.js
2020-05-30 22:13:03 -04:00
DeeDeeG
4d9d6fa171 👕 Fix lints (verify-machine-requirements.js) 2020-05-30 18:40:27 -04:00
DeeDeeG
2c6c14d197 script: Add attempt logging for verifyPython()
Log which Python commands were tried, and the results,
if no usable Python was found. Useful for debugging failures.
2020-05-30 16:33:32 -04:00
DeeDeeG
b86afa5854 script: Reimplement node-gyp's find-python library
Use this to find python for the verify-machine-requirements.js script.
2020-05-30 11:19:29 -04:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Jason Rudolph
4980439f0c Require npm 6+ on CI
This change will allow us to use `npm ci` instead of `npm install` on 
CI, so that we can respect the package-lock.json file.
2019-04-17 11:48:28 -04:00
Michelle Tilley
1f56e068cd Update docs and checks for Node 6 2017-05-30 17:08:12 -07:00
Wliu
038f03a89f stdout shouldn't be a constant 2017-01-24 19:57:05 -05:00
Wliu
197b694cdf Allow Atom to build on Node 7+ 2017-01-24 19:55:53 -05:00
Lee Dohm
0d2646f9af Fix first guard clause 2016-12-19 19:23:38 -08:00
Lee Dohm
0efd95e0ea Prevent builds on Node 7+ until they're fixed 2016-12-19 19:06:02 -08:00
Antonio Scandurra
14611926ac Ensure script/bootstrap works after cleaning dependencies up 2016-08-29 13:40:17 +02:00
Antonio Scandurra
e3e85e4780 Put back mistakenly deleted requires 2016-08-16 12:46:37 +02:00
Antonio Scandurra
d7f7f3527e Extract a spawnSync helper that throws on command errors 2016-08-16 12:29:42 +02:00
Antonio Scandurra
cf85bd032d Reimplement script/bootstrap 2016-08-02 14:04:45 +02:00