github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-20 20:38:09 -05:00
Code Issues Packages Projects Releases Wiki Activity
38,515 Commits 140 Branches 571 Tags
increase-ci-timeout
Commit Graph

36 Commits

Author SHA1 Message Date
Jason Rudolph
44cad8f586 Revert "Disable flaky spec on Windows until we can identify a proper fix" 
This reverts commit a0742f8e9d.

As of 8734f66aab, we're now using the nsfw fixes from
https://github.com/atom/nsfw/pull/9, which should resolve the flakiness
we were seeing on Windows.
 2019-06-14 11:20:37 -04:00
Jason Rudolph
a0742f8e9d Disable flaky spec on Windows until we can identify a proper fix 2019-06-13 13:04:36 -04:00
Jason Rudolph
d03d2772b5 👕 
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
 2019-06-13 12:41:50 -04:00
Jason Rudolph
9fa32c7c22 Convert spec to use async/await 
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
 2019-06-13 11:35:12 -04:00
Jason Rudolph
c7d17f6233 If spec succeeds, clear the timeout 
Prior to this change, the `console.error` statement _always_ ran, 
regardless of whether the promise resolved successfully. With this 
change, we clear the timeout in the scenario where the promise resolves 
successfully.

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
 2019-06-13 11:23:30 -04:00
Jason Rudolph
f9405cb25d Fix test initialization 
If multiple specs were to populate the events var, one spec would 
pollute the others. So, let's reset the events var at the beginning of 
each spec.

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
 2019-06-13 11:16:53 -04:00
Jason Rudolph
83119fb3e4 Update onDidChangeFiles spec to use real clock 
Prior to this change, the spec was using the fake clock, which was
preventing the `setTimeout` from ever calling the `expire` function.

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
 2019-06-13 11:14:31 -04:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Nathan Sobo
770b8fdcf8 Revert "Merge pull request #19244 from atom/ns/notify" 
This reverts commit b2ecabd527, reversing
changes made to c3bf95194a.
 2019-05-17 04:10:17 -06:00
Nathan Sobo
be7d129675 Normalize to realpath in waitForEvents helper 2019-05-10 14:31:14 -06:00
Nathan Sobo
b1b1b15d49 Normalize %TEMP% to a long path on Windows CI 
This avoids problems with assertions that involve paths inside the temp 
folder.
 2019-05-10 13:46:57 -06:00
Nathan Sobo
5bfbdd2bce Stop all watchers before attempting to replace directory with file 
I think that the notify subprocess might be holding a lock on the 
watched directory on Windows.
 2019-05-03 14:11:59 -06:00
Nathan Sobo
1ec8e7730b Work around 8.3 path issue on Azure Windows 2019-05-03 10:46:33 -06:00
Nathan Sobo
f8d7c9cbce Use async/await in test to see if it fixes Windows failures on CI 2019-05-02 13:35:04 -06:00
Rafael Oleza
c35ec012b4 Run prettier on spec/ folder 2019-02-28 19:30:03 +01:00
Jason Rudolph
c74971e40c Fix repository tests that fail when run in fork of atom/atom 
Prior to this change, these tests assumed that the local repository is a
clone of atom/atom, and the tests (unintentionally) failed if the local
repository was a fork of atom/atom:

https://circleci.com/gh/marcomorain/atom-1/29

Instead of depending on the local clone of the atom repository for these
tests, this commit updates the tests to use one of the fixture
repositories. 😅
 2018-07-27 09:40:38 -04:00
Jason Rudolph
2a5f7e20c3 ✅ Fix overly-specific assertion 
Fixes failing assertions [1] that unnecessarily assumed that the 
repository was cloned using `https://github.com/atom/atom.git` as the 
URL, as opposed to `git@github.com:atom/atom.git` as the URL.

[1] https://circleci.com/gh/atom/atom/7981
 2018-07-20 15:15:59 -04:00
Jason Rudolph
55da0d8f5d Introduce atom.project.observeRepositories(callback) 2018-07-20 14:05:56 -04:00
Jason Rudolph
806d9311bf Introduce atom.project.onDidAddRepository(callback) 2018-07-20 14:04:22 -04:00
Philip Weiss
685292bb8d fix linting issues 2018-03-06 11:09:58 -08:00
Philip Weiss
062dfdea80 address PR comments 2018-03-06 11:06:22 -08:00
Philip Weiss
232f821c35 remove getProjectSettings 2018-03-01 19:45:40 -08:00
Philip Weiss
9fb756feeb save entire settings object, rather than just the filename 2018-03-01 13:28:16 -08:00
Philip Weiss
48d3677664 update project api names 2018-02-26 15:45:56 -08:00
Philip Weiss
547b067f3e add callback to onDidReplaceAtomProject and add tests 2018-02-26 14:38:50 -08:00
Max Brunsfeld
4ec1d85aad Merge branch 'master' into mb-use-language-mode-api 2017-11-06 11:32:52 -08:00
Max Brunsfeld
0d6c746572 Add grammar registry as an injected dependency of Project 2017-11-02 12:24:11 -07:00
Max Brunsfeld
1a7ea3322e 🎨 project-spec.js 2017-11-02 12:13:31 -07:00
hansonw
303cf30b51 Allow directory providers to implement onDidChangeFiles for custom pathwatchers 2017-11-02 11:43:33 -07:00
Jason Rudolph
4db60e34b8 👔 Fix linter error: "Arrow function should not return assignment." 2017-10-18 20:13:55 -04:00
Jason Rudolph
49655a97c8 🎨 2017-10-18 20:10:24 -04:00
Jason Rudolph
6e78281a73 🎨 Prefer fat arrow function syntax 2017-10-18 19:54:51 -04:00
Jason Rudolph
498d7c90eb Rewrite code to no longer use __guard__ 2017-10-18 19:54:51 -04:00
Jason Rudolph
db115d3ab8 Remove unnecessary code created because of implicit returns 2017-10-18 19:54:51 -04:00
Jason Rudolph
61b228d8a0 Remove unnecessary use of Array.from 2017-10-18 19:54:51 -04:00
Jason Rudolph
c632e6ca58 ☠☕ Decaffeinate spec/project-spec.coffee 
Apply results of running:

```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/project-spec.js

$ standard --fix spec/project-spec.js
```
 2017-10-18 19:54:51 -04:00