Actually add this to the rpm spec file, as was originally intended in
https://github.com/atom/atom/pull/25541.
This helps the bug report feature of the "notifications" package
include more system info on Linux systems -- if /usr/bin/lsb_release
is available, it will be called to gether some basic OS info to add to
the bug report info.
Fixes#23560.
lsb-core-noarch pulls in a lot of unnecessary dependencies and shouldn’t be used anymore.
Instead, only actual dependencies (in this case lsb_release) should be required.
Fedora's script tries to coerce all shebangs
to point to exact, system-provided binaries.
For example: `#!/usr/bin/env sh` becomes `#!/usr/bin/sh`.
Starting with Fedora 30, the script errors out when it encounters
ambiguous, versionless `python` in shebangs.
(`python2` and `python3` are allowed.)
For example, this shebang causes an error: `#!/usr/bin/env python`.
---
Disable this script for two reasons:
1) Fedora users should be able to build Atom without errors.
2) Consistent shebangs across builds of Atom on Ubuntu and Fedora.
See: https://github.com/atom/atom/issues/21937 for more details.
Fixes: https://github.com/atom/atom/issues/21937
Linux icons are now only copied for build process, not for install
process. They should be ignored for all platforms except RPM package
build on Linux.
This is so that the atom.desktop file will be able to find the
"atom" icon when requested. This adds the dependency of ImageMagick
to convert atom.png to varying resolutions, although, only during
the rpm build process (not during actual install). So the result
is ultimatly no different for the end user.
Also, fixed an absolute path from the rpm build process and made
it relative. It was hardcoded in the spec file to
"/tmp/atom-build/Atom/*", so builds that were made elsewhere would
have broken when attempting to package into an rpm. Now rpm packaging
should work from a build made anywhere. Also needed to modify
script/mkrpm so that it copies the build files in such a way that
they can more easily be dealt with in the spec file in a relative
way.
This makes Atom a better desktop citizen relocating to where the usual install
directory is (like on the debian package) and also fix the icon using absolute
paths, breaking icon-themes.
