79 Commits

Author SHA1 Message Date
sadick254
e6368a566d Pass safeMode and devMode on reopening a project
Resolves: #19310
2021-05-14 11:42:22 +03:00
Amin Yahyaabadi
a68663ef48 explicit capture option in addEventListener (#21562)
Based on the docs true is equal to {capture: true}

> In older versions of the DOM specification, the third parameter of addEventListener() was a Boolean value indicating whether or not to use capture. Over time, it became clear that more options were needed. Rather than adding more parameters to the function (complicating things enormously when dealing with optional values), the third parameter was changed to an object that can contain various properties defining the values of options to configure the process of removing the event listener.

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Improving_scrolling_performance_with_passive_listeners
2020-11-03 16:20:58 +03:00
Rafael Oleza
58a10a2cc9 Merge branch 'master' into dw-windows-separate-channels 2019-06-26 16:14:12 +02:00
Rafael Oleza
b6644dfad8 Merge branch 'master' into dw-windows-separate-channels 2019-06-25 15:49:34 +02:00
Nathan Sobo
9793c74835 Include the release channel in data posted to Atom.io with crashes 2019-06-24 16:44:01 -06:00
Nathan Sobo
d5604bd328 Assign originalFontSize when workspace is initialized 2019-06-14 11:44:45 -06:00
Rafael Oleza
e213a69a1f Re-apply prettier JS formatter 2019-06-01 00:29:10 +02:00
Rafael Oleza
79f6836349 Merge commit '1d9a4cafcf6cc288d675512db8fd984e13aab869' into dw-windows-separate-channels 2019-06-01 00:28:37 +02:00
Rafael Oleza
975f203dc7 Merge commit '677bbb7f0b8754787ff9e7bfab4602ba82e13b0b' into dw-windows-separate-channels 2019-06-01 00:27:52 +02:00
Rafael Oleza
7f3f040628 Reformat all JS files using prettier 2019-05-31 18:33:56 +02:00
Rafael Oleza
b59d6d838f Add more markers on atom-environment 2019-05-10 17:33:43 +02:00
Winston Liu
dbb6c7b1b6 Merge branch 'master' into wl-open-empty-editor-as-pending 2019-04-27 00:25:00 -04:00
Ash Wilson
f1e0843473 Don't report missing project folder errors twice 2019-04-24 11:34:36 -04:00
Ash Wilson
405304d449 🎨 formatting tweak 2019-04-23 11:19:01 -04:00
Ash Wilson
8126a136cd Read hasOpenFiles to determine whether or not the initial editor should open 2019-04-19 15:50:24 -04:00
Ash Wilson
2abbabdafe Respect "headless" on non-spec windows 2019-04-18 16:18:49 -04:00
Ash Wilson
45770f1fe6 Use isDirectory instead of mustBeDirectory 2019-04-18 16:18:09 -04:00
Ash Wilson
631743f5f4 Rename setRepresentedDirectoryPaths() to setProjectRoots()
Let's keep the naming consistent the whole way up the call chain.
2019-04-18 16:17:53 -04:00
Ash Wilson
952c42c0de Rename initialPaths and representedDirectoryPaths
They're now called initialProjectRoots and projectRoots, which is closer 
to what they actually are.
2019-04-18 16:15:07 -04:00
Ash Wilson
88d7c6dbdd Include now-missing project folders in initial state key computation 2019-01-24 11:33:44 -05:00
Ash Wilson
07dc40362f Flip conditional for clarity 2019-01-24 11:32:39 -05:00
Ash Wilson
02e1ae4b0f Notify about missing project folders 2019-01-24 10:39:50 -05:00
Ash Wilson
f6837d1f97 openLocations() flag to require a path to be an existing directory 2019-01-24 10:19:01 -05:00
Winston Liu
b98b8dfc11 Merge branch 'master' into wl-open-empty-editor-as-pending 2019-01-17 23:22:03 -05:00
Winston Liu
32a007597e Merge branch 'master' into wl-open-empty-editor-as-pending 2019-01-17 23:07:00 -05:00
Ash Wilson
b9bd3713ee Open an untitled buffer when pathToOpen is null or undefined 2019-01-17 08:15:06 -05:00
Ash Wilson
92785ac257 Merge branch 'master' into aw/single-file 2019-01-14 10:22:51 -05:00
Ash Wilson
d725f5e42b 👕 Now that I actually got my linter working 👀 2019-01-04 09:54:36 -05:00
Ash Wilson
6938a31329 Never open the parent directory of a file path 2019-01-03 16:39:09 -05:00
Winston Liu
aa8d3d6ee8 Fix typo in atom.confirm documentation
[ci skip]
2018-12-28 21:04:18 -05:00
Ash Wilson
b64dac8ea3 👕 2018-12-20 20:51:56 -05:00
Ash Wilson
01bd45ef4c When only a file is specified, don't open the parent directory 2018-12-20 15:59:41 -05:00
David Wilson
43faf1ca36 👕 More spaces for the space god 2018-09-17 15:43:29 -07:00
David Wilson
29b04b8a61 Make the channel-qualified Atom title available through atom.getAppName() 2018-09-17 15:43:10 -07:00
Jordan Eldredge
351b624487 Fix unloading serialization test 2018-08-27 10:24:04 -07:00
Jordan Eldredge
57e6927f2a Fix lint 2018-08-27 08:31:11 -07:00
Jordan Eldredge
a9e887976f Remove unload-aborted event
This edge case will be handled by https://github.com/atom/atom/pull/17873/
2018-08-23 16:11:20 -07:00
Jordan Eldredge
9895badff8 Avoid serialization race condition with slow package deactivation
If any package takes longer than one second (the
`saveStateDebounceInterval`) to deactivate, and the unload was triggered
by a key or mouse down, mouse event, you can end up in a situation where
sate is serialized _after_ the packages are deactivated.

The result in a bug where panes, such as the File Tree, will randomly
be closed when you reload or reopen Atom.

This can be reproduced by creating a package that has an artificially
slow `deactivate` method. With such a package enabled, every reload ends
up serializing a state where all panes are closed.

I'm a bit nervous about this exact fix, since we have to track every
place where it's possible for `prepare-to-unload` to be fired, without
the window actually closing.

I handled the only instance I saw, but the logic is complex enough, that
I'm not 100% confident there are not other instances.

If it did happen that `prepare-to-unload` was fired and some other logic
caused the window to not actually close, we could end up in a state
where mousedown/keydown events were no longer causing state to get
serialized.
2018-08-23 14:17:22 -07:00
David Wilson
cd83486c7d Fix isReleasedVersion check in AtomEnvironment 2018-06-28 14:29:09 -07:00
David Wilson
bd5d258d80 Detect any channel name in AtomEnvironment.getReleaseChannel 2018-06-28 12:53:14 -07:00
Ash Wilson
92f6ab599f Pass Config file path to ApplicationDelegate call 2018-03-27 08:56:29 -04:00
Philip Weiss
062dfdea80 address PR comments 2018-03-06 11:06:22 -08:00
Philip Weiss
faf0d78f3e remove console log 2018-03-01 21:00:24 -08:00
Philip Weiss
7ce5b000e4 address more of max's comments 2018-03-01 19:35:59 -08:00
Philip Weiss
48d3677664 update project api names 2018-02-26 15:45:56 -08:00
Philip Weiss
347d547d5f guard against edge cases 2018-02-24 17:58:46 -08:00
Philip Weiss
1483c0c96d add more data passed through with projectSettings 2018-02-24 17:50:18 -08:00
Philip Weiss
e2c480847c atom project open in their own windows and behave more sanely 2018-02-23 17:38:36 -08:00
Philip Weiss
bf6a4e3db4 add .atomProject files 2018-02-18 15:03:00 -08:00
Max Brunsfeld
1d20b8ee1d Start work on routing all config file IO through main process 2018-01-25 20:35:00 -08:00