Benny Born
d790c4bbc2
Apply changes suggested by linter
2021-07-02 18:46:43 +02:00
Benny Born
cf6539b096
Apply changes suggested by linter
2021-07-02 18:41:50 +02:00
Benny Born
ca6a451e58
Update path-watcher.js
...
apply changes suggested by linter
2021-07-02 18:37:58 +02:00
Benny Born
54de31c005
Apply suggestions from code review
...
Co-authored-by: steven nguyen <nguyeste008@students.garlandisd.net >
2021-07-02 18:23:14 +02:00
Benny Born
f08396429e
make sure path is not undefined ( fix #20871 )
2021-07-02 10:17:52 +02:00
Rafael Oleza
7f3f040628
Reformat all JS files using prettier
2019-05-31 18:33:56 +02:00
Rafael Oleza
2139b4b936
Enable prefer-promise-reject-errors eslint rule
2019-05-27 11:11:49 +02:00
Nathan Sobo
770b8fdcf8
Revert "Merge pull request #19244 from atom/ns/notify"
...
This reverts commit b2ecabd527c3bf95194a
2019-05-17 04:10:17 -06:00
Nathan Sobo
4f08da2a98
Revert "Merge pull request #19325 from atom/ns/notify-asar-exclude"
...
This reverts commit da8b1a1a421edf94a240
2019-05-17 04:10:10 -06:00
Nathan Sobo
a952e40b31
Fix @atom/notify's binary path when running within Atom's ASAR archive
...
/cc @rafeca
2019-05-13 12:12:36 -06:00
Nathan Sobo
58dece3d9c
🔥 unused methods
2019-05-09 08:33:36 -06:00
Nathan Sobo
bfdb1fa7b0
Enable 'poll' option for @atom/notify-based fs watching
2019-05-08 13:59:35 -06:00
Nathan Sobo
f1bb55db58
Throw exceptions when there are @atom/notify watcher errors
...
This will surface these errors to users and to our exception reporting
infrastructure to ensure we get feedback on the new backend in the wild.
2019-05-07 13:21:31 -06:00
Nathan Sobo
1d1b45087f
⬆️ @atom/notify@1.1 for improved error handling
2019-05-06 15:42:51 -06:00
Nathan Sobo
5bfbdd2bce
Stop all watchers before attempting to replace directory with file
...
I think that the notify subprocess might be holding a lock on the
watched directory on Windows.
2019-05-03 14:11:59 -06:00
Nathan Sobo
9b39eeacee
Fix lint errors 🙈
2019-05-02 07:40:38 -06:00
Nathan Sobo
508b56da28
Remove logic supporting dynamic switching of path watcher backends
...
The logic is pretty complex and I don't want to take the time to
integrate @atom/notify with it. I left a bunch of stuff commented out in
this commit just in case these changes break the build. I'll do another
pass to delete commented code once we go green.
2019-05-02 07:40:38 -06:00
Nathan Sobo
b313b94748
Shim onDidError method on returned watcher
...
Need to figure out what to do with this for the long-term.
2019-05-02 07:40:38 -06:00
Nathan Sobo
cf053174a2
Eliminate references to undefined watcher variable
2019-05-02 07:40:38 -06:00
Nathan Sobo
f9d9ed8916
Remove top-level construction of a notify Watcher
...
It was actually dead code and is screwing up V8 startup snapshots.
2019-05-02 07:40:37 -06:00
Nathan Sobo
781cb90034
Fix lint error
2019-05-02 07:40:37 -06:00
Nathan Sobo
89a7aa851b
Default to @atom/notify for file system notifications
...
There's still some work to do to make this work on Linux and support
switching between notification back-ends.
2019-05-02 07:40:37 -06:00
Ash Wilson
fc8e12fadb
Merge pull request #16859 from jerry88kim/add-await-remove-unnecessary-param
...
Add 'await' keyword at async function call and remove unnecessary parameter
2018-02-28 10:29:28 -05:00
Ash Wilson
001aada5ac
Merge pull request #16851 from atom/aw-filter-event-paths
...
Test .oldPath and .path on rename events
2018-02-28 08:19:40 -05:00
youngjoo88kim
9d55753ccb
Add 'await' keyword at async function call and remove unnecessary parameter
2018-02-28 18:48:12 +09:00
Ash Wilson
72c30d7e78
Thanks, linter ✨
2018-02-27 21:40:30 -05:00
Ash Wilson
1dab06c4da
Remove redundant filtered declaration
2018-02-27 21:06:37 -05:00
Ash Wilson
b9117c14be
Avoid calling fs.realpath on editors without a path
2018-02-27 17:22:30 -05:00
Ash Wilson
4c8f1fe3ad
There's no modifyEvent there
2018-02-27 17:16:08 -05:00
Ash Wilson
f7f6564b7d
Test .oldPath and .path on rename events
2018-02-27 17:14:41 -05:00
Ash Wilson
cb783fd15c
Use @atom/watcher with a core.fileSystemWatcher setting
2018-02-14 09:29:28 -05:00
Antonio Scandurra
e68a2b1eb9
Replace import and export keywords with require and module.exports
2018-01-19 09:43:55 +01:00
Wliu
4f6e8ed5f3
📝
...
[ci skip]
2017-11-13 18:57:29 +01:00
Nathan Sobo
61b4fc7d29
Actually require @atom/nsfw dependency in path-watcher.js 🤦
2017-11-01 15:32:05 -06:00
Josh Soref
a92178b876
spelling: asynchronous
2017-09-10 15:46:38 +00:00
Ash Wilson
d03e5d9d54
Update documentation references
2017-08-18 15:02:34 -04:00
Ash Wilson
e2c9cc1692
Private diagnostic method to dump the active watchers
2017-08-18 09:08:34 -04:00
Ash Wilson
a0bdc50535
Return a Promise from watchPath
2017-08-17 22:48:03 -04:00
Ash Wilson
fb5f197ae7
Protect against stale NativeWatcher events
2017-08-17 22:47:39 -04:00
Ash Wilson
fc7ecb76d1
:burn: double word
2017-08-07 11:13:03 -04:00
Ash Wilson
f270402c6b
s/type/action/, s/changed/modified/, s/added/created/
2017-08-07 10:04:00 -04:00
Ash Wilson
f623b03157
Documentation touchups
2017-08-07 10:04:00 -04:00
Ash Wilson
ca28f8ac48
Fussing with documentation
2017-08-04 16:30:43 -04:00
Ash Wilson
662e2aaf06
Revisit a bunch of documentation.
2017-08-04 12:55:25 -04:00
Ash Wilson
418fe48bad
Emulate a "filesystem watcher" by subscribing to Atom events
2017-08-03 15:32:40 -04:00
Ash Wilson
318708bb42
wip
2017-08-02 09:50:57 -04:00
Ash Wilson
320664a359
Remove an export I missed
2017-08-02 09:04:33 -04:00
Ash Wilson
c7a47a9e89
Use module.exports to not break Joanna horribly
2017-08-01 16:40:54 -04:00
Ash Wilson
ee9ad53d91
🔥 unused variables
2017-08-01 15:55:08 -04:00
Ash Wilson
ba11070d16
Translate nsfw events to the events we're advertising
2017-08-01 15:08:07 -04:00
