* cleanup TodoElectronIssue for GCM initVector
* cleanup TodoElectronIssue drop manual set of random value for debugging-port
* Remove workaround for slow crypto.randomBytes
* produceCachedData --> script.createCachedData()
* Remove arguments from childProcess.removeAllListeners()
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
the `removeAllListeners` method to no longer remove all listeners for any event
name when no argument is passed:
https://github.com/nodejs/node/pull/20924
This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
workaround when we move to Electron 4.0 to avoid future event handler leaks.
This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
the `removeAllListeners` method to no longer remove all listeners for any event
name when no argument is passed:
https://github.com/nodejs/node/pull/20924
This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
workaround when we move to Electron 4.0 to avoid future event handler leaks.
There seems to be an Electron bug or something where the child process
isn't receiving messages when --eval is used. It isn't necessary anyway
if we we convert task-bootstrap.coffee to vanilla JS.
Previously, our Error.convertStackTrace function was provided by coffeestack,
which only works for coffee-script. This adds a dependency on 'source-map-support',
which works for any source file with inline source maps.
This also refactors the code for registering our compilers (coffee-script,
typescript, and babel) so that caching logic is shared.
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
Old listeners were not cleaned up before new ones were being added
causing the following console message:
warning: possible EventEmitter memory leak detected.
Refs #7033
The arguments variable is not a real array, and gets screwed up when
sending it to the child process. This updates it to send an array
instead.
Thanks to @lackac!
Refs atom/terminal#23.
