Josh Soref
2dc531b23c
spelling: contiguous
2017-09-10 15:46:39 +00:00
Wliu
2088143a90
Fix specs
2017-08-09 12:43:35 -04:00
Antonio Scandurra
f17baf4790
Use scope ids instead of tags
2017-05-05 09:29:30 +02:00
Antonio Scandurra
4df74beba7
Merge branch 'master' into as-deprecate-shadow-dom
2016-10-17 12:06:00 +02:00
Antonio Scandurra
503f31ea6c
Delete unnecessary dependencies in TokenizedBuffer specs
2016-10-12 13:11:34 +02:00
Antonio Scandurra
d393cba75d
Simplify on-demand placeholder line creation and add test coverage
2016-10-12 13:04:03 +02:00
Antonio Scandurra
e317d7d325
Clean up tests
2016-10-12 12:10:34 +02:00
Antonio Scandurra
d3882c165f
🎨
2016-10-12 12:09:28 +02:00
Antonio Scandurra
00f4c7b282
Use TokenizedBuffer.prototype.tokenizedLineForRow conservatively
...
Since this method will now construct a placeholder line, we want to use
it only where necessary to keep memory footprint to a minimum.
2016-10-12 09:04:41 +02:00
Antonio Scandurra
66510ae545
Handle null grammars consistently, building placeholder lines on-demand
...
Previously we were treating the local `NullGrammar` differently from
`atom.grammars.nullGrammar`. These two grammars are conceptually the
same, as the former was created to support editors creation without a
grammar registry.
To keep backwards-compatibility, we also build placeholder lines
on-demand when calling `TokenizedBuffer.prototype.tokenizedLineForRow`.
This ensure that packages relying on the internals of `TokenizedBuffer`
to retrieve syntactic boundaries won't break when the null grammar is
used or large file mode is on.
2016-10-12 09:04:41 +02:00
Max Brunsfeld
d20372a35f
Start on removing placeholder lines in TokenizedBuffer
2016-10-12 09:04:41 +02:00
Antonio Scandurra
901b0b17a3
Fix failing tests
2016-10-07 13:41:00 +02:00
Indrek Ardel
55f3311c01
Remove unused variables
2016-09-26 20:52:13 +03:00
Max Brunsfeld
38849474d0
Merge branch 'master' into ns-mb-detangle-editor
2016-08-10 13:23:32 -07:00
Antonio Scandurra
23f421154e
Delete TokenizedBuffer.prototype.onDidChange
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-10 17:52:49 +02:00
Max Brunsfeld
f3d486eb9c
Merge branch 'master' into ns-mb-detangle-editor
2016-08-02 14:12:18 -07:00
Nathan Sobo
2b5f1bda46
Always seek to specified position in TokenizedBufferIterator
...
Fixes #10350
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-02 12:19:45 -06:00
Max Brunsfeld
e6c83521c9
Move grammar serialization logic to TextEditorRegistry
2016-07-27 13:10:23 -07:00
Max Brunsfeld
caab1dda63
Move grammar-used spec to workspace-spec
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-07-26 15:38:53 -07:00
Max Brunsfeld
d203610986
Set grammar manually in tokenized buffer specs
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-07-26 15:08:59 -07:00
Max Brunsfeld
c0cbb59666
Don't use config in TokenizedBuffer
2016-07-12 14:31:05 -07:00
Wliu
9b70066bed
Fix TokenizedBuffer specs?
2016-05-04 17:28:15 -04:00
Antonio Scandurra
a532000af4
Handle only buffer coordinates in TokenIterator
2016-04-07 13:39:13 +02:00
Antonio Scandurra
bef7539e34
Refactor DisplayBuffer to DecorationManager
...
This commit moves all the remaining concerns not related to decorations
out of `DisplayBuffer` and into `TextEditor`. This means the
`DisplayBuffer` is now free to be renamed to `DecorationManager`.
2016-04-05 18:43:08 +02:00
Antonio Scandurra
544b75c7b0
🔥 💚 Fix TokenizedBuffer specs
2016-04-05 12:19:45 +02:00
Antonio Scandurra
80b956e996
💚 Fix TextDecorationLayer API specs in TokenizedBuffer
2016-04-05 11:39:06 +02:00
Antonio Scandurra
dfed7c4537
Merge branch 'master' into ns-use-display-layers
...
# Conflicts:
# package.json
# src/display-buffer.coffee
# src/text-editor.coffee
# src/tokenized-buffer.coffee
2016-03-10 13:53:14 +01:00
Antonio Scandurra
bea324eae9
🔥 Use just isFoldableAtBufferRow
2016-02-17 15:05:31 +01:00
Antonio Scandurra
90c75fd6da
Delete specs testing previous behavior
...
When emitting the `did-change` event, `updateFoldableStatus` used to extend the
change region up and down to include all the lines that changed their
foldability status because of a buffer change. I assume this was supposed to
invalidate folds that *contained* the change whenever a line was edited in a way
that affected also the previous or subsequent ones.
That information, however, is not being used by `DisplayBuffer`, which does not
alter existing folded regions when they become invalid.
I believe the correct behavior should be to unfold the invalid region and
recompute those screen lines. Nonetheless, it seems reasonable to me to keep the
original (wrong) behavior and not address it in this branch, because it strays
from the original intent of this refactoring.
We should probably fix it once for all in another PR or when
integrating/implementing `DisplayLayer`.
2016-02-17 14:35:22 +01:00
Antonio Scandurra
a613fa5133
Adapt specs to use the new API
2016-02-17 11:17:24 +01:00
Antonio Scandurra
2c71a448b3
Put foldable specs back
2016-02-17 11:04:19 +01:00
Antonio Scandurra
0afa9bb21c
Don't update foldable status, ever
2016-02-17 10:34:21 +01:00
Nathan Sobo
0243a345b7
Merge branch 'master' into ns-use-display-layers
2016-02-09 12:42:57 -07:00
Wliu
5127789a68
Update tokenized buffer spec
2016-02-07 21:26:13 -05:00
Wliu
b4f8bf12cb
💚 Fix Tokenized Buffer spec
2016-02-04 14:34:49 +00:00
Nathan Sobo
d0e29bfc2c
Avoid recursive call to moveToSuccessor, which is blowing the stack
2016-01-26 17:42:28 -07:00
Nathan Sobo
0d55a0bd76
Make TokenizedBuffer conform to text decoration layer interface
2016-01-13 18:22:04 -07:00
Antonio Scandurra
19ff676c7b
Serialize grammar for untitled buffers
2015-12-16 10:35:23 +01:00
Antonio Scandurra
8db49fc08d
✅ Document existing behavior
2015-12-15 17:20:01 +01:00
Antonio Scandurra
a8a9581ef4
🎨 Use only id
2015-12-07 19:57:30 +01:00
Antonio Scandurra
f7a4ef4a84
Deserialize also untitled buffers
2015-12-07 14:47:23 +01:00
Wliu
ecd14f3390
💚 let and var are now storage.type.var.js
...
Refs atom/language-javascript#277
2015-12-02 20:47:27 -05:00
Wliu
3a34a95947
✅ Update TokenizedBuffer specs
2015-11-17 12:47:14 -05:00
Wliu
7db555c96b
✅ Fix core specs
2015-11-06 10:26:36 -05:00
Antonio Scandurra
df2d73a8df
Don't use atom globals in TokenizedBuffer
2015-10-07 15:25:02 -05:00
Nathan Sobo
122bf72c75
Don’t use atom.packages global in TokenizedBuffer
2015-10-07 15:25:00 -05:00
Nathan Sobo
b2359f44a6
Don’t use atom.grammars global in TokenizedBuffer
2015-10-07 15:25:00 -05:00
Nathan Sobo
4f65452902
Don’t use atom.config global in TokenizedBuffer
2015-10-07 15:24:59 -05:00
Nathan Sobo
eb2ace37b4
Move TextEditor construction to Workspace
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-07 15:24:56 -05:00
Nathan Sobo
eb4944b07d
Make bufferRangeForScopeAtPosition work with last column of scope
2015-08-10 14:21:23 -06:00
