Commit Graph

14452 Commits

Author SHA1 Message Date
Lee Dohm
73525a1bcc Merge pull request #11758 from stanfieldr/master
Paste text at cursor instead of beginning of line
2016-05-16 13:07:51 -07:00
Antonio Scandurra
896abe358c Merge pull request #11765 from atom/as-fix-presenter-uncaught-exception
Don't render line-numbers corresponding to lines that need measuring
2016-05-16 14:21:43 +02:00
Antonio Scandurra
c13346a455 Show folded marker in the first screen row of a soft-wrapped buffer row 2016-05-16 11:23:54 +02:00
Antonio Scandurra
b5b324875e Don't render line-numbers corresponding to lines that need measuring
Rendering those line numbers in the gutter isn't useful, and it puts
unneeded pressure to the DOM. In the process of changing
`updateLineNumbersState`, we have also refactored it to stop relying on
row ranges being contiguous. This allows that code path to be:

1. Less error-prone, because we were trying to access rows that weren't
actually rendered, thus potentially throwing errors when measuring
non-contiguous screen rows that weren't visible.
2. Tighter, because we can just iterate over each screen row and ask for
its soft-wrap descriptor.
2016-05-16 10:58:37 +02:00
Robert Stanfield
f36e148acc When using the event editor:copy-selection, it pastes at the cursor
rather than the beginning of the line (see #11542)
2016-05-15 20:45:45 -04:00
Antonio Scandurra
f9039a35f6 Refactor isRowVisible to isRowRendered
There's a distinction to make between rendered and visible rows, and we
were using the former as if it was the latter. In particular, if a tile
is visible, all its rows get rendered on screen, even though they might
not necessarily be visible by the user.
2016-05-14 17:38:49 +02:00
Lee Dohm
a5c6f2746a Add Devtron to the Developer Tools window 2016-05-13 13:50:09 -07:00
Antonio Scandurra
e3790b8f20 📝 Do not mention persistent option for mark...Range methods 2016-05-06 14:11:47 +02:00
Antonio Scandurra
d06da3f470 Reset display layer when editor.atomicSoftTabs changes 2016-05-05 09:10:36 +02:00
Damien Guard
4da23fdc91 Merge pull request #11639 from BrainCrumbz/squirrel-refactor-pieces
🏁 refactor registry and PoSH out of squirrel-update
2016-05-04 14:17:15 -07:00
Antonio Scandurra
ca041384fe Merge pull request #11414 from atom/ns-switch-to-display-layers
Use display layers facility of text-buffer; delete all the code they replace
2016-05-04 20:46:15 +02:00
Damien Guard
ee3425d543 Merge pull request #11323 from clickthisnick/master
Update Grammar In Spec Files
2016-05-04 11:22:37 -07:00
Damien Guard
d3825e87f3 Merge pull request #11642 from atom/dg-buffered-process-options-shell
Fix some Buffered-Process specs, honor options.shell in Atom
2016-05-04 10:19:04 -07:00
Antonio Scandurra
3b46d7f50b Merge branch 'master' into ns-switch-to-display-layers
# Conflicts:
#	src/text-editor.coffee
2016-05-04 18:56:45 +02:00
Damien Guard
c56cbe3ce3 👕 Change fat arrow to thin arrow for linter warning 2016-05-03 16:50:06 -07:00
Josh Abernathy
3781bd2062 Merge pull request #11671 from atom/disentangle-text-editors-global
Remove TextEditor's dependency on the textEditors global
2016-05-03 10:33:41 -04:00
Antonio Scandurra
004bb6122c 🎨 🐎 2016-05-03 13:24:28 +02:00
Antonio Scandurra
36bcb542a8 Don't move down a line if it's the last buffer row 2016-05-03 12:58:59 +02:00
Lee Dohm
72721af3c6 Merge pull request #11478 from atom/ku-prompt-save-as-if-save-fails
Prompt user to save as if save fails
2016-05-02 17:36:56 -07:00
joshaber
9adc822822 Mark text editors as being registered. 2016-05-02 11:32:29 -04:00
Willem Van Lint
73748ef768 Order listeners by reverse registration order 2016-05-01 16:48:09 -07:00
Antonio Scandurra
f4a31261d0 Delete indent guides code from the presenter and the component
…because we're handling that behavior in `TextEditor` and `DisplayLayer`
now.
2016-05-01 11:48:39 +02:00
Antonio Scandurra
1c694df03b Don't show indent guides for mini editors 2016-05-01 11:42:28 +02:00
Antonio Scandurra
4f5efe98ff Overshoot to the nearest character when text nodes are not contiguous 2016-05-01 11:05:14 +02:00
Antonio Scandurra
334b4c1104 Overshoot to the end of the text node when the position cannot be found
...because the only possible scenario when a logical position in a text
node cannot be found is when the requested pixel position is exactly at
the end of the node.
2016-04-30 11:51:54 +02:00
Antonio Scandurra
02d9245c05 Merge branch 'master' into ns-switch-to-display-layers 2016-04-30 11:10:17 +02:00
Antonio Scandurra
005022567b Merge pull request #11348 from atom/wl-drewmnoel-electron
Update Electron to 0.36.12
2016-04-30 09:19:17 +02:00
Antonio Scandurra
5a9bd28912 Merge pull request #11646 from atom/as-persist-state-on-reload
Persist the entire state on reload
2016-04-30 01:36:37 +02:00
Lee Dohm
f6352cb47b Merge pull request #11618 from delliott2016/master
Prompt for ctrl-o defaults to last directory where you opened a file
2016-04-29 10:53:17 -07:00
Lee Dohm
fc04e35621 Merge pull request #11634 from livelazily/get-completed-data
🐛 Wait for connection end to get completed data;
2016-04-29 09:35:16 -07:00
David Elliott
6c9d7ecc28 Remove random space 2016-04-29 08:39:14 -07:00
David Elliott
e2fa948ac8 🐛 Add support for Mac and Open Folder dialog. 2016-04-29 08:20:52 -07:00
Antonio Scandurra
7b2f049cbb 🎨 Refine binary search algorithm 2016-04-29 16:51:51 +02:00
Antonio Scandurra
d1583b46cf Merge branch 'rahatarmanahmed-perf-text-node-binary-search' into ns-switch-to-display-layers 2016-04-29 14:58:42 +02:00
Antonio Scandurra
c5a76d4a7d Persist the entire state on reload
This fixes an annoying problem that prevented the state of marker layers
from being saved when the window was reloaded either via `Cmd+R` in
DevTools or via `Ctrl+Option+Cmd+L` in Atom.

The issue was that we were *always* scheduling `saveState` on an idle
callback: `window.onbeforeunload`, however, doesn't wait for that event
before closing the window, and thus that state was never saved in those
situations.

The solution is to use idle callbacks only during the critical code path
(i.e. on mousedown and keydown), but save it synchronously otherwise.
Saving something to IndexedDB is actually asynchronous too, but it seems
like Chrome fulfills `put` requests that get executed right during
`onbeforeunload`.
2016-04-29 14:41:34 +02:00
Rahat Ahmed
c6bd9bc8c0 Adjustments for @as-cii 2016-04-28 15:28:54 -05:00
Damien Guard
d3ee21941a Fix some specs on Windows and honor options.shell 2016-04-28 12:23:44 -07:00
David Elliott
398ae4491e 🎨 Removed application:open-dev and application:open-safe from new method. 2016-04-28 11:13:07 -07:00
Giuseppe Piscopo
07bf40879d Fix coffeelint error on trailing whitespace 2016-04-28 19:25:54 +02:00
joshaber
2f1268dc7c Move copyPathToClipboard to the default commands. 2016-04-28 11:36:17 -04:00
Josh Abernathy
5ba701f112 Merge pull request #11616 from atom/dont-require-assert
Remove TextEditor's dependency on assert
2016-04-28 10:41:53 -04:00
joshaber
76d8421963 Inline the no-op assert. 2016-04-28 09:50:01 -04:00
joshaber
23023a7a3d Merge branch 'master' into dont-require-assert 2016-04-28 09:48:52 -04:00
Antonio Scandurra
f2a497d591 Don't create folds for empty ranges 2016-04-28 13:43:00 +02:00
Antonio Scandurra
57442781ec Fix bug when positioning cursors after the fold-marker 2016-04-28 13:31:28 +02:00
Giuseppe Piscopo
bebaf1bdb0 extract Windows PowerShell operations from squirrel-update 2016-04-28 09:24:37 +02:00
livelazily
3b5bcf1c0d 🐛 Wait for connection end to get completed data; 2016-04-28 14:27:56 +08:00
joshaber
cd8b28da4d Document why 2016-04-27 22:40:34 -04:00
Giuseppe Piscopo
63c45cc8fd extract Windows registry operations from squirrel-update 2016-04-28 03:20:55 +02:00
Giuseppe Piscopo
77dcf37ee3 extract process spawning from squirrel-update 2016-04-28 03:20:55 +02:00