Commit Graph

284 Commits

Author SHA1 Message Date
Nathan Sobo
e67e8ff0f5 Restore Atom::getLoadSettings and spy on it in window spec
I initially ripped out Atom::getLoadSettings in favor of a mutable
property because window spec was making an assumption that such a
property existed anyway. Since load settings need to be available from
class methods, the instance method just delegates to the class method.
But that means there's no ::loadSettings property to mutate in that
spec. I replaced the former approach with a spy which has the added
advantage of not polluting windowSettings for subsequent specs.
2013-12-13 12:02:48 -08:00
Nathan Sobo
beb2fb08ea Merge branch 'master' into ns-telepathic-atom-global
Conflicts:
	package.json
2013-12-13 09:32:13 -08:00
Nathan Sobo
a564cc66f6 Replace Atom::getLoadSettings with a ::loadSettings property
We assign a value into ::loadSettings anyway in a spec, so there's not
much point leaving it a method. Eventually I'd like to pass all these
settings in when constructing the Atom object and eliminate awareness
of the loadSettings altogether from the Atom global.
2013-12-12 16:33:30 -08:00
Nathan Sobo
ebe77065cc Destroy orphans after each spec 2013-12-12 15:45:16 -08:00
Nathan Sobo
30b0fed60f Remove packageStates from atom state after specs just in case 2013-12-12 15:11:59 -08:00
Nathan Sobo
5f10c48219 Kill double project assignment 2013-12-12 14:40:12 -08:00
Nathan Sobo
23957d7f66 WIP: Make atom global a telepath model
Specs seem to be green but hang on what I'm assuming to be a long GC
pause near the end. I need to investigate what's going on memory wise.
2013-12-12 14:33:50 -08:00
probablycorey
f414c0955b Specs don't prompt to save editors by default. 2013-12-12 10:35:11 -08:00
Nathan Sobo
b61654b52f Upgrade to telepath 0.61.0
This version adds a bunch of reactive primitives and ensures we destroy
documents when they are no longer referenced.
2013-12-06 21:55:57 -08:00
Kevin Sawicki
3ce6176313 Rename rootView to workspaceView 2013-11-26 11:02:53 -08:00
Kevin Sawicki
17be036ff8 Move window.setUpEnvironment to Atom class 2013-11-22 10:13:59 -08:00
Kevin Sawicki
dd9aa2d02f 💄 Remove extra space 2013-11-21 16:08:27 -08:00
Kevin Sawicki
2f46fee1ca Use resource path from load settings 2013-11-21 16:08:27 -08:00
Kevin Sawicki
bc1a743b2f Remove project and rootView from window 2013-11-20 17:23:47 -08:00
Kevin Sawicki
568aa1d396 Remove some package manager shims on atom global 2013-11-20 12:48:05 -08:00
Kevin Sawicki
c9e68ab044 Remove window.config shim from spec helper 2013-11-20 12:48:04 -08:00
probablycorey
bf05ddb958 🔫
I screwed up a rebase, this nasty commit is the result.
2013-11-19 15:15:12 -08:00
probablycorey
756c2be64a Replace editor instance variables with editorView 2013-11-19 14:57:35 -08:00
probablycorey
aaa82e23da Rename Editor to TextEditorView 2013-11-19 14:34:20 -08:00
probablycorey
02f40688e2 Merge remote-tracking branch 'origin/master' into cj-keymap-cleanup 2013-11-15 13:53:42 -08:00
probablycorey
cb8e378af6 Use keyBinding in place of binding in method names 2013-11-15 13:49:17 -08:00
probablycorey
dcccde8f3f Clone default keybindings in specs 2013-11-15 13:32:31 -08:00
probablycorey
809a02ca10 Clone keyBindings by default 2013-11-15 11:54:09 -08:00
Kevin Sawicki
6290c19264 Set up spec Project as telepath model 2013-11-15 11:17:32 -08:00
probablycorey
bd8e19bce7 Update keymap in spec-helper 2013-11-15 10:43:20 -08:00
probablycorey
4852ba6d95 Don't store binding sets, instead store a keyBinding array 2013-11-15 10:21:38 -08:00
Kevin Sawicki
fb02917adf Set defaults after spying on save 2013-11-11 11:43:42 -08:00
Kevin Sawicki
b801c3ce56 Set core/editor config defaults in spec helper 2013-11-11 11:04:24 -08:00
Kevin Sawicki
d4b5303983 Remove remaining package paths from Config class 2013-11-11 10:33:09 -08:00
Kevin Sawicki
3539288a1e Remove incorrect atom. prefix 2013-11-11 09:29:29 -08:00
Kevin Sawicki
a377a49004 Use atom.config instead of window.config 2013-11-11 09:16:44 -08:00
Kevin Sawicki
9f8a8139e0 Use atom.syntax instead of window.syntax 2013-11-11 08:53:52 -08:00
Kevin Sawicki
9b3edc89a6 Use atom.keymap in specs 2013-11-11 08:43:14 -08:00
Kevin Sawicki
bff47e10f4 Remove dimension shims on window 2013-11-11 08:43:14 -08:00
Matt Colyer
ec761d00ef Remove modified check on fixture file 2013-11-04 14:53:43 -08:00
Matt Colyer
c9eebcf00a Fixture hashes depend on line returns 2013-11-01 15:15:17 -07:00
Kevin Sawicki
ebb7a2637a Upgrade to fs-plus@0.3.0 2013-11-01 08:46:03 -07:00
Nathan Sobo
7d64cd179e Always mock atom.packages.resolvePackagePath
…instead of only in package specs. This allows specs that assume it is
mocked to work correctly when we run the full spec suite. Namely, the
settings-view specs had an issue with this.
2013-10-31 17:08:40 -06:00
Matt Colyer
9ea2bfa920 Clear menu template to avoid separator duplication 2013-10-18 11:34:19 -07:00
Matt Colyer
5541875965 Don't append duplicate menu items
Fixes #995
2013-10-18 10:20:03 -07:00
Kevin Sawicki
d6452c37d8 Clear menu template after each spec run
This is needed since packages don't destroy menus when deactivated
so the template currently grows larger each time a package is activated.
2013-10-17 16:31:15 -07:00
Kevin Sawicki
0b22d99fad Store spec directory on required specs
This allows the project to be configured based on the spec being
run.
2013-10-14 11:15:40 -07:00
Kevin Sawicki
63f39d84a3 Load package relative to the package's spec directory 2013-10-14 10:33:21 -07:00
Matt Colyer
4d415d3ca9 Generate evil file fixtures depending on platform 2013-10-11 14:09:17 -07:00
Matt Colyer
12b42bf459 Initialize AtomPackage attributes earlier
This should make our package loading process a bit more robust.
2013-10-11 12:49:31 -07:00
Matt Colyer
abd8bd1253 Handle errors in package.json gracefully 2013-10-11 12:49:31 -07:00
Matt Colyer
ffdfe63a4e Add specs 2013-10-08 16:23:34 -07:00
Kevin Sawicki
0033c9659f 💉 directory dependencies into Config 2013-10-07 16:12:00 -07:00
Kevin Sawicki
db47d02c3c Add fixture packages to atom.packages.packageDirPaths 2013-10-07 16:11:59 -07:00
Kevin Sawicki
5895da3d6f Store dimensions when spec window is unloaded
Refs #918
2013-10-02 17:16:19 -07:00