Commit Graph

6063 Commits

Author SHA1 Message Date
Max Brunsfeld
395ffde7a1 Merge pull request #9131 from atom/mb-fix-config-unset
Fix setting default values in config
2015-10-14 09:51:53 -07:00
Antonio Scandurra
582fa571b8 📝 Better spec description 2015-10-14 16:20:42 +02:00
Antonio Scandurra
6b01811d20 Avoid stack overflow when scrolling with non-integer values
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
2015-10-14 16:10:12 +02:00
Max Brunsfeld
47961a8e6b Fix setting default values in config 2015-10-13 11:00:53 -07:00
Ross Allen
41984a2317 Add onDidStopChangingActivePaneItem for async callbacks
`onDidChangeActivePaneItem` is called synchronously when the active pane
item changes, and several non-critical actions preform work on that
event. Critical UI feedback, like changing the active tab, needs to
happen synchronously, but most other functionality should be run
asynchronously.
2015-10-12 10:24:07 -07:00
Antonio Scandurra
428f0db75b 🔥 2015-10-06 11:02:36 +02:00
Antonio Scandurra
61892f932b Use cached text nodes instead of NodeIterator 2015-10-06 10:43:32 +02:00
Antonio Scandurra
c79cc87172 Prepare DOMElementPool to account for text nodes 2015-10-06 10:02:04 +02:00
Antonio Scandurra
b31d3d1a3f Revert "🐎 Faster line number calculation"
This reverts commit e04aef0af3.
2015-10-06 09:16:29 +02:00
Antonio Scandurra
d5dac3459b Merge branch 'master' into as-double-reflow-measurements 2015-10-06 08:36:22 +02:00
Max Brunsfeld
467c89bfb3 In integration tests, handle executable path with spaces in it 2015-10-05 16:49:35 -07:00
Nathan Sobo
ddb08d0c46 Avoid redundant onDidAddPaneItem notifications
Refs #9012
2015-10-05 12:34:49 -06:00
Antonio Scandurra
e04aef0af3 🐎 Faster line number calculation 2015-10-05 17:36:28 +02:00
Antonio Scandurra
1c56c3f951 🎨 2015-10-05 16:32:51 +02:00
Antonio Scandurra
0bee6a0cc1 Avoid invalidating state when clearing screen rows to measure 2015-10-05 16:10:58 +02:00
Antonio Scandurra
581ffb1360 🐎 Avoid to measure invisible lines when dragging 2015-10-05 16:05:17 +02:00
Antonio Scandurra
3df6ed8405 Merge branch 'master' into as-double-reflow-measurements 2015-10-03 15:53:34 +02:00
Antonio Scandurra
beb7896234 Enable subpixel font scaling
For certain font sizes, enabling `textRendering: optimizeLegibility` caused a
bunch of measurement-related issues. You can reproduce it by setting the following in your stylesheet:

```
atom-text-editor {
  font-size: 14px;
  text-rendering: optimizeLegibility;
}
```

Although I wanted to defer subpixel font scaling to a later moment, it seems
like Chrome needs to have it enabled in order to properly support the
"legibility" path for text rendering. (I guess this is part of the reason why
the Chromium team enabled it by default at some point in the past.)
2015-10-02 18:14:09 +02:00
Antonio Scandurra
b7e373fdca 🐛 Correctly measure RTL characters
This will fix also the "hidden cursor" issue we were experiencing.

/cc: @izuzak
2015-10-02 12:51:10 +02:00
Antonio Scandurra
2ffa7da59e 🐎 Remove rows to measure in the next frame 2015-10-02 12:38:19 +02:00
Antonio Scandurra
33523751ea Thoroughly test LinesYardstick interactions 2015-10-01 18:34:41 +02:00
Max Brunsfeld
2cd4826e62 Merge pull request #8862 from phord/dot-git-files
🐛 Teach Atom to read .git files
2015-10-01 09:32:49 -07:00
Phil Hord
212886817e Clean up *nix-specific paths in spec
There remain a few others in other specs, but someone who can test
them reliably should clean those up.
2015-10-01 09:41:24 -04:00
Antonio Scandurra
e94ff33d83 🐛 Exclude invalid tiles 2015-10-01 12:58:02 +02:00
Antonio Scandurra
116f92d816 🐎 Mark soft-wrapped lines in TokenizedLine 2015-10-01 11:15:55 +02:00
Antonio Scandurra
243dea1a1c 🎨 Move pixel-related code to LinesYardstick
* 🔥 Remove useless 'scoped char width' methods
2015-10-01 11:03:25 +02:00
Antonio Scandurra
2b6973d4b1 Fix a 🐛 where some invalid lines were being measured 2015-09-30 17:44:43 +02:00
Antonio Scandurra
bca3be32e6 Avoid to call ::prepareScreenRows explicitly 2015-09-30 16:23:49 +02:00
Antonio Scandurra
e43e1ed22e Merge branch 'master' into as-double-reflow-measurements
# Conflicts:
#	src/text-editor-presenter.coffee
2015-09-30 12:40:55 +02:00
Antonio Scandurra
214f42b2e7 🎨 Unify ::updateScroll... and ::commitPendingScroll... 2015-09-30 12:32:07 +02:00
Antonio Scandurra
0f8041c611 Merge branch 'master' into as-fix-deprecations 2015-09-30 10:23:38 +02:00
Antonio Scandurra
cc98cab917 Better rows per page calculation 2015-09-30 09:17:43 +02:00
Antonio Scandurra
5cfc5b67ae Allow listening for TextEditorElement events before attaching it
Fixes atom/wrap-guide#43

/cc: @maxbrunsfeld
2015-09-30 09:09:33 +02:00
Antonio Scandurra
5dcfea0a82 💚 Fix TextEditorPresenter specs 2015-09-29 16:11:59 +02:00
Antonio Scandurra
5270a1da1c Use LinesYardstick in pixelPositionForScreenPosition 2015-09-29 15:44:05 +02:00
Antonio Scandurra
b481250757 Always render the longest screen row 2015-09-29 11:41:44 +02:00
Antonio Scandurra
49577313e4 Remove yardstick to start with a clean slate 2015-09-29 10:25:54 +02:00
Antonio Scandurra
a49fe3140f Merge branch 'master' into as-double-reflow-measurements 2015-09-29 09:09:54 +02:00
Antonio Scandurra
550a1c7922 Fail on Travis when deprecated methods are used 2015-09-29 08:52:03 +02:00
Antonio Scandurra
e648d880ed Manually set rows per page in the model 2015-09-29 08:24:28 +02:00
Max Brunsfeld
d55398b77b Use key-path-helpers module instead of underscore-plus 2015-09-28 17:27:15 -07:00
Max Brunsfeld
889a3e5205 Merge branch 'beta' 2015-09-28 09:34:12 -07:00
Antonio Scandurra
aec72e5ed6 Fix soft-wrapping spec 2015-09-28 15:43:13 +02:00
Antonio Scandurra
47b6f043e9 Merge branch 'master' into as-double-reflow-measurements
# Conflicts:
#	src/text-editor-presenter.coffee
2015-09-28 11:19:56 +02:00
Antonio Scandurra
575d79acce Merge pull request #8604 from lpommers/pressing-esc-on-multiple-cursors-returns-to-original-cursor-or-selection
Pressing esc on multiple cursors returns to original cursor or selection
2015-09-28 10:01:42 +02:00
Wliu
7c0a656036 🔥 Remove hardcoded Makefile tab behavior 2015-09-26 15:54:51 -04:00
Antonio Scandurra
f17767a2bc Merge pull request #8905 from atom/as-display-buffer-logical-coordinates
Use logical coordinates in DisplayBuffer
2015-09-26 18:05:10 +02:00
Antonio Scandurra
a870252702 🔥 Remove unused code 2015-09-26 18:04:15 +02:00
Max Brunsfeld
a3a6c7cd3c Reuse compile cache between integration tests
This makes integration tests much faster and less resource-intensive
2015-09-25 17:39:36 -07:00
Antonio Scandurra
a96af2465f 🎨 Use ::setWidth and ::setHeight 2015-09-25 13:26:30 +02:00