Commit Graph

151 Commits

Author SHA1 Message Date
Ben Ogle
0588e14850 Only notify when changed key path is really sub path of observed path
Closes #3775
2014-10-13 14:25:55 -07:00
Ben Ogle
7f1947f7b2 💄 2014-10-13 12:47:19 -07:00
Ben Ogle
55c9b42a74 Clarity 2014-10-13 12:45:43 -07:00
Ben Ogle
201345ec5d Allow for optimization of config::get 2014-10-10 12:21:41 -07:00
Ben Ogle
8910dd1a11 Update to not new format from propertiesForSource 2014-10-08 16:01:42 -07:00
Ben Ogle
a3bbbc19b5 Read and write scoped settings from the user’s config 2014-10-08 16:01:42 -07:00
Ben Ogle
062fa29895 addRawScopedValue -> setRawScopedValue 2014-10-03 11:57:50 -07:00
Ben Ogle
4e3c8406ee Clean up docs 2014-10-03 11:57:35 -07:00
Ben Ogle
47d5b46a1d Fix warnings from schema incorrectness 2014-10-03 11:42:45 -07:00
Ben Ogle
a711e908d5 💄 2014-10-03 10:46:57 -07:00
Ben Ogle
2475e1a9a6 📝 Update docs for scoped settings 2014-10-03 10:46:57 -07:00
Ben Ogle
f724c7fca8 Implement observing on scoped properties 2014-10-03 10:46:57 -07:00
Ben Ogle
f8a3ae6104 Pull observing out into special methods for global config 2014-10-03 10:46:57 -07:00
Ben Ogle
899929a1ce addScopedDefaults -> addScopedSettings 2014-10-03 10:46:57 -07:00
Ben Ogle
e5d67bb2ff Can remove the clearing of scoped properties
Config is being created on each spec run!
2014-10-03 10:46:57 -07:00
Ben Ogle
3732bdf1e9 Ugh, add settingsForScopeDescriptor back
It’s used by language mode and autocomplete for different things
2014-10-03 10:46:57 -07:00
Ben Ogle
aedf02a3e3 Remove +default junk 2014-10-03 10:46:57 -07:00
Ben Ogle
b1f8c6a6e8 Remove special method for language mode 2014-10-03 10:46:57 -07:00
Ben Ogle
a8fad6a0fb Use disposables for removing properties 2014-10-03 10:46:13 -07:00
Ben Ogle
82990cfc77 rename method 2014-10-03 10:46:13 -07:00
Ben Ogle
dd05c6cec1 Syntax calls into atom.config for scoped properties 2014-10-03 10:46:13 -07:00
Ben Ogle
7a5054027e Shift the args before coercing the value 2014-10-03 10:46:13 -07:00
Ben Ogle
778d9fafc5 fix value and default value object checks 2014-10-03 10:46:13 -07:00
Ben Ogle
38e889b7d8 Reorganize private methods into section 2014-10-03 10:46:13 -07:00
Ben Ogle
356f4bec7c Basic scoped settings in Config works 2014-10-03 10:46:13 -07:00
Ben Ogle
8533286114 Move internal things into an internal section 2014-10-03 10:46:13 -07:00
Ben Ogle
72f40ae647 Fix 📝 2014-10-01 14:25:07 -07:00
Ben Ogle
57603b3a00 Fix config resetting all values when one changes.
Closes atom/settings-view#257
2014-10-01 09:37:25 -07:00
Kevin Sawicki
f84cb83e1e Use -> arrows 2014-09-30 14:02:10 -07:00
Ben Ogle
c74b1b971d Use isPlainObject() 2014-09-30 12:44:44 -07:00
Ben Ogle
54af7eced1 Handle empty config files + reset settings before applying user config
Closes #3664
2014-09-30 12:39:07 -07:00
Ben Ogle
b54deccfae String type must be strict.
It makes sense to coerce from more general -> more specific data types.
eg. string -> int, etc. But coercing the other way is problematic
in the case of chaining because the more general type will swallow the
specific type. eg. Setting `false` on type: [‘string’, ‘boolean’] will 
coerce the boolean to a string, and will never allow the value to be
a boolean.
2014-09-29 16:09:49 -07:00
Ben Ogle
f3ed3dc357 Fix doc to match implementation 2014-09-29 16:09:49 -07:00
Ben Ogle
1b506673bb 📝 update 2014-09-29 16:09:49 -07:00
Ben Ogle
5651ebbb48 always set, only emit when values differ 2014-09-29 16:09:49 -07:00
Ben Ogle
98290b31ab Rework defaults and user loading to notify per path 2014-09-29 16:09:48 -07:00
Ben Ogle
08b138997d Change the onDidChange / observe arguments
Support passing no keypath
2014-09-29 16:09:48 -07:00
Ben Ogle
1f7aee00ac function names to the imperative mood
http://en.wikipedia.org/wiki/Imperative_mood
2014-09-29 16:09:48 -07:00
Ben Ogle
3977596084 Validators -> enforcers 2014-09-29 16:09:48 -07:00
Ben Ogle
804d0d9911 Doc 💄 2014-09-29 16:09:48 -07:00
Ben Ogle
4e1d13ceea is plain object 2014-09-29 16:09:48 -07:00
Ben Ogle
ef19e925e9 Strings accept numbers too 2014-09-29 16:09:48 -07:00
Ben Ogle
11fad1bd12 Moar 📝 2014-09-29 16:09:48 -07:00
Ben Ogle
1408d69641 Fix up message strings 2014-09-29 16:09:48 -07:00
Ben Ogle
96207ffbdb Update error messages to read good 2014-09-29 16:09:47 -07:00
Ben Ogle
fcf2143e70 isPlainObject 2014-09-29 16:09:47 -07:00
Ben Ogle
452e34db90 Remove deprecations for push / remove / unshift at keypath 2014-09-29 16:09:47 -07:00
Ben Ogle
8b39ce77b1 We’ll always have validators for a type. No check 2014-09-29 16:09:47 -07:00
Ben Ogle
94d470002b Update doc strings 2014-09-29 16:09:47 -07:00
Ben Ogle
33d4ace8e9 📝 more docs for Config 2014-09-29 16:09:47 -07:00