Nathan Sobo
66319ca9c0
Merge pull request #2801 from atom/ns-react-fix-jitter
...
Fix jitter in React editor
2014-07-02 10:34:01 -06:00
Nathan Sobo
17fa580ecd
Ignore 'scroll' events when an update is pending
...
This prevents feedback loops where we handle stale 'scroll' events
for scrolls requested in the model layer. It prevents jitter when
autoscrolling with the cursor.
2014-07-02 10:11:35 -06:00
Nathan Sobo
9508909a9f
Don't defer updates with setImmediate in animation frames
...
I previously thought this was okay, but now I'm experiencing jitter when
scrolling with the trackpad when updates are deferred, and the frames
seem jagged. So this commit restores a synchronous approach to display
updates whenever we use animation frames.
2014-07-02 09:26:24 -06:00
Ben Ogle
1fa6661efd
Remove the awkward _.pick
2014-07-01 11:48:36 -07:00
Ben Ogle
dcb0d9b039
Update editor component specs
2014-07-01 11:41:44 -07:00
Ben Ogle
718e1228bd
Add checks for the change event
2014-07-01 11:32:04 -07:00
Ben Ogle
3e57fb8e9a
💄 naming
2014-07-01 10:59:42 -07:00
Ben Ogle
de0e945c5c
More specs in tokenized buffer testing empty line retokenizing
2014-07-01 10:54:37 -07:00
Ben Ogle
65c2f26656
Little note 📝
2014-07-01 10:54:36 -07:00
Ben Ogle
8ca709eb6a
Fix spec name
2014-07-01 10:54:36 -07:00
Ben Ogle
43e88f6515
Invalidate whitespace lines when their indent level changes
...
Refs #2376
2014-07-01 10:54:36 -07:00
Ben Ogle
d97eacc2f9
Add isOnlyWhitespace()
2014-07-01 10:54:36 -07:00
Ben Ogle
06d06d10e0
💄
2014-07-01 10:45:13 -07:00
Ben Ogle
44b95fc637
Emit errors from the out of process searches
2014-07-01 10:44:30 -07:00
Nathan Sobo
e93e4e9333
Autoscroll to the last cursor in model when inserting text
...
Fixes #2787
2014-07-01 11:37:17 -06:00
Nathan Sobo
d4a7bff525
Merge pull request #2608 from philschatz/ps-dedupe-context-menu
...
remove duplicate context menu entries
2014-07-01 11:08:18 -06:00
Nathan Sobo
a99bde4e2d
Reassign scrollTop if deleting lines decreases the max scrollTop
...
Fixes #2725
2014-07-01 09:01:04 -06:00
Nathan Sobo
15ca3e2a40
Match existing editor's behavior for .cursor-line class
2014-06-28 15:39:22 +01:00
Nathan Sobo
ea9f5eb1c7
💄 Unify specs for all line decorations
2014-06-28 15:39:22 +01:00
Nathan Sobo
7f70b41696
Update the specs for .cursor/selection-line decorations
2014-06-28 15:39:22 +01:00
Nathan Sobo
bd238d6885
Add specs for gutter decoration options
...
- onlyHead
- onlyEmpty
- onlyNonEmpty
2014-06-28 15:39:22 +01:00
Nathan Sobo
fa7e388352
Add 'onlyEmpty' and 'onlyNonEmpty' decoration options
2014-06-28 15:39:21 +01:00
Nathan Sobo
a2b90cd501
Add 'onlyHead' option for decorations
...
It only decorates the head position of the decoration's marker.
2014-06-28 15:39:21 +01:00
Nathan Sobo
71fb063a67
Un-f
2014-06-28 15:24:24 +01:00
probablycorey
e7aef25f1f
Update tokenized buffer specs
2014-06-27 10:18:04 -07:00
probablycorey
071b391994
Describe surrogate pair as UTF-8 surrogate pair
2014-06-27 10:17:28 -07:00
Ben Ogle
7179bc5af1
Merge pull request #2738 from atom/bo-fix-max-scroll-width
...
Fix max scroll width in react editor
2014-06-25 18:16:32 -07:00
Nathan Sobo
3bf0c73170
Assign line width explicitly to prevent full screen repaints
...
Fixes #2746
2014-06-25 19:13:50 -06:00
Nathan Sobo
eb84737109
Fix specs for use of setImmediate instead of nextTick in requestUpdate
2014-06-25 18:38:06 -06:00
Nathan Sobo
63e8099088
Allow successive accented characters to be inserted in React editor
...
Refs #2732
Because we're only checking the length of the input element's selection
in the React editor on textinput events and not also its content, we
were mistaking some IME compositions as accented character menu
insertions. Clearing the content of the input on 'compositionend'
prevents this issue.
2014-06-25 18:19:53 -06:00
Ben Ogle & Nathan Sobo
f739dce210
Only recompute scroll width once for each batch of measured chars
2014-06-25 15:26:13 -07:00
Ben Ogle & Nathan Sobo
77389b0518
Update scrollWidth when the max line length / default char width changes
2014-06-25 15:26:13 -07:00
Ben Ogle
196f64d846
Fix specs
2014-06-25 15:26:13 -07:00
Ben Ogle
b7d8e581ee
Merge pull request #2727 from atom/bo-subscribe-to-marker-changes
...
Subscribe to marker changes
2014-06-24 11:15:47 -07:00
Ben Ogle
396b21bc04
Fix specs failures caused by making lines 100% width
2014-06-24 10:32:48 -06:00
Kevin Sawicki
1c2e997415
Merge pull request #2700 from atom/bo-grammar-preload
...
Preload grammars on deserialization
2014-06-24 08:26:57 -07:00
Kevin Sawicki
148b691734
Test grammars included across multiple packages
2014-06-24 08:14:11 -07:00
Ben Ogle
ccada33d57
Remove nextTick in spec
2014-06-23 22:27:40 -06:00
Ben Ogle
1d9514ca81
Don't call nextTick within requestAnimationFrame
...
This seems to be causing stutter when scrolling on the GPU. When I don't
use nextTick when requesting animation frames, the problem seems to go
away. Maybe there's some issue with the integration between the Node
and Chromium event loops plus sending things to the compositor.
/cc @benogle
2014-06-23 22:21:28 -06:00
Kevin Sawicki
2e424baf2a
Use correct expected call count
2014-06-23 17:41:33 -07:00
Kevin Sawicki
0547d5a78b
Assert grammars are sync loaded on deserialize
2014-06-23 17:36:14 -07:00
Kevin Sawicki
0a54233ef0
Merge branch 'master' into bo-grammar-preload
2014-06-23 17:05:48 -07:00
Kevin Sawicki
e11785ce98
Serialize packages names in Workspace
2014-06-23 16:56:46 -07:00
Kevin Sawicki
b1d7de8d43
Add spec for serializing active grammars
2014-06-23 16:41:46 -07:00
Ben Ogle
f381abcbad
Re-render when a marker changes
...
fixes #2705
2014-06-23 16:00:36 -07:00
Ben Ogle
7139fd9f98
Conditionally render the gutter for the showLineNumbers option
...
Fixes #2707
2014-06-23 15:22:16 -07:00
Nathan Sobo
b9a3eca091
Correcly handle folds that end where other folds begin
...
Fixes #2247
2014-06-23 11:29:14 -06:00
probablycorey
9a5da3c27e
Add next tick call
2014-06-23 09:13:39 -07:00
probablycorey
43cb9af4a4
Add editor-event spec
2014-06-23 08:51:17 -07:00
Nathan Sobo
7c356d2592
Revert "Render highlights on their own layer to avoid GPU artifacts"
2014-06-21 01:58:11 -06:00
