Antonio Scandurra
0bee6a0cc1
Avoid invalidating state when clearing screen rows to measure
2015-10-05 16:10:58 +02:00
Antonio Scandurra
2ffa7da59e
🐎 Remove rows to measure in the next frame
2015-10-02 12:38:19 +02:00
Antonio Scandurra
e94ff33d83
🐛 Exclude invalid tiles
2015-10-01 12:58:02 +02:00
Antonio Scandurra
2b6973d4b1
Fix a 🐛 where some invalid lines were being measured
2015-09-30 17:44:43 +02:00
Antonio Scandurra
e43e1ed22e
Merge branch 'master' into as-double-reflow-measurements
...
# Conflicts:
# src/text-editor-presenter.coffee
2015-09-30 12:40:55 +02:00
Antonio Scandurra
214f42b2e7
🎨 Unify ::updateScroll... and ::commitPendingScroll...
2015-09-30 12:32:07 +02:00
Antonio Scandurra
cc98cab917
Better rows per page calculation
2015-09-30 09:17:43 +02:00
Antonio Scandurra
5dcfea0a82
💚 Fix TextEditorPresenter specs
2015-09-29 16:11:59 +02:00
Antonio Scandurra
b481250757
Always render the longest screen row
2015-09-29 11:41:44 +02:00
Antonio Scandurra
49577313e4
Remove yardstick to start with a clean slate
2015-09-29 10:25:54 +02:00
Antonio Scandurra
e648d880ed
Manually set rows per page in the model
2015-09-29 08:24:28 +02:00
Antonio Scandurra
47b6f043e9
Merge branch 'master' into as-double-reflow-measurements
...
# Conflicts:
# src/text-editor-presenter.coffee
2015-09-28 11:19:56 +02:00
Antonio Scandurra
0e72593a0c
Enforce a 'last scroll wins' model for batched scrolls
2015-09-25 10:43:20 +02:00
Antonio Scandurra
d65b5d1793
Revert "Maintain scroll history"
...
This reverts commit 2e6bb53303
2015-09-25 10:31:48 +02:00
Antonio Scandurra
2e6bb53303
Maintain scroll history
2015-09-24 16:25:58 +02:00
Antonio Scandurra
365a586466
Ensure realScroll... is up to date with scroll...
2015-09-24 15:16:40 +02:00
Antonio Scandurra
1f81c633e0
Serialize state using logical coordinates
2015-09-24 09:01:51 +02:00
Antonio Scandurra
0f7d88c77b
💚 Fix remaining failures in TextEditorPresenter
2015-09-23 16:14:15 +02:00
Antonio Scandurra
b198acc995
Fix soft wrapping when editorWidthInChars is used
2015-09-23 15:34:44 +02:00
Antonio Scandurra
fffcfb3405
Save scroll positions in the model to serialize 'em
2015-09-23 15:34:44 +02:00
Antonio Scandurra
60fdd3793f
Stop reporting scroll positions to the model
2015-09-23 15:34:44 +02:00
Antonio Scandurra
8463d5c59d
Start porting DisplayBuffer specs
2015-09-23 15:34:43 +02:00
Antonio Scandurra
d3b1d309ba
Make sure scroll positions are integers
2015-09-23 15:34:41 +02:00
Antonio Scandurra
ddd7aacd9d
💚 Fix TextEditorComponent specs
2015-09-23 15:34:22 +02:00
Antonio Scandurra
68e2d7e7e4
wip
2015-09-22 17:30:51 +02:00
Antonio Scandurra
b5a59017d5
wip
2015-09-22 16:20:15 +02:00
Antonio Scandurra
13f82280a0
💚 Fix presenter specs
2015-09-21 11:05:35 +02:00
Antonio Scandurra
4318de43c9
wip
2015-09-20 21:02:25 +02:00
Antonio Scandurra
af41b71cd8
Redesign LinesYardstick
2015-09-20 12:10:09 +02:00
Antonio Scandurra
7fafdbb6ab
Implement ::getStateForMeasurements(screenRows)
2015-09-18 14:00:04 +02:00
Antonio Scandurra
03507f7be3
Revert previous commit
2015-09-18 12:25:01 +02:00
Antonio Scandurra
b773b60c7b
🐛 Avoid creating a useless extra tile
2015-09-18 12:03:00 +02:00
Antonio Scandurra
96de78f264
🔥 Avoid computing top for line and line numbers
2015-09-18 11:36:18 +02:00
Antonio Scandurra
96d4bdb173
Revert changes to the presenter and the component
2015-09-18 10:35:29 +02:00
Antonio Scandurra
bf7d7e0d2a
Improve LinesYardstick design
...
We have shifted the responsibility of orchestrating state updates and
measurements to the yardstick. The presenter still needs to be updated to make
use of these new capabilities.
2015-09-18 10:17:55 +02:00
Antonio Scandurra
8a0d029ad1
🎨 Rename to ::onWillNeedMeasurements
2015-09-17 16:34:57 +02:00
Antonio Scandurra
2dd944f3ee
Trigger ::onWillMeasure before measuring anything
2015-09-16 12:07:57 +02:00
Antonio Scandurra
2750a384ac
💚 Fix TextEditorPresenter specs
...
...so that they play nicely with LinesYardstick
2015-09-16 11:33:51 +02:00
Antonio Scandurra
578b157da0
Differentiate between gutter and lines tiles
...
...and fix specs as well. 💚
2015-09-15 17:22:22 +02:00
Antonio Scandurra
8e06e06899
Compute the state for the longest line on screen
2015-09-15 16:32:42 +02:00
Antonio Scandurra
fe039a0f3c
💚
2015-09-09 13:31:34 +02:00
Antonio Scandurra
0d248e0c5b
Merge pull request #8500 from natthu/master
...
Fix a bug with refreshing the gutter UI.
2015-08-31 14:24:12 +02:00
Nathan Sobo
314e082f1d
Clean up max scroll margin code
...
Previously we were attempting the same computation twice, once
incorrectly when returning the scroll margins as integers and then doing
the same thing in terms of pixels. This just cleans up the original
calculation. It’s *slightly* different because it takes the floor to
continue returning integers, but the behavior is extremely close.
2015-08-27 17:40:01 -06:00
Natthu Bharambe
20aa3a6a87
Fix nits with the spec.
...
Summary:
Test Plan:
Reviewers:
CC:
Task ID: #
Blame Rev:
2015-08-27 08:38:05 -07:00
Natthu Bharambe
aba76015b0
Add a spec to verify gutter decorations are updated even if a higher priority gutter is hidden.
2015-08-26 15:17:03 -07:00
Antonio Scandurra
b5c0f5ac0b
Change lines container height based on boundingClientRect
2015-08-26 16:21:51 +02:00
Max Brunsfeld
a60f330628
Default maintainHistory marker option to false
2015-07-21 13:27:05 -07:00
Antonio Scandurra
4e4b49eef8
🐛 updateContentDimensions when model changes
2015-07-07 11:28:30 +02:00
Antonio Scandurra
ce3304b788
🔥 Delete redundant specs
2015-06-12 18:41:19 +02:00
Antonio Scandurra
605f584d2e
Extract tiles specs into tiledContentContract
2015-06-12 12:53:29 +02:00
