Jason Rudolph
4fecbaf4f5
Merge master into jr-fix-observe-text-editor-methods
2017-06-06 13:59:35 -04:00
Jason Rudolph
268f94b89d
Merge pull request #14695 from atom/jr-editors-live-in-workspace-center
...
Provide API for observing the active text editor
2017-06-06 10:09:52 -04:00
Jason Rudolph
0cadf7e888
Merge branch 'jr-editors-live-in-workspace-center' into jr-fix-observe-text-editor-methods
2017-06-05 17:07:31 -04:00
Jason Rudolph
2347c9bdaa
Always invoke callback with current active text editor
...
This makes observeActiveTextEditor consistent with observers like
observeActivePaneItem, which always invoke the callback with the current
value, regardless of whether that value is undefined or not.
2017-06-02 15:55:00 -04:00
Jason Rudolph
44a2be7c9d
Test deserialization in terms of user-observable functionality
...
- Rework serialization/deserialization test
- Move simulateReload function so that it can be used in multiple
describe blocks
2017-06-02 15:30:53 -04:00
Jason Rudolph
5b61c0a949
🐛 Initialize active editor state correctly after reload
...
Fixes the following bug:
1. Open Atom
2. Open a file
3. Observe the file's encoding in the status bar
4. Reload Atom
5. Close the file
6. Observe that the closed file's encoding is still present in the
status bar
This bug occured because the reload did not deserialize/serialze the
workspace's active text editor state. As a result, when closing the
text editor in step 5, we failed to notify observers that there is no
longer an active text editor.
2017-06-02 08:01:42 -04:00
Jason Rudolph
f8ebd71200
Deprecate Dock::getActiveTextEditor()
2017-06-01 15:24:50 -04:00
Antonio Scandurra
6d1f8ea88c
Render line number gutter without numbers when showLineNumbers is false
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-06-01 16:29:04 +02:00
Jason Rudolph
16e1ef917b
Update Workspace specs regarding editors in docks
2017-06-01 09:34:56 -04:00
Nathan Sobo
2372227b00
Fix specs on macOS when "Show scroll bars" option isn't "always"
2017-06-01 12:01:11 +02:00
Jason Rudolph
05efc143ed
Add Workspace::observeActiveTextEditor()
2017-05-31 16:17:54 -04:00
Jason Rudolph
cf50625cc6
Teach Workspace::getActiveTextEditor() to get item from center
2017-05-31 14:32:20 -04:00
Wliu
16be073c91
Merge branch 'master' into wl-build-on-node-7
2017-05-30 15:40:02 -04:00
Jason Rudolph
a49203504c
🐛 Add missing onDidAddTextEditor method to WorkspaceCenter
...
WorkspaceCenter's observeTextEditors method calls
this.onDidAddTextEditor, but WorkspaceCenter didn't have an
onDidAddTextEditor method. This commit adds a test for
observeTextEditors and it adds the missing onDidAddTextEditor method to
make the test pass.
2017-05-25 17:24:07 -04:00
Jason Rudolph
92d0f60e6c
🐛 Add missing onDidAddTextEditor method to Dock
...
Dock's observeTextEditors() method calls this.onDidAddTextEditor(), but
Dock didn't have an onDidAddTextEditor method. 🙀
Dock's observeTextEditors() method also calls this.getTextEditors(), and
Dock's getTextEditors() method calls
this.paneContainer.getTextEditors(), but there is no getTextEditors()
method on this.paneContainer. 🙈
This commit adds a test for observeTextEditors, and it adds the missing
onDidAddTextEditor method, and it fixes the getTextEditors method to
make the new test pass.
2017-05-25 17:24:06 -04:00
Ian Olsen
d5089936bd
Merge pull request #14420 from atom/fb-mdt-dock-items-dont-cause-restore-state-prompt
...
Don't show restore dialog for non-editor dock items
2017-05-24 08:43:35 -07:00
Ian Olsen
ddcf5460ed
Merge pull request #14427 from atom/fb-hw-url-fix2
...
Fix the atom:// URL handler for real (with tests this time)
2017-05-24 08:41:43 -07:00
Jason Rudolph
efa440f705
Merge pull request #14460 from atom/jr-activate-next-or-previous-pane-in-dock
...
Fix ability to activate next/previous pane in a dock
2017-05-22 10:03:26 -04:00
Jason Rudolph
3020a61e34
Test activating next/previous pane at the workspace level
2017-05-19 10:49:51 -04:00
Jason Rudolph
8079b51839
Remove unnecessary test setup
...
H/T @nathansobo
2017-05-19 09:33:06 -04:00
Antonio Scandurra
d158e44374
Merge branch 'master' into tj-upgrade-electron
2017-05-19 11:05:15 +02:00
Max Brunsfeld
e99545ee41
Fix exception when starting to drag text
2017-05-18 10:13:48 -07:00
Jason Rudolph
d599b52d36
✅ Add failing tests for #14442
2017-05-17 15:26:42 -04:00
hansonw
e8cd4bf431
Fix the atom:// URL handler for real (with tests this time)
2017-05-16 11:51:54 -07:00
Antonio Scandurra
d44876f3bc
Merge branch 'master' into tj-upgrade-electron
2017-05-16 14:39:47 +02:00
Antonio Scandurra
3b3505d969
Always allow to destroy free-form folds from the gutter
2017-05-16 14:36:50 +02:00
Antonio Scandurra
ad6202cadb
Show foldable icon on the last screen row belonging to a buffer row
2017-05-16 14:26:57 +02:00
Antonio Scandurra
4c5127ca2f
Update foldable icon when a row's foldability changes
2017-05-16 14:05:11 +02:00
Matthew Dapena-Tretter
80ced1140c
Don't show restore dialog for non-editor dock items
...
The Nuclide file tree was causing this dialog to be shown every time.
With this commit, we exclude non-editor dock items from the "dirty"
check.
2017-05-15 16:13:29 -07:00
Lee Dohm
1559c8a047
Merge pull request #12946 from jamsinclair/11848-fix-moving-line-without-line-ending
...
Fixes #11848 Moving line up without line ending
2017-05-13 15:00:46 -07:00
Antonio Scandurra
96533998e2
Fix editor element tests on Windows
2017-05-12 16:51:05 +02:00
Antonio Scandurra
0d4e2b3556
Fix editor component tests on Windows
2017-05-12 13:04:03 +02:00
Antonio Scandurra
186bcd70a5
Fix running packages preloading tests in interactive mode
...
This change also makes the test more useful, as it verifies that reading
metadata from package.json's `packagesCache` works correctly.
2017-05-12 10:11:58 +02:00
Nathan Sobo
e62d1b91b7
Unspy Date.now when jasmine.useRealClock is called
2017-05-11 21:33:50 -06:00
Nathan Sobo
ffd154ec34
Fix lint errors
2017-05-11 21:29:36 -06:00
Nathan Sobo
5a9582ed64
Silence error output in test
2017-05-11 21:10:20 -06:00
Nathan Sobo
b7218e5aa4
Fix atom.setSize spec when window is full screen
2017-05-11 21:06:15 -06:00
Nathan Sobo
6c6d38a3f0
Destroy environment to silence leaked editor warning
2017-05-11 21:02:28 -06:00
Nathan Sobo
8743298c4c
Avoid polluting test with click events on the test runner
...
We now pass an isolated document into the AtomEnvironment instance under
test to avoid accidentally handling clicks on the test runner itself.
2017-05-11 17:59:40 -06:00
Nathan Sobo
2e2b35c32c
Avoid problems related to calling startEditorWindow in tests
2017-05-11 17:44:16 -06:00
Max Brunsfeld
07c2a8e8d6
Merge pull request #14339 from atom/mb-dont-change-focus-when-hiding-unfocused-dock
...
Don't change focus when hiding an unfocused dock
2017-05-11 16:28:27 -07:00
Nathan Sobo
d584bd6adb
Eliminate reliance on local storage in HistoryManager
...
It's causing test failures locally and enough time has passed that most
user data should be transitioned to indexed DB by now.
2017-05-11 16:58:54 -06:00
Nathan Sobo
f8ecf929a8
Disable github package in smoke test – it takes too long to compile
2017-05-11 16:46:02 -06:00
Nathan Sobo
80f033114c
Mock Date.now in spec helper in addition to _.now
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2017-05-11 15:20:53 -06:00
Wliu
7c2510eb9c
Merge branch 'master' into wl-build-on-node-7
2017-05-11 12:06:26 -04:00
Antonio Scandurra
729ae0ea51
Merge branch 'master' into tj-upgrade-electron
...
# Conflicts:
# script/package.json
# src/task.coffee
2017-05-11 18:05:12 +02:00
Antonio Scandurra
32f03c8a22
Delete unused code
2017-05-11 11:07:21 +02:00
Antonio Scandurra
39a5705e39
Re-enable a test that was previously failing
2017-05-11 11:06:35 +02:00
Nathan Sobo
048a548462
Fix specs
2017-05-10 14:18:15 -06:00
Antonio Scandurra
e89552ea75
Ignore mismatched tags between lines in TokenizedBufferIterator
...
Previously the DisplayLayer would have issues when closing tags that had
not been previously opened, requiring us to guard against mismatched
scopes at the frontier of asynchronous tokenization (see 5cfe9716nathan@github.com >
2017-05-10 17:54:14 +02:00
