Commit Graph

7257 Commits

Author SHA1 Message Date
probablycorey
5e674fe29e Add commonly used Editor methods to Editor View
Mini-editors use these methods very often, but really we shouldn't need to do
this.
2014-01-10 16:38:36 -08:00
probablycorey
c19c8c5341 Fix core specs 2014-01-10 15:32:59 -08:00
probablycorey
21b40acdf1 Remove delegate methods from EditorView 2014-01-10 15:31:33 -08:00
Nathan Sobo
6eacfa7077 Call Range::toString, not ::inspect in DisplayBufferMarker::inspect 2014-01-09 19:04:52 -07:00
Ben Ogle
0d2067e1a4 Merge pull request #1400 from atom/bo-fuck-rejection
Dont use reject in project::scan cancel
2014-01-09 17:09:58 -08:00
Ben Ogle
fbcfad28c3 Reject is broken. Ugh. Just resolve it 2014-01-09 17:00:34 -08:00
Kevin Sawicki
20ee7b432c Wrap item in array since it is a trigger call 2014-01-09 15:18:44 -08:00
Corey Johnson
378901e0d2 Merge pull request #1375 from atom/ns-fix-crash-exit
Properly exit when render process crashes if exitWhenDone option is true
2014-01-09 15:08:56 -08:00
Kevin Sawicki
d96b63d791 Move enable/disable to parent Package class
This was previously unimplemented in TextMatePackage causing exceptions
when trying to enable/disable a package of that type.
2014-01-09 14:13:49 -08:00
Kevin Sawicki
371e31c786 🐎 Test for prefix without calling path.join
Directory::relativize is called many times by the fuzzy finder
and using path.join possibly multiple times per call was consuming
much of the time take to show the fuzzy finder view.
2014-01-08 17:55:08 -08:00
Kevin Sawicki
d95aa0aac1 Expand buffer range in Selection::selectLine 2014-01-08 16:27:09 -08:00
Kevin Sawicki
0fd8b6be8d Pluralize selection in event name 2014-01-08 15:45:09 -08:00
Kevin Sawicki
c8f3e056e9 Pluralize selections in method name 2014-01-08 15:17:06 -08:00
Kevin Sawicki
32fdf0b681 📝 Drop line about single line selections 2014-01-08 15:17:06 -08:00
Kevin Sawicki
82c73c9911 📝 Tweak comment for clarity 2014-01-08 15:17:06 -08:00
Kevin Sawicki
0ef6757e65 Add Editor::splitSelectionIntoLines 2014-01-08 15:17:06 -08:00
Corey Johnson
c089429c14 Merge pull request #1367 from atom/cj-error-event
Add error event to atom global
2014-01-08 11:17:04 -08:00
Kevin Sawicki
cf47ee5063 Only call _.isEqual when needed
Invert the logic to return if all are equal so we can fall through
on the first false call so only the minimum isEqual calls are made.

Also perform the boolean check first instead of last since it
cheaper than a Point comparison.

This showed up in the profile when profiling moving the cursor.
2014-01-08 10:59:39 -08:00
Kevin Sawicki
9d6a01d11c Use slice to clone array 2014-01-08 10:59:39 -08:00
Nathan Sobo
57c23e1b5f Merge remote-tracking branch 'origin/master' into ns-text-buffer-cleanup 2014-01-08 10:53:19 -07:00
Nathan Sobo
f8d959ae16 Upgrade to text-buffer 0.12.0
* Drop deprecation of insert/append/delete. The method names will remain
  short.

* Replace ::getLastPosition with ::getEndPosition
2014-01-08 10:53:07 -07:00
Nathan Sobo
eab26fb3a6 Properly exit when render process crashes if exitWhenDone option is true
Previously, we were referring to an undefined `atom` global to exit when
the render process crashed in specs. Now we only exit when exitWhenDone
is true, which will only exit in headless specs. Also, we now call .exit
on an object that's actually defined.
2014-01-07 19:22:42 -07:00
Nathan Sobo
17947d0f99 Enable harmony proxies
I want to use these in the pane-models branch, so it will be helpful
if they are enabled in atom stable since it's an atom-shell level
setting.
2014-01-07 19:22:22 -07:00
Kevin Sawicki
f29ce127db Default windowState to empty hash JSON string 2014-01-07 11:19:38 -08:00
Nathan Sobo
b29f1965f0 Move more methods into text-buffer npm 2014-01-07 10:19:43 -07:00
Nathan Sobo
48a2a1934b Start moving text related methods to text-buffer npm 2014-01-07 09:18:59 -07:00
Kevin Sawicki
44a3365787 Rename getRealPath to getRealPathSync 2014-01-06 17:25:26 -08:00
Kevin Sawicki
f3e88b56f3 🐎 Reduce stat calls when building entries
Previously every entry was stated twice to determine if it was a
file/directory and a symbolic link.

Now the second stat call is only made if lstat returns stat details
for a symbolic link.
2014-01-06 17:25:26 -08:00
Kevin Sawicki
d618472f95 Specify error as first argument 2014-01-06 17:25:26 -08:00
Kevin Sawicki
a45ffb3aaa Add async Directory::getEntries 2014-01-06 17:25:26 -08:00
Kevin Sawicki
1d2b2eec4c Add Sync suffix to Directory::getEntries 2014-01-06 17:25:26 -08:00
probablycorey
85a6db253b Spat the event arguments 2014-01-06 16:48:47 -08:00
probablycorey
022ead9228 Rename error event to uncaught-error 2014-01-06 16:22:04 -08:00
probablycorey
5975884a0e Add error event to atom global 2014-01-06 16:11:39 -08:00
Nathan Sobo
d6de973500 Remove shims that call super
They were previously there for documentation purposes, but we've decided
to document them in the text-buffer npm directly and link it into the
documentation. This drops some of the docs on delegated methods, because
our docs generator doesn't understand `delegatesMethods` declarations,
but TextBuffer was marked private anyway so we can get back to it later.
2014-01-06 15:16:34 -07:00
Nathan Sobo
25cc37bc86 Replace {StringMarker} references with {Marker} in API docs 2014-01-06 15:13:12 -07:00
Nathan Sobo
cbec03c158 Rename reactionary to theorist 2014-01-05 10:25:59 -07:00
Nathan Sobo
9068f28e83 Fix variable name 2014-01-04 14:08:00 -07:00
Nathan Sobo
0292c66f93 Don't drop editor subscriptions in its destroyed hook
Unsubscribing should be the responsibility of the subscribers and doing
this was removing 'destroyed' subscriptions before the 'destroyed' event
was emitted now that 'destroyed' is emitted by the default
Model::destroy method.
2014-01-04 10:08:04 -07:00
Nathan Sobo
cb7471945c Remove redundant 'destroyed' event 2014-01-03 19:35:07 -07:00
Nathan Sobo
8da9e8ddc1 Rename nostalgia to serializable
This name was surprisingly available and better matches this module's
utilitarian nature.
2014-01-03 18:32:44 -07:00
Nathan Sobo
c6770aa83e Merge remote-tracking branch 'origin/master' into ns-remove-telepath-from-core
Conflicts:
	package.json
	src/pane.coffee
2014-01-03 17:46:45 -07:00
Nathan Sobo
e26d97d5ac Remove telepath as a core dependency 2014-01-03 17:42:11 -07:00
Corey Johnson
b2177cbc09 Merge pull request #1360 from atom/cj-add-prepend-append-methods-to-workspace
Add prepend/append methods to WorkspaceView
2014-01-03 16:34:16 -08:00
probablycorey
9f32a24e7e Add all Tool Panel append and prepend methods 2014-01-03 15:43:00 -08:00
Nathan Sobo
914a87290b Remove unnecessary telepath requires 2014-01-03 16:36:26 -07:00
probablycorey
066d8dc944 Add prependToBottom and appendToBottom 2014-01-03 15:26:27 -08:00
Nathan Sobo
bc65137911 Remove telepath from Project, WorkspaceView, and Pane* 2014-01-03 16:23:23 -07:00
Nathan Sobo
3d494ed9fa Merge pull request #1337 from atom/ns-fix-mini-editor-leak
Fix mini editor leak
2014-01-03 11:58:02 -08:00
Nathan Sobo
77dba8d19b Merge branch 'master' into ns-fix-mini-editor-leak 2014-01-03 10:03:25 -07:00