Kevin Sawicki & Nathan Sobo
3bd98ff182
Calculate pixel position of both bracket highlights before adding them
...
Before, we were causing a layout to occur twice because we needed to
read the DOM for the pixel position of the second highlight view after
invalidating the DOM when adding the first highlight view.
2013-02-14 17:30:08 -07:00
Kevin Sawicki
1f9e5aea06
Clear mini editor when detaching
2013-02-14 14:36:27 -08:00
Kevin Sawicki
77e9377865
Close command panel on core:cancel event
2013-02-14 12:49:33 -08:00
Nathan Sobo
2f71ee9a0d
Prevent clicks on a focused editor from unfocusing its hidden input
...
This closes #233 . When an editor is focused, what's *actually* focused
is a hidden input element inside the editor. So clicking on a focused
editor was temporarily stealing focus away from the hidden input, and
then moving it back to the hidden input (which the editor always does
when it is focused). Returning false from the mousedown handler when
the editor is already focused prevents this bouncing of focus and
prevents the fuzzy finder from hiding when you click its editor.
2013-02-14 13:38:46 -07:00
Kevin Sawicki
aa69452552
Focus rootView directlly instead of by selector
2013-02-14 12:31:12 -08:00
Kevin Sawicki
15c02014f7
💄
2013-02-14 12:27:46 -08:00
Kevin Sawicki
363a1bbbab
Remove unused require
2013-02-14 12:27:39 -08:00
Corey Johnson & Nathan Sobo
da59459197
Autoscroll the last cursor when it inserts text
...
Normally, we don't autoscroll to a cursor when the buffer changes. But
this is a change caused by the cursor itself, so it makes sense to
keep it in view.
2013-02-14 13:21:39 -07:00
Kevin Sawicki
1fed183a8c
Perform whitespace check after scopes check
2013-02-14 11:48:03 -08:00
Kevin Sawicki
e0556d85af
Advance over tokens that are only whitespace
2013-02-14 11:47:07 -08:00
Kevin Sawicki
21a56b991c
Move scroll logic to individual views
2013-02-14 11:25:08 -08:00
Corey Johnson & Nathan Sobo
52cbf5e367
Correctly translate clicks to screen positions w/ var-width fonts
...
Closes #267
2013-02-14 12:04:18 -07:00
Kevin Sawicki
d5759752b5
Remove unneeded rootView variable
2013-02-14 11:00:45 -08:00
Kevin Sawicki
1ab0db11bd
Support folding multi-line comments
2013-02-14 10:57:39 -08:00
Kevin Sawicki
eb179af0d4
Merge pull request #271 from github/super-command-panel
...
Super command panel
2013-02-14 10:13:40 -08:00
Kevin Sawicki
bcaa1a6819
Allow preview of editor if grammar is source.gfm
...
Previously only markdow file extensions were considered
but any editor whose grammar is GitHub Markdow should have
preview enabled.
Closes #277
2013-02-14 09:49:03 -08:00
Kevin Sawicki
ea34ad0608
Expand/collapse result with ctrl-[]
2013-02-14 09:30:57 -08:00
Kevin Sawicki
b8b989a94c
Use editor.preferredLineLength as default column
...
This config value will be used when no custom column
exists for the current path.
2013-02-14 09:14:05 -08:00
Kevin Sawicki
43d46f0705
Load all .css files when theme has no package file
...
Closes #263
2013-02-14 09:04:32 -08:00
Kevin Sawicki
48407da6aa
Subscribe to preview list events
2013-02-13 23:05:21 -08:00
Kevin Sawicki
fd2edb1d4d
Only select last operation if path is expanded
2013-02-13 23:02:02 -08:00
Kevin Sawicki
5ec2fb6866
Update specs for new path view layout
2013-02-13 22:52:28 -08:00
Kevin Sawicki
122e0e5f91
Use pathDetails outlet for mousedown event
2013-02-13 22:49:34 -08:00
Kevin Sawicki
156d96a2e7
Toggle expansion on core:confirm event
2013-02-13 22:47:01 -08:00
Kevin Sawicki
528050adbb
Remove unneeded rootView ivar
2013-02-13 22:33:56 -08:00
Kevin Sawicki
cc10ae4bdb
Only set selected background on path details
...
Previously the background of the entire li was
changed when selected.
2013-02-13 22:33:29 -08:00
Kevin Sawicki
2d4ea98c0a
Always retain selection on path node when collapsing
2013-02-13 22:09:13 -08:00
Kevin Sawicki
59a613de73
Focus preview list after expanding/collapsing all
2013-02-13 22:08:30 -08:00
Kevin Sawicki
b626ce91a9
Don't select operations if path is collapsed
2013-02-13 22:06:00 -08:00
Kevin Sawicki
1cc6429dc7
Select path when collapsed via command
2013-02-13 21:57:42 -08:00
Kevin Sawicki
20d7956cc1
Expand result with right arrow key
2013-02-13 21:49:48 -08:00
Kevin Sawicki
4088d33dc9
Allow paths to be selected
...
This will allow them to be navigated to with the
keyboard and collapsed or expanded.
2013-02-13 21:42:41 -08:00
Kevin Sawicki
61481fc1d8
Execute operation from OperationView
2013-02-13 19:20:43 -08:00
Kevin Sawicki
7c4c44df5a
Subscribe to collapse event in PathView
2013-02-13 18:49:39 -08:00
Kevin Sawicki
5b1acb5188
Move collapse result command to PathView
2013-02-13 18:47:15 -08:00
Kevin Sawicki
9dcb124ff7
Move path selection to view class
2013-02-13 18:30:08 -08:00
Kevin Sawicki
e03a669413
Collapse/expand views directly
2013-02-13 18:20:48 -08:00
Kevin Sawicki
72bbe3323b
Create views for path and operations
...
The CommandPanelView is becoming bloated and this is the
beginning of breaking out some of the logic into separate
views.
2013-02-13 18:11:30 -08:00
Kevin Sawicki
e67843635e
Use addClass instead of add
2013-02-13 17:36:49 -08:00
Kevin Sawicki
a42a82c8c0
Collapse selected path with left arrow
2013-02-13 17:27:53 -08:00
Kevin Sawicki
1a8bba4d70
Attach to DOM before checking visibility
2013-02-13 17:14:37 -08:00
Kevin Sawicki
1922034df5
Disable jquery fx in specs
2013-02-13 17:13:15 -08:00
Kevin Sawicki
d7b6b282a5
Subtract preview list offset from top
2013-02-13 16:53:10 -08:00
Corey Johnson
8375c8df38
Use previous package state when the wasn't activated
2013-02-13 16:37:59 -08:00
Corey Johnson
958bc2bfab
Moved atom.loadPackage to a spec-only helper function
2013-02-13 16:37:59 -08:00
Justin Palmer
de2b1a8770
fix preview list automatic scrolling
2013-02-13 16:13:44 -08:00
Kevin Sawicki
894ed139a0
Remove dangling function
2013-02-13 16:12:59 -08:00
Kevin Sawicki
64203b6361
Always hide/show preview list and header together
2013-02-13 16:07:44 -08:00
Kevin Sawicki
307be184c8
Collapse/expand all with ctrl-{}
2013-02-13 15:50:51 -08:00
Justin Palmer
936324a75f
use offset instead of position
2013-02-13 15:36:39 -08:00
