Commit Graph

44 Commits

Author SHA1 Message Date
Nathan Sobo
1902a0c553 Get CommandPanel specs passing without getActiveEditor/EditSession 2013-03-07 09:30:23 -08:00
Nathan Sobo
beaeac4425 Rename buildEditSessionForPath to buildEditSession
Since this is the more external method, having a shorter name
is more convenient. The former `buildEditSession` method took a
Buffer, and is now called `buildEditSessionForBuffer`.
2013-03-07 09:28:51 -08:00
Corey Johnson & Kevin Sawicki
34ab1d5c03 Remove unused variable 2013-02-25 18:20:42 -08:00
Corey Johnson & Nathan Sobo
47aa74133f Remove unneeded calls to rootView.deactivate 2013-02-19 18:26:51 -07:00
Corey Johnson & Nathan Sobo
9e8831f710 RootView.initialize no longer assigns window.rootView or calls open 2013-02-19 18:26:50 -07:00
Corey Johnson & Nathan Sobo
0b5ea8578f Eliminate rootView.project references. 2013-02-19 18:26:50 -07:00
Kevin Sawicki
1f9e5aea06 Clear mini editor when detaching 2013-02-14 14:36:27 -08:00
Kevin Sawicki
77e9377865 Close command panel on core:cancel event 2013-02-14 12:49:33 -08:00
Kevin Sawicki
eb179af0d4 Merge pull request #271 from github/super-command-panel
Super command panel
2013-02-14 10:13:40 -08:00
Kevin Sawicki
5ec2fb6866 Update specs for new path view layout 2013-02-13 22:52:28 -08:00
Kevin Sawicki
156d96a2e7 Toggle expansion on core:confirm event 2013-02-13 22:47:01 -08:00
Kevin Sawicki
b626ce91a9 Don't select operations if path is collapsed 2013-02-13 22:06:00 -08:00
Kevin Sawicki
1cc6429dc7 Select path when collapsed via command 2013-02-13 21:57:42 -08:00
Kevin Sawicki
20d7956cc1 Expand result with right arrow key 2013-02-13 21:49:48 -08:00
Kevin Sawicki
4088d33dc9 Allow paths to be selected
This will allow them to be navigated to with the
keyboard and collapsed or expanded.
2013-02-13 21:42:41 -08:00
Kevin Sawicki
a42a82c8c0 Collapse selected path with left arrow 2013-02-13 17:27:53 -08:00
Kevin Sawicki
1a8bba4d70 Attach to DOM before checking visibility 2013-02-13 17:14:37 -08:00
Corey Johnson
958bc2bfab Moved atom.loadPackage to a spec-only helper function 2013-02-13 16:37:59 -08:00
Kevin Sawicki
64203b6361 Always hide/show preview list and header together 2013-02-13 16:07:44 -08:00
Justin Palmer
636bb21bbc 💄 2013-02-13 14:16:20 -08:00
Kevin Sawicki
7b1f9c86ad Only select child spans in spec selector 2013-02-13 14:00:58 -08:00
Justin Palmer
1e325fe28e need a hand with these specs 2013-02-13 13:44:03 -08:00
Corey Johnson & Kevin Sawicki
2d80d27ca7 Modernize command-panel package with package.cson 2013-02-08 17:28:07 -08:00
Nathan Sobo
4fdb1c454e Restore marker cleanup assertions
Now that EditSessions clean up their markers, we can pass these tests
again.
2013-02-06 17:29:08 -07:00
Kevin Sawicki & Nathan Sobo
59d0742c17 Remove Anchor and AnchorRange. They're fully replaced by markers.
We're still leaking markers for selections and cursors. We need to
clean that up before merging.
2013-02-05 18:15:48 -07:00
Kevin Sawicki
278b8c3df1 Trigger move-up to reset top scroll to 0 2013-02-04 15:26:46 -08:00
Justin Palmer
a0f06e09d6 fix command panel specs that I broke
We're now refocusing the preview list instead of the editor
2013-01-31 12:09:40 -08:00
Kevin Sawicki
35b7ad5ee3 Add match count to path header text 2013-01-25 13:08:58 -08:00
Kevin Sawicki
0f314f573b Add match and file count to command panel preview 2013-01-25 09:23:18 -08:00
Kevin Sawicki
63b9a4b179 Kill wrap-around in command panel preview list
Jumping from top to bottom can be still done using
meta-up and meta-down.
2013-01-25 08:51:16 -08:00
Kevin Sawicki
bc3646f180 💄 2013-01-23 16:24:40 -08:00
Kevin Sawicki
513a29d70e Add deferred package type
This package defers loading until specific commands are
triggered on the root view.
2013-01-22 18:26:48 -08:00
Kevin Sawicki
ca596db310 Extend AtomPackage directly in packages index.coffee 2013-01-22 18:26:48 -08:00
Kevin Sawicki
170b50ddf0 Use search pattern with fewer matches to speed up spec 2013-01-11 10:25:41 -08:00
Kevin Sawicki
14d9fc5e45 Search for a more specific string
This spec only requires one match so don't search
for something that has many matches and will take
longer to display.

Reduces the run time of this spec by ~1.5 seconds.
2013-01-10 09:01:14 -08:00
Kevin Sawicki
339d29e1b5 Search for something with fewer results
Previously the search query used in the command panel
spec returned 500+ matches when the specs needed far
less to verify moving up and down and scrolling.

This reduces the time take to run the command panel spec
by ~2.5 seconds.
2013-01-10 08:47:10 -08:00
Kevin Sawicki
8e1ae24eb4 Update selected operation on move-to-top/move-to-bottom 2013-01-04 13:35:05 -08:00
Nathan Sobo
8591c86733 Pass a name string to RootView.activatePackage & deactivatePackage
Previously we were relying on the package module itself to have a
`name` field. But now that we're using `atom.loadPackage` to load up
packages, we can infer the name of the module from the name of the
package directory.
2013-01-04 14:33:01 -07:00
Kevin Sawicki
ef39cc7f2d Scroll to top when selecting first element
This ensures that the top path is always visible
when the first operation is selected.
2013-01-04 09:04:21 -08:00
Kevin Sawicki
a891dec093 Wrap around the preview-list when moving up/down 2013-01-04 08:59:20 -08:00
Kevin Sawicki
7427d4e4ec Update selector to use li text 2013-01-04 08:44:00 -08:00
Kevin Sawicki
2d5fed9243 Display line numbers of operations
Group operations by path and place path
above operations
2013-01-04 08:24:46 -08:00
Nathan Sobo
7dcb12ada2 RootView talks about packages and packageModules, not extensions
Now you call `rootView.activatePackage`, etc
2012-12-19 19:24:44 -07:00
Nathan Sobo
4ce8583cb2 Rename extensions to packages
We now look at the `core.disabledPackages` config key. Rename the `src/extensions` directory to `src/packages`. The config object now talks about loading packages instead of extensions.
2012-12-18 20:03:21 -07:00